You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "V.Narayanan (JIRA)" <ji...@apache.org> on 2007/05/30 12:29:15 UTC
[jira] Created: (DERBY-2730) Implement not implemented Embedded
methods Blob.getBinaryStream(long pos, long length) and Clob.
getCharacterStream(long pos, long length)
Implement not implemented Embedded methods Blob.getBinaryStream(long pos, long length) and Clob. getCharacterStream(long pos, long length)
------------------------------------------------------------------------------------------------------------------------------------------
Key: DERBY-2730
URL: https://issues.apache.org/jira/browse/DERBY-2730
Project: Derby
Issue Type: New Feature
Components: JDBC
Reporter: V.Narayanan
The following methods were introduced in the java.sql.Clob and java.sql.Blob interface as part of JDBC 4.0 and need to be implemented.
Clob
------
getCharacterStream(long pos, long length)
Blob
------
getBinaryStream(long pos, long length)
The implementation on the Network Client is already done as part of Derby-2444
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2730) Implement not implemented Embedded
methods Blob.getBinaryStream(long pos, long length) and Clob.
getCharacterStream(long pos, long length)
Posted by "Bernt M. Johnsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12500330 ]
Bernt M. Johnsen commented on DERBY-2730:
-----------------------------------------
I saw no white-space or layout issues. By "clean patch" in my comment, I meant a stand-alone patch independent of other non-committed changes.
> Implement not implemented Embedded methods Blob.getBinaryStream(long pos, long length) and Clob. getCharacterStream(long pos, long length)
> ------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: DERBY-2730
> URL: https://issues.apache.org/jira/browse/DERBY-2730
> Project: Derby
> Issue Type: New Feature
> Components: JDBC
> Reporter: V.Narayanan
> Assignee: V.Narayanan
> Attachments: GetBinaryStreamImpl_v1_NOT_FOR_COMMIT.diff, GetBinaryStreamImpl_v1_NOT_FOR_COMMIT.stat
>
>
> The following methods were introduced in the java.sql.Clob and java.sql.Blob interface as part of JDBC 4.0 and need to be implemented.
> Clob
> ------
> getCharacterStream(long pos, long length)
> Blob
> ------
> getBinaryStream(long pos, long length)
> The implementation on the Network Client is already done as part of Derby-2444
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2730) Implement not implemented Embedded
methods Blob.getBinaryStream(long pos, long length) and Clob.
getCharacterStream(long pos, long length)
Posted by "V.Narayanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12500329 ]
V.Narayanan commented on DERBY-2730:
------------------------------------
Thank you for the reviews and comments.
> 1) Looks fair enough, although I will not consider the review done until after DERBY-2711 is committed and a clean patch submitted.
The Derby-2711 changes will not exist when I submit a follow-up patch once Derby-2711
is committed.
You have mentioned clean patch, so I just wanted to ensure that you did
feel unhappy with the alignment, non-presence of whit-space diffs and other general
standard requirements of clean code.
Pls do mention if the code is falling in quality in any of these and
I will correct them duly.
> 2) There's no explanation why Clob.getCharacterStream isn't a part of this patch.
I am sorry I should have mentioned this in the comments.
Derby-2712 seems to be making changes to the wrapper in the same way
Derby-2711 does. I could therefore not pull-out a patch as I have done in the
case of Derby-2711 and make changes in way of a review patch since any
changes to current classes would have had a conflict from the patch for Derby-2712.
Can someone familiar with Derby-2712 pls tell me if the assumption I have made in the
above comment is correct?
> Implement not implemented Embedded methods Blob.getBinaryStream(long pos, long length) and Clob. getCharacterStream(long pos, long length)
> ------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: DERBY-2730
> URL: https://issues.apache.org/jira/browse/DERBY-2730
> Project: Derby
> Issue Type: New Feature
> Components: JDBC
> Reporter: V.Narayanan
> Assignee: V.Narayanan
> Attachments: GetBinaryStreamImpl_v1_NOT_FOR_COMMIT.diff, GetBinaryStreamImpl_v1_NOT_FOR_COMMIT.stat
>
>
> The following methods were introduced in the java.sql.Clob and java.sql.Blob interface as part of JDBC 4.0 and need to be implemented.
> Clob
> ------
> getCharacterStream(long pos, long length)
> Blob
> ------
> getBinaryStream(long pos, long length)
> The implementation on the Network Client is already done as part of Derby-2444
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2730) Implement not implemented Embedded
methods Blob.getBinaryStream(long pos, long length) and Clob.
getCharacterStream(long pos, long length)
Posted by "V.Narayanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12504123 ]
V.Narayanan commented on DERBY-2730:
------------------------------------
I have run tests on GetBinaryStreamImpl_v2.diff and saw no failures. If everything is OK I request
for this patch to be considered for a commit.
> Implement not implemented Embedded methods Blob.getBinaryStream(long pos, long length) and Clob. getCharacterStream(long pos, long length)
> ------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: DERBY-2730
> URL: https://issues.apache.org/jira/browse/DERBY-2730
> Project: Derby
> Issue Type: New Feature
> Components: JDBC
> Affects Versions: 10.3.0.0
> Reporter: V.Narayanan
> Assignee: V.Narayanan
> Fix For: 10.3.0.0
>
> Attachments: GetBinaryStreamImpl_v1.diff, GetBinaryStreamImpl_v1.stat, GetBinaryStreamImpl_v1_NOT_FOR_COMMIT.diff, GetBinaryStreamImpl_v1_NOT_FOR_COMMIT.stat, GetBinaryStreamImpl_v2.diff, GetBinaryStreamImpl_v2.stat
>
>
> The following methods were introduced in the java.sql.Clob and java.sql.Blob interface as part of JDBC 4.0 and need to be implemented.
> Clob
> ------
> getCharacterStream(long pos, long length)
> Blob
> ------
> getBinaryStream(long pos, long length)
> The implementation on the Network Client is already done as part of Derby-2444
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2730) Implement not implemented Embedded
methods Blob.getBinaryStream(long pos, long length) and Clob.
getCharacterStream(long pos, long length)
Posted by "V.Narayanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12504595 ]
V.Narayanan commented on DERBY-2730:
------------------------------------
I will fix this Bernt! Thanx for the review.
> Implement not implemented Embedded methods Blob.getBinaryStream(long pos, long length) and Clob. getCharacterStream(long pos, long length)
> ------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: DERBY-2730
> URL: https://issues.apache.org/jira/browse/DERBY-2730
> Project: Derby
> Issue Type: New Feature
> Components: JDBC
> Affects Versions: 10.3.0.0
> Reporter: V.Narayanan
> Assignee: V.Narayanan
> Fix For: 10.3.0.0
>
> Attachments: GetBinaryStreamImpl_v1.diff, GetBinaryStreamImpl_v1.stat, GetBinaryStreamImpl_v1_NOT_FOR_COMMIT.diff, GetBinaryStreamImpl_v1_NOT_FOR_COMMIT.stat, GetBinaryStreamImpl_v2.diff, GetBinaryStreamImpl_v2.stat, GetCharacterStreamImpl_v1.diff, GetCharacterStreamImpl_v1.stat
>
>
> The following methods were introduced in the java.sql.Clob and java.sql.Blob interface as part of JDBC 4.0 and need to be implemented.
> Clob
> ------
> getCharacterStream(long pos, long length)
> Blob
> ------
> getBinaryStream(long pos, long length)
> The implementation on the Network Client is already done as part of Derby-2444
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2730) Implement not implemented Embedded
methods Blob.getBinaryStream(long pos, long length) and Clob.
getCharacterStream(long pos, long length)
Posted by "V.Narayanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12503286 ]
V.Narayanan commented on DERBY-2730:
------------------------------------
I just found out that there was a problem in the machine I was running
tests. But I will anyway run
tests once more today to re-affirm the that there are no problems in the
implementation.
> Implement not implemented Embedded methods Blob.getBinaryStream(long pos, long length) and Clob. getCharacterStream(long pos, long length)
> ------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: DERBY-2730
> URL: https://issues.apache.org/jira/browse/DERBY-2730
> Project: Derby
> Issue Type: New Feature
> Components: JDBC
> Affects Versions: 10.3.0.0
> Reporter: V.Narayanan
> Assignee: V.Narayanan
> Fix For: 10.3.0.0
>
> Attachments: GetBinaryStreamImpl_v1.diff, GetBinaryStreamImpl_v1.stat, GetBinaryStreamImpl_v1_NOT_FOR_COMMIT.diff, GetBinaryStreamImpl_v1_NOT_FOR_COMMIT.stat
>
>
> The following methods were introduced in the java.sql.Clob and java.sql.Blob interface as part of JDBC 4.0 and need to be implemented.
> Clob
> ------
> getCharacterStream(long pos, long length)
> Blob
> ------
> getBinaryStream(long pos, long length)
> The implementation on the Network Client is already done as part of Derby-2444
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2730) Implement not implemented Embedded
methods Blob.getBinaryStream(long pos, long length) and Clob.
getCharacterStream(long pos, long length)
Posted by "V.Narayanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
V.Narayanan updated DERBY-2730:
-------------------------------
Attachment: GetBinaryStreamImpl_v2.stat
GetBinaryStreamImpl_v2.diff
I have made the following changes in the follow-up
1) I have initialized maxPos to -1 in the constructor that
does not accept length as a parameter.
2) I have updated the javadoc to say the following
* Construct an <code>UpdateableBlobStream<code> using the
* <code>InputStream</code> received as parameter. The initial
* position in the stream is set to <code>pos</code> and the
* stream is restricted to a length of <code>len</code>.
Pls do mention if this is OK
I ran BlobClob4BlobTest without failures and have started a junit All run.
Sorry about the delayed test runs. I shall post the results as soon as the test
completes.
> Implement not implemented Embedded methods Blob.getBinaryStream(long pos, long length) and Clob. getCharacterStream(long pos, long length)
> ------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: DERBY-2730
> URL: https://issues.apache.org/jira/browse/DERBY-2730
> Project: Derby
> Issue Type: New Feature
> Components: JDBC
> Affects Versions: 10.3.0.0
> Reporter: V.Narayanan
> Assignee: V.Narayanan
> Fix For: 10.3.0.0
>
> Attachments: GetBinaryStreamImpl_v1.diff, GetBinaryStreamImpl_v1.stat, GetBinaryStreamImpl_v1_NOT_FOR_COMMIT.diff, GetBinaryStreamImpl_v1_NOT_FOR_COMMIT.stat, GetBinaryStreamImpl_v2.diff, GetBinaryStreamImpl_v2.stat
>
>
> The following methods were introduced in the java.sql.Clob and java.sql.Blob interface as part of JDBC 4.0 and need to be implemented.
> Clob
> ------
> getCharacterStream(long pos, long length)
> Blob
> ------
> getBinaryStream(long pos, long length)
> The implementation on the Network Client is already done as part of Derby-2444
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2730) Implement not implemented Embedded
methods Blob.getBinaryStream(long pos, long length) and Clob.
getCharacterStream(long pos, long length)
Posted by "Bernt M. Johnsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12504213 ]
Bernt M. Johnsen commented on DERBY-2730:
-----------------------------------------
getBinaryStream ok.
Committed revision 546838.
> Implement not implemented Embedded methods Blob.getBinaryStream(long pos, long length) and Clob. getCharacterStream(long pos, long length)
> ------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: DERBY-2730
> URL: https://issues.apache.org/jira/browse/DERBY-2730
> Project: Derby
> Issue Type: New Feature
> Components: JDBC
> Affects Versions: 10.3.0.0
> Reporter: V.Narayanan
> Assignee: V.Narayanan
> Fix For: 10.3.0.0
>
> Attachments: GetBinaryStreamImpl_v1.diff, GetBinaryStreamImpl_v1.stat, GetBinaryStreamImpl_v1_NOT_FOR_COMMIT.diff, GetBinaryStreamImpl_v1_NOT_FOR_COMMIT.stat, GetBinaryStreamImpl_v2.diff, GetBinaryStreamImpl_v2.stat
>
>
> The following methods were introduced in the java.sql.Clob and java.sql.Blob interface as part of JDBC 4.0 and need to be implemented.
> Clob
> ------
> getCharacterStream(long pos, long length)
> Blob
> ------
> getBinaryStream(long pos, long length)
> The implementation on the Network Client is already done as part of Derby-2444
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2730) Implement not implemented Embedded
methods Blob.getBinaryStream(long pos, long length) and Clob.
getCharacterStream(long pos, long length)
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12504672 ]
Kristian Waagan commented on DERBY-2730:
----------------------------------------
Unless I get wild protests, I will change the following line in the ClobUpdateableReader constructor as below:
+ maxPos = Math.min(clob.length(), pos + len);
to be simply
maxPos = pos + len;
The reason is that the clob.length() call can be very expensive. At this point, we might have already exhausted the stream two times. Doing it even once more is unnecessary in this case:
* First of all the check is already done in EmbedClob.getCharacterStream(long,long). This must be done to comply with the JDBC spec.
* Second, even if the former test was removed, ClobUpdateableReader would behave properly if maxPos turns out to be set to a value larger then the actual size of the Clob. The underlying stream would simply return -1, which is exactly what the maxPos variable is used for anyway.
The change will go in with another change in a yet-to-be-created-Jira (I will create a link to it).
> Implement not implemented Embedded methods Blob.getBinaryStream(long pos, long length) and Clob. getCharacterStream(long pos, long length)
> ------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: DERBY-2730
> URL: https://issues.apache.org/jira/browse/DERBY-2730
> Project: Derby
> Issue Type: New Feature
> Components: JDBC
> Affects Versions: 10.3.0.0
> Reporter: V.Narayanan
> Assignee: V.Narayanan
> Fix For: 10.3.0.0
>
> Attachments: GetBinaryStreamImpl_v1.diff, GetBinaryStreamImpl_v1.stat, GetBinaryStreamImpl_v1_NOT_FOR_COMMIT.diff, GetBinaryStreamImpl_v1_NOT_FOR_COMMIT.stat, GetBinaryStreamImpl_v2.diff, GetBinaryStreamImpl_v2.stat, GetCharacterStreamImpl_v1.diff, GetCharacterStreamImpl_v1.stat, GetCharacterStreamImpl_v2.diff, GetCharacterStreamImpl_v2.stat
>
>
> The following methods were introduced in the java.sql.Clob and java.sql.Blob interface as part of JDBC 4.0 and need to be implemented.
> Clob
> ------
> getCharacterStream(long pos, long length)
> Blob
> ------
> getBinaryStream(long pos, long length)
> The implementation on the Network Client is already done as part of Derby-2444
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (DERBY-2730) Implement not implemented Embedded
methods Blob.getBinaryStream(long pos, long length) and Clob.
getCharacterStream(long pos, long length)
Posted by "Bernt M. Johnsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bernt M. Johnsen resolved DERBY-2730.
-------------------------------------
Resolution: Fixed
Derby Info: (was: [Patch Available])
Patch ok.
Committed revision 547203.
> Implement not implemented Embedded methods Blob.getBinaryStream(long pos, long length) and Clob. getCharacterStream(long pos, long length)
> ------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: DERBY-2730
> URL: https://issues.apache.org/jira/browse/DERBY-2730
> Project: Derby
> Issue Type: New Feature
> Components: JDBC
> Affects Versions: 10.3.0.0
> Reporter: V.Narayanan
> Assignee: V.Narayanan
> Fix For: 10.3.0.0
>
> Attachments: GetBinaryStreamImpl_v1.diff, GetBinaryStreamImpl_v1.stat, GetBinaryStreamImpl_v1_NOT_FOR_COMMIT.diff, GetBinaryStreamImpl_v1_NOT_FOR_COMMIT.stat, GetBinaryStreamImpl_v2.diff, GetBinaryStreamImpl_v2.stat, GetCharacterStreamImpl_v1.diff, GetCharacterStreamImpl_v1.stat, GetCharacterStreamImpl_v2.diff, GetCharacterStreamImpl_v2.stat
>
>
> The following methods were introduced in the java.sql.Clob and java.sql.Blob interface as part of JDBC 4.0 and need to be implemented.
> Clob
> ------
> getCharacterStream(long pos, long length)
> Blob
> ------
> getBinaryStream(long pos, long length)
> The implementation on the Network Client is already done as part of Derby-2444
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2730) Implement not implemented Embedded
methods Blob.getBinaryStream(long pos, long length) and Clob.
getCharacterStream(long pos, long length)
Posted by "V.Narayanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
V.Narayanan updated DERBY-2730:
-------------------------------
Derby Info: [Patch Available]
> Implement not implemented Embedded methods Blob.getBinaryStream(long pos, long length) and Clob. getCharacterStream(long pos, long length)
> ------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: DERBY-2730
> URL: https://issues.apache.org/jira/browse/DERBY-2730
> Project: Derby
> Issue Type: New Feature
> Components: JDBC
> Affects Versions: 10.3.0.0
> Reporter: V.Narayanan
> Assignee: V.Narayanan
> Fix For: 10.3.0.0
>
> Attachments: GetBinaryStreamImpl_v1.diff, GetBinaryStreamImpl_v1.stat, GetBinaryStreamImpl_v1_NOT_FOR_COMMIT.diff, GetBinaryStreamImpl_v1_NOT_FOR_COMMIT.stat, GetBinaryStreamImpl_v2.diff, GetBinaryStreamImpl_v2.stat
>
>
> The following methods were introduced in the java.sql.Clob and java.sql.Blob interface as part of JDBC 4.0 and need to be implemented.
> Clob
> ------
> getCharacterStream(long pos, long length)
> Blob
> ------
> getBinaryStream(long pos, long length)
> The implementation on the Network Client is already done as part of Derby-2444
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2730) Implement not implemented Embedded
methods Blob.getBinaryStream(long pos, long length) and Clob.
getCharacterStream(long pos, long length)
Posted by "V.Narayanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
V.Narayanan updated DERBY-2730:
-------------------------------
Attachment: GetBinaryStreamImpl_v1.stat
GetBinaryStreamImpl_v1.diff
Derby-2711 has been committed. I have removed these changes from
the patch previously marked as not for commit.
I ran the modified BlobTest and it ran without failures.
I have started a junit All run and shall revert back with
the results.
Pls consider this patch for reviews and comments
> Implement not implemented Embedded methods Blob.getBinaryStream(long pos, long length) and Clob. getCharacterStream(long pos, long length)
> ------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: DERBY-2730
> URL: https://issues.apache.org/jira/browse/DERBY-2730
> Project: Derby
> Issue Type: New Feature
> Components: JDBC
> Affects Versions: 10.3.0.0
> Reporter: V.Narayanan
> Assignee: V.Narayanan
> Fix For: 10.3.0.0
>
> Attachments: GetBinaryStreamImpl_v1.diff, GetBinaryStreamImpl_v1.stat, GetBinaryStreamImpl_v1_NOT_FOR_COMMIT.diff, GetBinaryStreamImpl_v1_NOT_FOR_COMMIT.stat
>
>
> The following methods were introduced in the java.sql.Clob and java.sql.Blob interface as part of JDBC 4.0 and need to be implemented.
> Clob
> ------
> getCharacterStream(long pos, long length)
> Blob
> ------
> getBinaryStream(long pos, long length)
> The implementation on the Network Client is already done as part of Derby-2444
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2730) Implement not implemented Embedded
methods Blob.getBinaryStream(long pos, long length) and Clob.
getCharacterStream(long pos, long length)
Posted by "Bernt M. Johnsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12504582 ]
Bernt M. Johnsen commented on DERBY-2730:
-----------------------------------------
ClobUpdateableReader (EmbedClob clob, long pos, long len) throws an SQLException but the javadoc has @throws IOException. Same goes for UpdateableBlobStream (i missed it in the previous review).
Also: in both constructors (ClobUpdateableReader and UpdateableBlobStream), you do
SQLException sqle = new SQLException();
sqle.initCause(ioe);
throw sqle;
I.e.: an SQLException with no message and no sql state is thrown. I think it should have both.
> Implement not implemented Embedded methods Blob.getBinaryStream(long pos, long length) and Clob. getCharacterStream(long pos, long length)
> ------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: DERBY-2730
> URL: https://issues.apache.org/jira/browse/DERBY-2730
> Project: Derby
> Issue Type: New Feature
> Components: JDBC
> Affects Versions: 10.3.0.0
> Reporter: V.Narayanan
> Assignee: V.Narayanan
> Fix For: 10.3.0.0
>
> Attachments: GetBinaryStreamImpl_v1.diff, GetBinaryStreamImpl_v1.stat, GetBinaryStreamImpl_v1_NOT_FOR_COMMIT.diff, GetBinaryStreamImpl_v1_NOT_FOR_COMMIT.stat, GetBinaryStreamImpl_v2.diff, GetBinaryStreamImpl_v2.stat, GetCharacterStreamImpl_v1.diff, GetCharacterStreamImpl_v1.stat
>
>
> The following methods were introduced in the java.sql.Clob and java.sql.Blob interface as part of JDBC 4.0 and need to be implemented.
> Clob
> ------
> getCharacterStream(long pos, long length)
> Blob
> ------
> getBinaryStream(long pos, long length)
> The implementation on the Network Client is already done as part of Derby-2444
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2730) Implement not implemented Embedded
methods Blob.getBinaryStream(long pos, long length) and Clob.
getCharacterStream(long pos, long length)
Posted by "V.Narayanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12504701 ]
V.Narayanan commented on DERBY-2730:
------------------------------------
I am OK with this kristian.
> Implement not implemented Embedded methods Blob.getBinaryStream(long pos, long length) and Clob. getCharacterStream(long pos, long length)
> ------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: DERBY-2730
> URL: https://issues.apache.org/jira/browse/DERBY-2730
> Project: Derby
> Issue Type: New Feature
> Components: JDBC
> Affects Versions: 10.3.0.0
> Reporter: V.Narayanan
> Assignee: V.Narayanan
> Fix For: 10.3.0.0
>
> Attachments: GetBinaryStreamImpl_v1.diff, GetBinaryStreamImpl_v1.stat, GetBinaryStreamImpl_v1_NOT_FOR_COMMIT.diff, GetBinaryStreamImpl_v1_NOT_FOR_COMMIT.stat, GetBinaryStreamImpl_v2.diff, GetBinaryStreamImpl_v2.stat, GetCharacterStreamImpl_v1.diff, GetCharacterStreamImpl_v1.stat, GetCharacterStreamImpl_v2.diff, GetCharacterStreamImpl_v2.stat
>
>
> The following methods were introduced in the java.sql.Clob and java.sql.Blob interface as part of JDBC 4.0 and need to be implemented.
> Clob
> ------
> getCharacterStream(long pos, long length)
> Blob
> ------
> getBinaryStream(long pos, long length)
> The implementation on the Network Client is already done as part of Derby-2444
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2730) Implement not implemented Embedded
methods Blob.getBinaryStream(long pos, long length) and Clob.
getCharacterStream(long pos, long length)
Posted by "V.Narayanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12504221 ]
V.Narayanan commented on DERBY-2730:
------------------------------------
Thanks a ton for the commit Bernt !!
> Implement not implemented Embedded methods Blob.getBinaryStream(long pos, long length) and Clob. getCharacterStream(long pos, long length)
> ------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: DERBY-2730
> URL: https://issues.apache.org/jira/browse/DERBY-2730
> Project: Derby
> Issue Type: New Feature
> Components: JDBC
> Affects Versions: 10.3.0.0
> Reporter: V.Narayanan
> Assignee: V.Narayanan
> Fix For: 10.3.0.0
>
> Attachments: GetBinaryStreamImpl_v1.diff, GetBinaryStreamImpl_v1.stat, GetBinaryStreamImpl_v1_NOT_FOR_COMMIT.diff, GetBinaryStreamImpl_v1_NOT_FOR_COMMIT.stat, GetBinaryStreamImpl_v2.diff, GetBinaryStreamImpl_v2.stat
>
>
> The following methods were introduced in the java.sql.Clob and java.sql.Blob interface as part of JDBC 4.0 and need to be implemented.
> Clob
> ------
> getCharacterStream(long pos, long length)
> Blob
> ------
> getBinaryStream(long pos, long length)
> The implementation on the Network Client is already done as part of Derby-2444
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2730) Implement not implemented Embedded
methods Blob.getBinaryStream(long pos, long length) and Clob.
getCharacterStream(long pos, long length)
Posted by "Bernt M. Johnsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12500320 ]
Bernt M. Johnsen commented on DERBY-2730:
-----------------------------------------
1) Looks fair enough, although I will not consider the review done until after DERBY-2711 is committed and a clean patch submitted.
2) There's no explanation why Clob.getCharacterStream isn't a part of this patch.
> Implement not implemented Embedded methods Blob.getBinaryStream(long pos, long length) and Clob. getCharacterStream(long pos, long length)
> ------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: DERBY-2730
> URL: https://issues.apache.org/jira/browse/DERBY-2730
> Project: Derby
> Issue Type: New Feature
> Components: JDBC
> Reporter: V.Narayanan
> Assignee: V.Narayanan
> Attachments: GetBinaryStreamImpl_v1_NOT_FOR_COMMIT.diff, GetBinaryStreamImpl_v1_NOT_FOR_COMMIT.stat
>
>
> The following methods were introduced in the java.sql.Clob and java.sql.Blob interface as part of JDBC 4.0 and need to be implemented.
> Clob
> ------
> getCharacterStream(long pos, long length)
> Blob
> ------
> getBinaryStream(long pos, long length)
> The implementation on the Network Client is already done as part of Derby-2444
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2730) Implement not implemented Embedded
methods Blob.getBinaryStream(long pos, long length) and Clob.
getCharacterStream(long pos, long length)
Posted by "V.Narayanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
V.Narayanan updated DERBY-2730:
-------------------------------
Attachment: GetCharacterStreamImpl_v2.stat
GetCharacterStreamImpl_v2.diff
Thank you for the review on the patch.
I found a clue on how to handle this from already exisiting
usage of the other Updatable stream constructors.
I removed the try catch in the updatable streams and
moved them into the corresponding Lob classes where
they were being used. Here I called the Util.setStreamFailure
passing the IOException as parameter.
I ran the jdbc4/BlobTest, jdbc4/ClobTest and jdbcapi/BlobClob4BlobTest
and saw no failures.
I have started a junit All run and shall revert back with results.
> Implement not implemented Embedded methods Blob.getBinaryStream(long pos, long length) and Clob. getCharacterStream(long pos, long length)
> ------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: DERBY-2730
> URL: https://issues.apache.org/jira/browse/DERBY-2730
> Project: Derby
> Issue Type: New Feature
> Components: JDBC
> Affects Versions: 10.3.0.0
> Reporter: V.Narayanan
> Assignee: V.Narayanan
> Fix For: 10.3.0.0
>
> Attachments: GetBinaryStreamImpl_v1.diff, GetBinaryStreamImpl_v1.stat, GetBinaryStreamImpl_v1_NOT_FOR_COMMIT.diff, GetBinaryStreamImpl_v1_NOT_FOR_COMMIT.stat, GetBinaryStreamImpl_v2.diff, GetBinaryStreamImpl_v2.stat, GetCharacterStreamImpl_v1.diff, GetCharacterStreamImpl_v1.stat, GetCharacterStreamImpl_v2.diff, GetCharacterStreamImpl_v2.stat
>
>
> The following methods were introduced in the java.sql.Clob and java.sql.Blob interface as part of JDBC 4.0 and need to be implemented.
> Clob
> ------
> getCharacterStream(long pos, long length)
> Blob
> ------
> getBinaryStream(long pos, long length)
> The implementation on the Network Client is already done as part of Derby-2444
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2730) Implement not implemented Embedded
methods Blob.getBinaryStream(long pos, long length) and Clob.
getCharacterStream(long pos, long length)
Posted by "V.Narayanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12504544 ]
V.Narayanan commented on DERBY-2730:
------------------------------------
I ran junit All on this patch and found no failures.
> Implement not implemented Embedded methods Blob.getBinaryStream(long pos, long length) and Clob. getCharacterStream(long pos, long length)
> ------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: DERBY-2730
> URL: https://issues.apache.org/jira/browse/DERBY-2730
> Project: Derby
> Issue Type: New Feature
> Components: JDBC
> Affects Versions: 10.3.0.0
> Reporter: V.Narayanan
> Assignee: V.Narayanan
> Fix For: 10.3.0.0
>
> Attachments: GetBinaryStreamImpl_v1.diff, GetBinaryStreamImpl_v1.stat, GetBinaryStreamImpl_v1_NOT_FOR_COMMIT.diff, GetBinaryStreamImpl_v1_NOT_FOR_COMMIT.stat, GetBinaryStreamImpl_v2.diff, GetBinaryStreamImpl_v2.stat, GetCharacterStreamImpl_v1.diff, GetCharacterStreamImpl_v1.stat
>
>
> The following methods were introduced in the java.sql.Clob and java.sql.Blob interface as part of JDBC 4.0 and need to be implemented.
> Clob
> ------
> getCharacterStream(long pos, long length)
> Blob
> ------
> getBinaryStream(long pos, long length)
> The implementation on the Network Client is already done as part of Derby-2444
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (DERBY-2730) Implement not implemented Embedded
methods Blob.getBinaryStream(long pos, long length) and Clob.
getCharacterStream(long pos, long length)
Posted by "V.Narayanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
V.Narayanan closed DERBY-2730.
------------------------------
All patches submitted and committed. Indicated change going into another jira.
Hence dlosing this issue!
> Implement not implemented Embedded methods Blob.getBinaryStream(long pos, long length) and Clob. getCharacterStream(long pos, long length)
> ------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: DERBY-2730
> URL: https://issues.apache.org/jira/browse/DERBY-2730
> Project: Derby
> Issue Type: New Feature
> Components: JDBC
> Affects Versions: 10.3.0.0
> Reporter: V.Narayanan
> Assignee: V.Narayanan
> Fix For: 10.3.0.0
>
> Attachments: GetBinaryStreamImpl_v1.diff, GetBinaryStreamImpl_v1.stat, GetBinaryStreamImpl_v1_NOT_FOR_COMMIT.diff, GetBinaryStreamImpl_v1_NOT_FOR_COMMIT.stat, GetBinaryStreamImpl_v2.diff, GetBinaryStreamImpl_v2.stat, GetCharacterStreamImpl_v1.diff, GetCharacterStreamImpl_v1.stat, GetCharacterStreamImpl_v2.diff, GetCharacterStreamImpl_v2.stat
>
>
> The following methods were introduced in the java.sql.Clob and java.sql.Blob interface as part of JDBC 4.0 and need to be implemented.
> Clob
> ------
> getCharacterStream(long pos, long length)
> Blob
> ------
> getBinaryStream(long pos, long length)
> The implementation on the Network Client is already done as part of Derby-2444
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2730) Implement not implemented Embedded
methods Blob.getBinaryStream(long pos, long length) and Clob.
getCharacterStream(long pos, long length)
Posted by "V.Narayanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12504647 ]
V.Narayanan commented on DERBY-2730:
------------------------------------
Thank you for the commit Bernt !!
> Implement not implemented Embedded methods Blob.getBinaryStream(long pos, long length) and Clob. getCharacterStream(long pos, long length)
> ------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: DERBY-2730
> URL: https://issues.apache.org/jira/browse/DERBY-2730
> Project: Derby
> Issue Type: New Feature
> Components: JDBC
> Affects Versions: 10.3.0.0
> Reporter: V.Narayanan
> Assignee: V.Narayanan
> Fix For: 10.3.0.0
>
> Attachments: GetBinaryStreamImpl_v1.diff, GetBinaryStreamImpl_v1.stat, GetBinaryStreamImpl_v1_NOT_FOR_COMMIT.diff, GetBinaryStreamImpl_v1_NOT_FOR_COMMIT.stat, GetBinaryStreamImpl_v2.diff, GetBinaryStreamImpl_v2.stat, GetCharacterStreamImpl_v1.diff, GetCharacterStreamImpl_v1.stat, GetCharacterStreamImpl_v2.diff, GetCharacterStreamImpl_v2.stat
>
>
> The following methods were introduced in the java.sql.Clob and java.sql.Blob interface as part of JDBC 4.0 and need to be implemented.
> Clob
> ------
> getCharacterStream(long pos, long length)
> Blob
> ------
> getBinaryStream(long pos, long length)
> The implementation on the Network Client is already done as part of Derby-2444
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2730) Implement not implemented Embedded
methods Blob.getBinaryStream(long pos, long length) and Clob.
getCharacterStream(long pos, long length)
Posted by "V.Narayanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12503283 ]
V.Narayanan commented on DERBY-2730:
------------------------------------
The tests I had started on Saturday did not complete, I have started a
new test run today. The tests seemed to be
hanging and from the output of junit.textui.TestRunner I was not able to
affirm which test was hanging and also
if it was due to my change.
I will run tests again and revert back with the results today. I
Apologize for this unexpected delay.
> Implement not implemented Embedded methods Blob.getBinaryStream(long pos, long length) and Clob. getCharacterStream(long pos, long length)
> ------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: DERBY-2730
> URL: https://issues.apache.org/jira/browse/DERBY-2730
> Project: Derby
> Issue Type: New Feature
> Components: JDBC
> Affects Versions: 10.3.0.0
> Reporter: V.Narayanan
> Assignee: V.Narayanan
> Fix For: 10.3.0.0
>
> Attachments: GetBinaryStreamImpl_v1.diff, GetBinaryStreamImpl_v1.stat, GetBinaryStreamImpl_v1_NOT_FOR_COMMIT.diff, GetBinaryStreamImpl_v1_NOT_FOR_COMMIT.stat
>
>
> The following methods were introduced in the java.sql.Clob and java.sql.Blob interface as part of JDBC 4.0 and need to be implemented.
> Clob
> ------
> getCharacterStream(long pos, long length)
> Blob
> ------
> getBinaryStream(long pos, long length)
> The implementation on the Network Client is already done as part of Derby-2444
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2730) Implement not implemented Embedded
methods Blob.getBinaryStream(long pos, long length) and Clob.
getCharacterStream(long pos, long length)
Posted by "Bernt M. Johnsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12503860 ]
Bernt M. Johnsen commented on DERBY-2730:
-----------------------------------------
Awkward first sentence in javadoc for new UpdateableBlobStream constructor. The rest is ok.
> Implement not implemented Embedded methods Blob.getBinaryStream(long pos, long length) and Clob. getCharacterStream(long pos, long length)
> ------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: DERBY-2730
> URL: https://issues.apache.org/jira/browse/DERBY-2730
> Project: Derby
> Issue Type: New Feature
> Components: JDBC
> Affects Versions: 10.3.0.0
> Reporter: V.Narayanan
> Assignee: V.Narayanan
> Fix For: 10.3.0.0
>
> Attachments: GetBinaryStreamImpl_v1.diff, GetBinaryStreamImpl_v1.stat, GetBinaryStreamImpl_v1_NOT_FOR_COMMIT.diff, GetBinaryStreamImpl_v1_NOT_FOR_COMMIT.stat
>
>
> The following methods were introduced in the java.sql.Clob and java.sql.Blob interface as part of JDBC 4.0 and need to be implemented.
> Clob
> ------
> getCharacterStream(long pos, long length)
> Blob
> ------
> getBinaryStream(long pos, long length)
> The implementation on the Network Client is already done as part of Derby-2444
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (DERBY-2730) Implement not implemented Embedded
methods Blob.getBinaryStream(long pos, long length) and Clob.
getCharacterStream(long pos, long length)
Posted by "V.Narayanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
V.Narayanan reassigned DERBY-2730:
----------------------------------
Assignee: V.Narayanan
> Implement not implemented Embedded methods Blob.getBinaryStream(long pos, long length) and Clob. getCharacterStream(long pos, long length)
> ------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: DERBY-2730
> URL: https://issues.apache.org/jira/browse/DERBY-2730
> Project: Derby
> Issue Type: New Feature
> Components: JDBC
> Reporter: V.Narayanan
> Assignee: V.Narayanan
>
> The following methods were introduced in the java.sql.Clob and java.sql.Blob interface as part of JDBC 4.0 and need to be implemented.
> Clob
> ------
> getCharacterStream(long pos, long length)
> Blob
> ------
> getBinaryStream(long pos, long length)
> The implementation on the Network Client is already done as part of Derby-2444
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2730) Implement not implemented Embedded
methods Blob.getBinaryStream(long pos, long length) and Clob.
getCharacterStream(long pos, long length)
Posted by "V.Narayanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12500337 ]
V.Narayanan commented on DERBY-2730:
------------------------------------
Thanks again for the comments, I shall make the changes as soon as Derby-2711 is committed and submit the patch.
> Implement not implemented Embedded methods Blob.getBinaryStream(long pos, long length) and Clob. getCharacterStream(long pos, long length)
> ------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: DERBY-2730
> URL: https://issues.apache.org/jira/browse/DERBY-2730
> Project: Derby
> Issue Type: New Feature
> Components: JDBC
> Reporter: V.Narayanan
> Assignee: V.Narayanan
> Attachments: GetBinaryStreamImpl_v1_NOT_FOR_COMMIT.diff, GetBinaryStreamImpl_v1_NOT_FOR_COMMIT.stat
>
>
> The following methods were introduced in the java.sql.Clob and java.sql.Blob interface as part of JDBC 4.0 and need to be implemented.
> Clob
> ------
> getCharacterStream(long pos, long length)
> Blob
> ------
> getBinaryStream(long pos, long length)
> The implementation on the Network Client is already done as part of Derby-2444
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2730) Implement not implemented Embedded
methods Blob.getBinaryStream(long pos, long length) and Clob.
getCharacterStream(long pos, long length)
Posted by "V.Narayanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
V.Narayanan updated DERBY-2730:
-------------------------------
Attachment: GetCharacterStreamImpl_v1.stat
GetCharacterStreamImpl_v1.diff
Pls find the implementation of Clob.getCharacterStream(long, long). The logic
followed is very similar to the getBinaryStream(long, long) implementation.
I am running junit All on this patch and shall revert back with the test results.
> Implement not implemented Embedded methods Blob.getBinaryStream(long pos, long length) and Clob. getCharacterStream(long pos, long length)
> ------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: DERBY-2730
> URL: https://issues.apache.org/jira/browse/DERBY-2730
> Project: Derby
> Issue Type: New Feature
> Components: JDBC
> Affects Versions: 10.3.0.0
> Reporter: V.Narayanan
> Assignee: V.Narayanan
> Fix For: 10.3.0.0
>
> Attachments: GetBinaryStreamImpl_v1.diff, GetBinaryStreamImpl_v1.stat, GetBinaryStreamImpl_v1_NOT_FOR_COMMIT.diff, GetBinaryStreamImpl_v1_NOT_FOR_COMMIT.stat, GetBinaryStreamImpl_v2.diff, GetBinaryStreamImpl_v2.stat, GetCharacterStreamImpl_v1.diff, GetCharacterStreamImpl_v1.stat
>
>
> The following methods were introduced in the java.sql.Clob and java.sql.Blob interface as part of JDBC 4.0 and need to be implemented.
> Clob
> ------
> getCharacterStream(long pos, long length)
> Blob
> ------
> getBinaryStream(long pos, long length)
> The implementation on the Network Client is already done as part of Derby-2444
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2730) Implement not implemented Embedded
methods Blob.getBinaryStream(long pos, long length) and Clob.
getCharacterStream(long pos, long length)
Posted by "V.Narayanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
V.Narayanan updated DERBY-2730:
-------------------------------
Attachment: GetBinaryStreamImpl_v1_NOT_FOR_COMMIT.stat
GetBinaryStreamImpl_v1_NOT_FOR_COMMIT.diff
I have used the patch attached to the issue Derby-2711 to implement this patch. This patch
hence contains the changes introduced by Derby-2711 also.
Pls note that this patch is *not* for a commit.
M java/engine/org/apache/derby/impl/jdbc/EmbedBlob.java
Added implementation for the getBinaryStream(long position, long length) method
that wraps the stream returned from the getBinaryStream method inside the
UpdateableBlobStream, using the constructor that accepts a position
and length as parameter, to return a subset of the Blob value.
A java/engine/org/apache/derby/impl/jdbc/UpdateableBlobStream.java
Added a constructor that accepts position and length as parameter. Modified
the read methods to use the restriction on the position and length of the
stream.
M java/testing/org/apache/derbyTesting/functionTests/tests/jdbc4/BlobTest.java
A java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/BlobUpdateableStreamTest.java
M java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/_Suite.java
The other changes are related to Derby-2711
Pls consider this patch for reviews and comments
> Implement not implemented Embedded methods Blob.getBinaryStream(long pos, long length) and Clob. getCharacterStream(long pos, long length)
> ------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: DERBY-2730
> URL: https://issues.apache.org/jira/browse/DERBY-2730
> Project: Derby
> Issue Type: New Feature
> Components: JDBC
> Reporter: V.Narayanan
> Assignee: V.Narayanan
> Attachments: GetBinaryStreamImpl_v1_NOT_FOR_COMMIT.diff, GetBinaryStreamImpl_v1_NOT_FOR_COMMIT.stat
>
>
> The following methods were introduced in the java.sql.Clob and java.sql.Blob interface as part of JDBC 4.0 and need to be implemented.
> Clob
> ------
> getCharacterStream(long pos, long length)
> Blob
> ------
> getBinaryStream(long pos, long length)
> The implementation on the Network Client is already done as part of Derby-2444
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2730) Implement not implemented Embedded
methods Blob.getBinaryStream(long pos, long length) and Clob.
getCharacterStream(long pos, long length)
Posted by "V.Narayanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12503862 ]
V.Narayanan commented on DERBY-2730:
------------------------------------
I had to initialize maxPos to -1 in the constructor of UpdateableBlobStream
that does not accept length as parameter. I was planning to produce a
follow-up
just now. I will correct this issue along with the maxPos one. Thank you
for
taking a look at this.
> Implement not implemented Embedded methods Blob.getBinaryStream(long pos, long length) and Clob. getCharacterStream(long pos, long length)
> ------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: DERBY-2730
> URL: https://issues.apache.org/jira/browse/DERBY-2730
> Project: Derby
> Issue Type: New Feature
> Components: JDBC
> Affects Versions: 10.3.0.0
> Reporter: V.Narayanan
> Assignee: V.Narayanan
> Fix For: 10.3.0.0
>
> Attachments: GetBinaryStreamImpl_v1.diff, GetBinaryStreamImpl_v1.stat, GetBinaryStreamImpl_v1_NOT_FOR_COMMIT.diff, GetBinaryStreamImpl_v1_NOT_FOR_COMMIT.stat
>
>
> The following methods were introduced in the java.sql.Clob and java.sql.Blob interface as part of JDBC 4.0 and need to be implemented.
> Clob
> ------
> getCharacterStream(long pos, long length)
> Blob
> ------
> getBinaryStream(long pos, long length)
> The implementation on the Network Client is already done as part of Derby-2444
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2730) Implement not implemented Embedded
methods Blob.getBinaryStream(long pos, long length) and Clob.
getCharacterStream(long pos, long length)
Posted by "V.Narayanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
V.Narayanan updated DERBY-2730:
-------------------------------
Affects Version/s: 10.3.0.0
Fix Version/s: 10.3.0.0
> Implement not implemented Embedded methods Blob.getBinaryStream(long pos, long length) and Clob. getCharacterStream(long pos, long length)
> ------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: DERBY-2730
> URL: https://issues.apache.org/jira/browse/DERBY-2730
> Project: Derby
> Issue Type: New Feature
> Components: JDBC
> Affects Versions: 10.3.0.0
> Reporter: V.Narayanan
> Assignee: V.Narayanan
> Fix For: 10.3.0.0
>
> Attachments: GetBinaryStreamImpl_v1_NOT_FOR_COMMIT.diff, GetBinaryStreamImpl_v1_NOT_FOR_COMMIT.stat
>
>
> The following methods were introduced in the java.sql.Clob and java.sql.Blob interface as part of JDBC 4.0 and need to be implemented.
> Clob
> ------
> getCharacterStream(long pos, long length)
> Blob
> ------
> getBinaryStream(long pos, long length)
> The implementation on the Network Client is already done as part of Derby-2444
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.