[GitHub] [iceberg] rdblue commented on a diff in pull request #5084: REST: Set table format version for create table transactions

[GitBox <gi...@apache.org>]

rdblue commented on code in PR #5084:
URL: https://github.com/apache/iceberg/pull/5084#discussion_r901948667


##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -556,6 +556,8 @@ private LoadTableResponse stageCreate() {
   private static List<MetadataUpdate> createChanges(TableMetadata meta) {
     ImmutableList.Builder<MetadataUpdate> changes = ImmutableList.builder();
 
+    changes.add(new MetadataUpdate.UpgradeFormatVersion(meta.formatVersion()));

Review Comment:
   I think this should be set only if the format version is not the default?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org