You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2017/08/23 21:12:17 UTC

svn commit: r1805960 - in /tomcat/native/trunk: native/Makefile.in native/configure.in xdocs/miscellaneous/changelog.xml

Author: markt
Date: Wed Aug 23 21:12:17 2017
New Revision: 1805960

URL: http://svn.apache.org/viewvc?rev=1805960&view=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=60301
When building Tomcat Native, allow the user to override the libtool specified by APR but setting the LIBTOOL environment variable.

Modified:
    tomcat/native/trunk/native/Makefile.in
    tomcat/native/trunk/native/configure.in
    tomcat/native/trunk/xdocs/miscellaneous/changelog.xml

Modified: tomcat/native/trunk/native/Makefile.in
URL: http://svn.apache.org/viewvc/tomcat/native/trunk/native/Makefile.in?rev=1805960&r1=1805959&r2=1805960&view=diff
==============================================================================
--- tomcat/native/trunk/native/Makefile.in (original)
+++ tomcat/native/trunk/native/Makefile.in Wed Aug 23 21:12:17 2017
@@ -22,6 +22,7 @@
 CFLAGS = @CFLAGS@
 CPPFLAGS = @CPPFLAGS@
 CC_OLD = @CC@
+LIBTOOL_OLD = @LIBTOOL@
 
 # gets substituted into some targets
 TCNATIVE_MAJOR_VERSION=@TCNATIVE_MAJOR_VERSION@
@@ -52,6 +53,10 @@ ifneq ($(CC_OLD),$(CC))
     CC=$(CC_OLD)
 endif
 
+ifneq ($(LIBTOOL_OLD),$(LIBTOOL))
+    LIBTOOL=$(LIBTOOL_OLD)
+endif
+
 LINK          = $(LIBTOOL) $(LTFLAGS) --mode=link $(LT_LDFLAGS) $(COMPILE) -version-info $(TCNATIVE_LIBTOOL_VERSION) $(ALL_LDFLAGS) -o $@
 CLEAN_SUBDIRS = test
 

Modified: tomcat/native/trunk/native/configure.in
URL: http://svn.apache.org/viewvc/tomcat/native/trunk/native/configure.in?rev=1805960&r1=1805959&r2=1805960&view=diff
==============================================================================
--- tomcat/native/trunk/native/configure.in (original)
+++ tomcat/native/trunk/native/configure.in Wed Aug 23 21:12:17 2017
@@ -101,6 +101,11 @@ dnl
 APR_SETIFNULL(CC, `$apr_config --cc`)
 APR_SETIFNULL(CPP, `$apr_config --cpp`)
 
+dnl
+dnl Default to the APR provided libtool but allow the user to override it
+dnl
+APR_SETIFNULL(LIBTOOL, `$apr_config --apr-libtool`)
+
 AC_PROG_INSTALL
 
 dnl
@@ -234,6 +239,7 @@ AC_SUBST(TCNATIVE_LDFLAGS)
 AC_SUBST(TCNATIVE_LIBS)
 AC_SUBST(CFLAGS)
 AC_SUBST(CPPFLAGS)
+AC_SUBST(LIBTOOL)
 
 dnl copy apr's rules.mk into our build directory.
 if test ! -d ./build; then

Modified: tomcat/native/trunk/xdocs/miscellaneous/changelog.xml
URL: http://svn.apache.org/viewvc/tomcat/native/trunk/xdocs/miscellaneous/changelog.xml?rev=1805960&r1=1805959&r2=1805960&view=diff
==============================================================================
--- tomcat/native/trunk/xdocs/miscellaneous/changelog.xml (original)
+++ tomcat/native/trunk/xdocs/miscellaneous/changelog.xml Wed Aug 23 21:12:17 2017
@@ -66,6 +66,11 @@
       <code>CC</code> if explicitly set. Patch provided by Michael Osipov.
       (markt)
     </fix>
+    <fix>
+      <bug>60301</bug>: When building Tomcat Native, allow the user to override
+      the libtool specified by APR but setting the <code>LIBTOOL</code>
+      environment variable. (markt)
+    </fix>
   </changelog>
 </section>
 <section name="Changes in 1.2.12">



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: svn commit: r1805960 - in /tomcat/native/trunk: native/Makefile.in native/configure.in xdocs/miscellaneous/changelog.xml

Posted by Rainer Jung <ra...@kippdata.de>.
Some more answers

Am 24.08.2017 um 12:19 schrieb Konstantin Kolinko:
> A naive review below. I do not have a working tc-native build to check.
>
> I think your patch is an adaptation of r1805943 (BZ 60290). As such,
> it looks good.
>
> Several thoughts:
> 1) A typo in commit message and in changelog.xml
>
> I think it was meant to be  s/but setting/by setting/.

Fixed by Mark.

> 2) There exists @TCNATIVE_LIBTOOL_VERSION@   What is its value?
>
> Looking into configure.in, I think it is evaluated rather early,
> before $LIBTOOL is set.

That is the tcnative version in libtool syntax, not a libtool version. 
For instance for trunk it is 2:13:2 which leads to 
libtcnative-1.so.0.2.13. The determination of that version does not use 
libtool but instead a script build/get-version.sh which parses the 
version info from one of our header files.

> 3)
>>> APR_SETIFNULL(LIBTOOL, `$apr_config --apr-libtool`)
>
> I wonder whether that --apr-libtool flag should be simply --libtool,
> like with --cc and -cpp a few lines above.

Already answered

> 4)
> There exists $APR_LIBTOOL_LIBS.
> I wonder what is its value and whether it needs some update as well.

These are libs needed when linking against APR retrieved from the 
apr-1-config script of the installed APR. They are not libs needed by 
libtool itself and do not depend on the libtool version, neither of the 
one included in APR nor on a separate one if we now use the new feature.

Example here on Solaris:

/path/to/lib/libapr-1.la -luuid -lsendfile -lrt -lsocket -lnsl  -lpthread

So no need to update.

@Mark: I tested it quickly using the APR provided libtool and then 
another build using an older libtool announced via the LIBTOOL env var. 
Both build used the expected libtool and were successful.

Regards,

Rainer

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: svn commit: r1805960 - in /tomcat/native/trunk: native/Makefile.in native/configure.in xdocs/miscellaneous/changelog.xml

Posted by Konstantin Kolinko <kn...@gmail.com>.
2017-08-24 21:33 GMT+03:00 Mark Thomas <ma...@apache.org>:
> On 24/08/17 11:19, Konstantin Kolinko wrote:
>> A naive review below. I do not have a working tc-native build to check.
>>
>> I think your patch is an adaptation of r1805943 (BZ 60290). As such,
>> it looks good.
>>
>> Several thoughts:
>> 1) A typo in commit message and in changelog.xml>
>> I think it was meant to be  s/but setting/by setting/.
>
> Thanks. Fixed.
>
> I think Rainer has answered the libtool questions.

Ack. Good answers. Thank you both.


Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: svn commit: r1805960 - in /tomcat/native/trunk: native/Makefile.in native/configure.in xdocs/miscellaneous/changelog.xml

Posted by Mark Thomas <ma...@apache.org>.
On 24/08/17 11:19, Konstantin Kolinko wrote:
> A naive review below. I do not have a working tc-native build to check.
> 
> I think your patch is an adaptation of r1805943 (BZ 60290). As such,
> it looks good.
> 
> Several thoughts:
> 1) A typo in commit message and in changelog.xml>
> I think it was meant to be  s/but setting/by setting/.

Thanks. Fixed.

I think Rainer has answered the libtool questions.

Mark


> 
> 2) There exists @TCNATIVE_LIBTOOL_VERSION@   What is its value?
> 
> Looking into configure.in, I think it is evaluated rather early,
> before $LIBTOOL is set.
> 
> 
> 3)
>>> APR_SETIFNULL(LIBTOOL, `$apr_config --apr-libtool`)
> 
> I wonder whether that --apr-libtool flag should be simply --libtool,
> like with --cc and -cpp a few lines above.
> 
> 4)
> There exists $APR_LIBTOOL_LIBS.
> I wonder what is its value and whether it needs some update as well.
> 
> 
> 2017-08-24 0:12 GMT+03:00  <ma...@apache.org>:
>> Author: markt
>> Date: Wed Aug 23 21:12:17 2017
>> New Revision: 1805960
>>
>> URL: http://svn.apache.org/viewvc?rev=1805960&view=rev
>> Log:
>> Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=60301
>> When building Tomcat Native, allow the user to override the libtool specified by APR but setting the LIBTOOL environment variable.
>>
>> Modified:
>>     tomcat/native/trunk/native/Makefile.in
>>     tomcat/native/trunk/native/configure.in
>>     tomcat/native/trunk/xdocs/miscellaneous/changelog.xml
>>
>> Modified: tomcat/native/trunk/native/Makefile.in
>> URL: http://svn.apache.org/viewvc/tomcat/native/trunk/native/Makefile.in?rev=1805960&r1=1805959&r2=1805960&view=diff
>> ==============================================================================
>> --- tomcat/native/trunk/native/Makefile.in (original)
>> +++ tomcat/native/trunk/native/Makefile.in Wed Aug 23 21:12:17 2017
>> @@ -22,6 +22,7 @@
>>  CFLAGS = @CFLAGS@
>>  CPPFLAGS = @CPPFLAGS@
>>  CC_OLD = @CC@
>> +LIBTOOL_OLD = @LIBTOOL@
>>
>>  # gets substituted into some targets
>>  TCNATIVE_MAJOR_VERSION=@TCNATIVE_MAJOR_VERSION@
>> @@ -52,6 +53,10 @@ ifneq ($(CC_OLD),$(CC))
>>      CC=$(CC_OLD)
>>  endif
>>
>> +ifneq ($(LIBTOOL_OLD),$(LIBTOOL))
>> +    LIBTOOL=$(LIBTOOL_OLD)
>> +endif
>> +
>>  LINK          = $(LIBTOOL) $(LTFLAGS) --mode=link $(LT_LDFLAGS) $(COMPILE) -version-info $(TCNATIVE_LIBTOOL_VERSION) $(ALL_LDFLAGS) -o $@
>>  CLEAN_SUBDIRS = test
>>
>>
>> Modified: tomcat/native/trunk/native/configure.in
>> URL: http://svn.apache.org/viewvc/tomcat/native/trunk/native/configure.in?rev=1805960&r1=1805959&r2=1805960&view=diff
>> ==============================================================================
>> --- tomcat/native/trunk/native/configure.in (original)
>> +++ tomcat/native/trunk/native/configure.in Wed Aug 23 21:12:17 2017
>> @@ -101,6 +101,11 @@ dnl
>>  APR_SETIFNULL(CC, `$apr_config --cc`)
>>  APR_SETIFNULL(CPP, `$apr_config --cpp`)
>>
>> +dnl
>> +dnl Default to the APR provided libtool but allow the user to override it
>> +dnl
>> +APR_SETIFNULL(LIBTOOL, `$apr_config --apr-libtool`)
>> +
>>  AC_PROG_INSTALL
>>
>>  dnl
>> @@ -234,6 +239,7 @@ AC_SUBST(TCNATIVE_LDFLAGS)
>>  AC_SUBST(TCNATIVE_LIBS)
>>  AC_SUBST(CFLAGS)
>>  AC_SUBST(CPPFLAGS)
>> +AC_SUBST(LIBTOOL)
>>
>>  dnl copy apr's rules.mk into our build directory.
>>  if test ! -d ./build; then
>>
>> Modified: tomcat/native/trunk/xdocs/miscellaneous/changelog.xml
>> URL: http://svn.apache.org/viewvc/tomcat/native/trunk/xdocs/miscellaneous/changelog.xml?rev=1805960&r1=1805959&r2=1805960&view=diff
>> ==============================================================================
>> --- tomcat/native/trunk/xdocs/miscellaneous/changelog.xml (original)
>> +++ tomcat/native/trunk/xdocs/miscellaneous/changelog.xml Wed Aug 23 21:12:17 2017
>> @@ -66,6 +66,11 @@
>>        <code>CC</code> if explicitly set. Patch provided by Michael Osipov.
>>        (markt)
>>      </fix>
>> +    <fix>
>> +      <bug>60301</bug>: When building Tomcat Native, allow the user to override
>> +      the libtool specified by APR but setting the <code>LIBTOOL</code>
>> +      environment variable. (markt)
>> +    </fix>
>>    </changelog>
>>  </section>
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: svn commit: r1805960 - in /tomcat/native/trunk: native/Makefile.in native/configure.in xdocs/miscellaneous/changelog.xml

Posted by Rainer Jung <ra...@kippdata.de>.
Am 24.08.2017 um 12:19 schrieb Konstantin Kolinko:
> 3)
>>> APR_SETIFNULL(LIBTOOL, `$apr_config --apr-libtool`)
>
> I wonder whether that --apr-libtool flag should be simply --libtool,
> like with --cc and -cpp a few lines above.

--apr-libtool is correct. The APR config tool, named apr-config for APR 
0.x.y and apr-1-config for 1.x.y only supports that flag, not the 
shorter --libtool. It is not a flag that we have created. For cc and cpp 
they use a shorter flag, so that parts looks good.

Here's the usage, in this case taken from APR 1.6.2:

   --prefix[=DIR]    change prefix to DIR
   --bindir          print location where binaries are installed
   --includedir      print location where headers are installed
   --cc              print C compiler name
^^^^^^
   --cpp             print C preprocessor name and any required options
^^^^^^^
   --cflags          print C compiler flags
   --cppflags        print C preprocessor flags
   --includes        print include information
   --ldflags         print linker flags
   --libs            print additional libraries to link against
   --srcdir          print APR source directory
   --installbuilddir print APR build helper directory
   --link-ld         print link switch(es) for linking to APR
   --link-libtool    print the libtool inputs for linking to APR
   --shlib-path-var  print the name of the shared library path env var
   --apr-la-file     print the path to the .la file, if available
   --apr-so-ext      print the extensions of shared objects on this platform
   --apr-lib-target  print the libtool target information
   --apr-libtool     print the path to APR's libtool
   ^^^^^^^^^^^^^
   --version         print the APR's version as a dotted triple
   --help            print this help


Regards,

Rainer


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: svn commit: r1805960 - in /tomcat/native/trunk: native/Makefile.in native/configure.in xdocs/miscellaneous/changelog.xml

Posted by Konstantin Kolinko <kn...@gmail.com>.
A naive review below. I do not have a working tc-native build to check.

I think your patch is an adaptation of r1805943 (BZ 60290). As such,
it looks good.

Several thoughts:
1) A typo in commit message and in changelog.xml

I think it was meant to be  s/but setting/by setting/.

2) There exists @TCNATIVE_LIBTOOL_VERSION@   What is its value?

Looking into configure.in, I think it is evaluated rather early,
before $LIBTOOL is set.


3)
>> APR_SETIFNULL(LIBTOOL, `$apr_config --apr-libtool`)

I wonder whether that --apr-libtool flag should be simply --libtool,
like with --cc and -cpp a few lines above.

4)
There exists $APR_LIBTOOL_LIBS.
I wonder what is its value and whether it needs some update as well.


2017-08-24 0:12 GMT+03:00  <ma...@apache.org>:
> Author: markt
> Date: Wed Aug 23 21:12:17 2017
> New Revision: 1805960
>
> URL: http://svn.apache.org/viewvc?rev=1805960&view=rev
> Log:
> Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=60301
> When building Tomcat Native, allow the user to override the libtool specified by APR but setting the LIBTOOL environment variable.
>
> Modified:
>     tomcat/native/trunk/native/Makefile.in
>     tomcat/native/trunk/native/configure.in
>     tomcat/native/trunk/xdocs/miscellaneous/changelog.xml
>
> Modified: tomcat/native/trunk/native/Makefile.in
> URL: http://svn.apache.org/viewvc/tomcat/native/trunk/native/Makefile.in?rev=1805960&r1=1805959&r2=1805960&view=diff
> ==============================================================================
> --- tomcat/native/trunk/native/Makefile.in (original)
> +++ tomcat/native/trunk/native/Makefile.in Wed Aug 23 21:12:17 2017
> @@ -22,6 +22,7 @@
>  CFLAGS = @CFLAGS@
>  CPPFLAGS = @CPPFLAGS@
>  CC_OLD = @CC@
> +LIBTOOL_OLD = @LIBTOOL@
>
>  # gets substituted into some targets
>  TCNATIVE_MAJOR_VERSION=@TCNATIVE_MAJOR_VERSION@
> @@ -52,6 +53,10 @@ ifneq ($(CC_OLD),$(CC))
>      CC=$(CC_OLD)
>  endif
>
> +ifneq ($(LIBTOOL_OLD),$(LIBTOOL))
> +    LIBTOOL=$(LIBTOOL_OLD)
> +endif
> +
>  LINK          = $(LIBTOOL) $(LTFLAGS) --mode=link $(LT_LDFLAGS) $(COMPILE) -version-info $(TCNATIVE_LIBTOOL_VERSION) $(ALL_LDFLAGS) -o $@
>  CLEAN_SUBDIRS = test
>
>
> Modified: tomcat/native/trunk/native/configure.in
> URL: http://svn.apache.org/viewvc/tomcat/native/trunk/native/configure.in?rev=1805960&r1=1805959&r2=1805960&view=diff
> ==============================================================================
> --- tomcat/native/trunk/native/configure.in (original)
> +++ tomcat/native/trunk/native/configure.in Wed Aug 23 21:12:17 2017
> @@ -101,6 +101,11 @@ dnl
>  APR_SETIFNULL(CC, `$apr_config --cc`)
>  APR_SETIFNULL(CPP, `$apr_config --cpp`)
>
> +dnl
> +dnl Default to the APR provided libtool but allow the user to override it
> +dnl
> +APR_SETIFNULL(LIBTOOL, `$apr_config --apr-libtool`)
> +
>  AC_PROG_INSTALL
>
>  dnl
> @@ -234,6 +239,7 @@ AC_SUBST(TCNATIVE_LDFLAGS)
>  AC_SUBST(TCNATIVE_LIBS)
>  AC_SUBST(CFLAGS)
>  AC_SUBST(CPPFLAGS)
> +AC_SUBST(LIBTOOL)
>
>  dnl copy apr's rules.mk into our build directory.
>  if test ! -d ./build; then
>
> Modified: tomcat/native/trunk/xdocs/miscellaneous/changelog.xml
> URL: http://svn.apache.org/viewvc/tomcat/native/trunk/xdocs/miscellaneous/changelog.xml?rev=1805960&r1=1805959&r2=1805960&view=diff
> ==============================================================================
> --- tomcat/native/trunk/xdocs/miscellaneous/changelog.xml (original)
> +++ tomcat/native/trunk/xdocs/miscellaneous/changelog.xml Wed Aug 23 21:12:17 2017
> @@ -66,6 +66,11 @@
>        <code>CC</code> if explicitly set. Patch provided by Michael Osipov.
>        (markt)
>      </fix>
> +    <fix>
> +      <bug>60301</bug>: When building Tomcat Native, allow the user to override
> +      the libtool specified by APR but setting the <code>LIBTOOL</code>
> +      environment variable. (markt)
> +    </fix>
>    </changelog>
>  </section>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: svn commit: r1805960 - in /tomcat/native/trunk: native/Makefile.in native/configure.in xdocs/miscellaneous/changelog.xml

Posted by Mark Thomas <ma...@apache.org>.
On 23/08/17 22:12, markt@apache.org wrote:
> Author: markt
> Date: Wed Aug 23 21:12:17 2017
> New Revision: 1805960
> 
> URL: http://svn.apache.org/viewvc?rev=1805960&view=rev
> Log:
> Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=60301
> When building Tomcat Native, allow the user to override the libtool specified by APR but setting the LIBTOOL environment variable.

C gurus,

I'm not sure that I have done this the right / proper / best way. Review
and feedback appreciated.

Assuming all is well, I hope to tag Tomcat Native tomorrow. I do just
want to run through the open bugs that refer to crashes first.

Mark


> 
> Modified:
>     tomcat/native/trunk/native/Makefile.in
>     tomcat/native/trunk/native/configure.in
>     tomcat/native/trunk/xdocs/miscellaneous/changelog.xml
> 
> Modified: tomcat/native/trunk/native/Makefile.in
> URL: http://svn.apache.org/viewvc/tomcat/native/trunk/native/Makefile.in?rev=1805960&r1=1805959&r2=1805960&view=diff
> ==============================================================================
> --- tomcat/native/trunk/native/Makefile.in (original)
> +++ tomcat/native/trunk/native/Makefile.in Wed Aug 23 21:12:17 2017
> @@ -22,6 +22,7 @@
>  CFLAGS = @CFLAGS@
>  CPPFLAGS = @CPPFLAGS@
>  CC_OLD = @CC@
> +LIBTOOL_OLD = @LIBTOOL@
>  
>  # gets substituted into some targets
>  TCNATIVE_MAJOR_VERSION=@TCNATIVE_MAJOR_VERSION@
> @@ -52,6 +53,10 @@ ifneq ($(CC_OLD),$(CC))
>      CC=$(CC_OLD)
>  endif
>  
> +ifneq ($(LIBTOOL_OLD),$(LIBTOOL))
> +    LIBTOOL=$(LIBTOOL_OLD)
> +endif
> +
>  LINK          = $(LIBTOOL) $(LTFLAGS) --mode=link $(LT_LDFLAGS) $(COMPILE) -version-info $(TCNATIVE_LIBTOOL_VERSION) $(ALL_LDFLAGS) -o $@
>  CLEAN_SUBDIRS = test
>  
> 
> Modified: tomcat/native/trunk/native/configure.in
> URL: http://svn.apache.org/viewvc/tomcat/native/trunk/native/configure.in?rev=1805960&r1=1805959&r2=1805960&view=diff
> ==============================================================================
> --- tomcat/native/trunk/native/configure.in (original)
> +++ tomcat/native/trunk/native/configure.in Wed Aug 23 21:12:17 2017
> @@ -101,6 +101,11 @@ dnl
>  APR_SETIFNULL(CC, `$apr_config --cc`)
>  APR_SETIFNULL(CPP, `$apr_config --cpp`)
>  
> +dnl
> +dnl Default to the APR provided libtool but allow the user to override it
> +dnl
> +APR_SETIFNULL(LIBTOOL, `$apr_config --apr-libtool`)
> +
>  AC_PROG_INSTALL
>  
>  dnl
> @@ -234,6 +239,7 @@ AC_SUBST(TCNATIVE_LDFLAGS)
>  AC_SUBST(TCNATIVE_LIBS)
>  AC_SUBST(CFLAGS)
>  AC_SUBST(CPPFLAGS)
> +AC_SUBST(LIBTOOL)
>  
>  dnl copy apr's rules.mk into our build directory.
>  if test ! -d ./build; then
> 
> Modified: tomcat/native/trunk/xdocs/miscellaneous/changelog.xml
> URL: http://svn.apache.org/viewvc/tomcat/native/trunk/xdocs/miscellaneous/changelog.xml?rev=1805960&r1=1805959&r2=1805960&view=diff
> ==============================================================================
> --- tomcat/native/trunk/xdocs/miscellaneous/changelog.xml (original)
> +++ tomcat/native/trunk/xdocs/miscellaneous/changelog.xml Wed Aug 23 21:12:17 2017
> @@ -66,6 +66,11 @@
>        <code>CC</code> if explicitly set. Patch provided by Michael Osipov.
>        (markt)
>      </fix>
> +    <fix>
> +      <bug>60301</bug>: When building Tomcat Native, allow the user to override
> +      the libtool specified by APR but setting the <code>LIBTOOL</code>
> +      environment variable. (markt)
> +    </fix>
>    </changelog>
>  </section>
>  <section name="Changes in 1.2.12">
> 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org