[GitHub] orc pull request #229: ORC-313: Check subtype count of LIST, MAP and UNION t...

[stiga-huang <gi...@git.apache.org>]

GitHub user stiga-huang opened a pull request:

    https://github.com/apache/orc/pull/229

    ORC-313: Check subtype count of LIST, MAP and UNION types

    We need to verify the subtype count of LIST, MAP and UNION types. Otherwise, the ill types will lead the c++ reader to crash. The java reader also has this problem.
    
    Files attached to the JIRA can reproduce the crash.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/stiga-huang/orc check-subtype-cnt

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/orc/pull/229.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #229
    
----
commit 8661fc43ef76030cfb5d67844a7e6a3c26167cda
Author: stiga-huang <hu...@...>
Date:   2018-03-03T09:21:23Z

    ORC-313: Check subtype count in converting protobuf Types
    
    We need to verify the subtype count of LIST, MAP and UNION types.
    Otherwise, the ill types will lead the c++ reader to crash.
    
    The java reader also has this problem.

commit 023f124550fc843d0d1aa0fe4d5c9e27e4d3bea9
Author: stiga-huang <hu...@...>
Date:   2018-03-12T12:57:38Z

    add unit tests

----


---

[GitHub] orc pull request #229: ORC-313: Check subtype count of LIST, MAP and UNION t...

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/orc/pull/229


---

[GitHub] orc issue #229: ORC-313: Check subtype count of LIST, MAP and UNION types

[stiga-huang <gi...@git.apache.org>]

Github user stiga-huang commented on the issue:

    https://github.com/apache/orc/pull/229
  
    @omalley @majetideepak could you have a look at these? We need this bug be fixed to integrate the c++ library into Impala (ORC-315).


---