You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/03/03 04:54:21 UTC

[GitHub] eric-haibin-lin commented on a change in pull request #14302: fix SoftmaxOutput resource bug

eric-haibin-lin commented on a change in pull request #14302: fix SoftmaxOutput resource bug
URL: https://github.com/apache/incubator-mxnet/pull/14302#discussion_r261851559
 
 

 ##########
 File path: tests/python/unittest/test_operator.py
 ##########
 @@ -6496,6 +6496,75 @@ def test_softmax():
     check_smoothed_softmax_grad(default_context())
 
 
+@with_seed()
+def test_SoftmaxOutput_normalization():
 
 Review comment:
   Thanks for the quick fix! 
   nit: could you change `test_SoftmaxOutput_normalization` to `test_softmax_output_normalization `? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services