You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/04 07:47:33 UTC

[GitHub] [flink] docete opened a new pull request #10415: [FLINK-15049][table-planner-blink] Compile error when hash join with …

docete opened a new pull request #10415: [FLINK-15049][table-planner-blink] Compile error when hash join with …
URL: https://github.com/apache/flink/pull/10415
 
 
   …timestamp type key
   
   
   ## What is the purpose of the change
   
   LongHashJoinGenerator should convert SqlTimestamp to long by genGetLongKey when precision of TimestampType is less than  or equals to 3.
   
   ## Brief change log
   
   - Convert SqlTimestamp to long in genGetLongKey when precision of Timestamp <= 3
   - Add JoinOn Timestmap(3) case to verify
   
   ## Verifying this change
   
   This change is already covered by tests, such as *(TimestampITCase)*.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (**yes** / no)
     - If yes, how is the feature documented? (not applicable / docs / **JavaDocs** / not documented)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services