You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2025/04/07 20:53:43 UTC
[kudu-CR](branch-1.18.x) [master] fix result status handling
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22759
Change subject: [master] fix result status handling
......................................................................
[master] fix result status handling
This patch addresses sloppy result handling of functions/methods
that return Status under the src/kudu/master directory.
Change-Id: Id6c165b6db7ddfb8a838d5c92a029349a6bb21be
Reviewed-on: http://gerrit.cloudera.org:8080/22717
Tested-by: Kudu Jenkins
Reviewed-by: Zoltan Chovan <zc...@cloudera.com>
Reviewed-by: Marton Greber <gr...@gmail.com>
(cherry picked from commit 97df171f849a10ecbc3613962440f5d84b18314a)
---
M src/kudu/master/auto_leader_rebalancer-test.cc
M src/kudu/master/auto_leader_rebalancer.cc
M src/kudu/master/auto_rebalancer.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/master/master-test.cc
M src/kudu/master/sys_catalog-test.cc
6 files changed, 45 insertions(+), 39 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/59/22759/1
--
To view, visit http://gerrit.cloudera.org:8080/22759
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id6c165b6db7ddfb8a838d5c92a029349a6bb21be
Gerrit-Change-Number: 22759
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR](branch-1.18.x) [master] fix result status handling
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/22759 )
Change subject: [master] fix result status handling
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/22759
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Id6c165b6db7ddfb8a838d5c92a029349a6bb21be
Gerrit-Change-Number: 22759
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Tue, 08 Apr 2025 18:35:19 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.18.x) [master] fix result status handling
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22759 )
Change subject: [master] fix result status handling
......................................................................
Patch Set 1: Verified+1
unrelated failures of known flaky tests in RELEASE build
--
To view, visit http://gerrit.cloudera.org:8080/22759
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Id6c165b6db7ddfb8a838d5c92a029349a6bb21be
Gerrit-Change-Number: 22759
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Tue, 08 Apr 2025 19:25:06 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.18.x) [master] fix result status handling
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22759 )
Change subject: [master] fix result status handling
......................................................................
Patch Set 1:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1267/
--
To view, visit http://gerrit.cloudera.org:8080/22759
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Id6c165b6db7ddfb8a838d5c92a029349a6bb21be
Gerrit-Change-Number: 22759
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Mon, 07 Apr 2025 20:53:53 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.18.x) [master] fix result status handling
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22759 )
Change subject: [master] fix result status handling
......................................................................
Patch Set 1: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1267/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/22759
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Id6c165b6db7ddfb8a838d5c92a029349a6bb21be
Gerrit-Change-Number: 22759
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Tue, 08 Apr 2025 03:30:26 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.18.x) [master] fix result status handling
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22759 )
Change subject: [master] fix result status handling
......................................................................
[master] fix result status handling
This patch addresses sloppy result handling of functions/methods
that return Status under the src/kudu/master directory.
Change-Id: Id6c165b6db7ddfb8a838d5c92a029349a6bb21be
Reviewed-on: http://gerrit.cloudera.org:8080/22717
Tested-by: Kudu Jenkins
Reviewed-by: Zoltan Chovan <zc...@cloudera.com>
Reviewed-by: Marton Greber <gr...@gmail.com>
(cherry picked from commit 97df171f849a10ecbc3613962440f5d84b18314a)
Reviewed-on: http://gerrit.cloudera.org:8080/22759
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
Tested-by: Alexey Serbin <al...@apache.org>
---
M src/kudu/master/auto_leader_rebalancer-test.cc
M src/kudu/master/auto_leader_rebalancer.cc
M src/kudu/master/auto_rebalancer.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/master/master-test.cc
M src/kudu/master/sys_catalog-test.cc
6 files changed, 45 insertions(+), 39 deletions(-)
Approvals:
Abhishek Chennaka: Looks good to me, approved
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/22759
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: merged
Gerrit-Change-Id: Id6c165b6db7ddfb8a838d5c92a029349a6bb21be
Gerrit-Change-Number: 22759
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
[kudu-CR](branch-1.18.x) [master] fix result status handling
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [master] fix result status handling
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/22759
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Id6c165b6db7ddfb8a838d5c92a029349a6bb21be
Gerrit-Change-Number: 22759
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>