You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Ryan King (JIRA)" <ji...@apache.org> on 2010/02/16 21:43:28 UTC

[jira] Created: (CASSANDRA-801) The Key Cache should be configurable by absolute numbers

The Key Cache should be configurable by absolute numbers
--------------------------------------------------------

                 Key: CASSANDRA-801
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-801
             Project: Cassandra
          Issue Type: Improvement
          Components: Core
    Affects Versions: 0.5, 0.6, 0.7
            Reporter: Ryan King


Just like the row cache, the key cache should be configurable by absolute numbers (not just a fraction). It would be nice to configure it by either memory size or entries (like the row cache).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-801) The Key Cache should be configurable by absolute numbers

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-801:
-------------------------------------

    Attachment:     (was: trunk-0003-Stop-aggregating-individual-key-caches-into-one.patch)

> The Key Cache should be configurable by absolute numbers
> --------------------------------------------------------
>
>                 Key: CASSANDRA-801
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-801
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.6
>            Reporter: Ryan King
>            Assignee: Stu Hood
>             Fix For: 0.6, 0.7
>
>
> Just like the row cache, the key cache should be configurable by absolute numbers (not just a fraction). It would be nice to configure it by either memory size or entries (like the row cache).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-801) The Key Cache should be configurable by absolute numbers

Posted by "Ryan King (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12834478#action_12834478 ] 

Ryan King commented on CASSANDRA-801:
-------------------------------------

We should do whatever the row cache does.

> The Key Cache should be configurable by absolute numbers
> --------------------------------------------------------
>
>                 Key: CASSANDRA-801
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-801
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.5, 0.6, 0.7
>            Reporter: Ryan King
>            Assignee: Stu Hood
>
> Just like the row cache, the key cache should be configurable by absolute numbers (not just a fraction). It would be nice to configure it by either memory size or entries (like the row cache).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-801) The Key Cache should be configurable by absolute numbers

Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stu Hood updated CASSANDRA-801:
-------------------------------

    Attachment: 0003-Sane-defaults.patch

One more patch to change the default key and row cache counts to 10,000 and 1,000 respectively.

> The Key Cache should be configurable by absolute numbers
> --------------------------------------------------------
>
>                 Key: CASSANDRA-801
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-801
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.5, 0.6, 0.7
>            Reporter: Ryan King
>            Assignee: Stu Hood
>             Fix For: 0.6, 0.7
>
>         Attachments: 0001-Convert-KeysCachedFraction-to-KeysCached.patch, 0002-Update-config-values.patch, 0003-Sane-defaults.patch
>
>
> Just like the row cache, the key cache should be configurable by absolute numbers (not just a fraction). It would be nice to configure it by either memory size or entries (like the row cache).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-801) The Key Cache should be configurable by absolute numbers

Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12834457#action_12834457 ] 

Stu Hood commented on CASSANDRA-801:
------------------------------------

Should we deprecate the ability to set these caches using fractions/percentages, and go with fixed values, which can either be absolute memory usage or absolute row/key count?

> The Key Cache should be configurable by absolute numbers
> --------------------------------------------------------
>
>                 Key: CASSANDRA-801
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-801
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.5, 0.6, 0.7
>            Reporter: Ryan King
>            Assignee: Stu Hood
>
> Just like the row cache, the key cache should be configurable by absolute numbers (not just a fraction). It would be nice to configure it by either memory size or entries (like the row cache).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-801) The Key Cache should be configurable by absolute numbers

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12835116#action_12835116 ] 

Jonathan Ellis commented on CASSANDRA-801:
------------------------------------------

I don't think it's too late until we do an RC.

> The Key Cache should be configurable by absolute numbers
> --------------------------------------------------------
>
>                 Key: CASSANDRA-801
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-801
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.5, 0.6, 0.7
>            Reporter: Ryan King
>            Assignee: Stu Hood
>             Fix For: 0.6, 0.7
>
>         Attachments: 0001-Convert-KeysCachedFraction-to-KeysCached.patch, 0002-Update-config-values.patch, 0003-Sane-defaults.patch
>
>
> Just like the row cache, the key cache should be configurable by absolute numbers (not just a fraction). It would be nice to configure it by either memory size or entries (like the row cache).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (CASSANDRA-801) The Key Cache should be configurable by absolute numbers

Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stu Hood reassigned CASSANDRA-801:
----------------------------------

    Assignee: Stu Hood

> The Key Cache should be configurable by absolute numbers
> --------------------------------------------------------
>
>                 Key: CASSANDRA-801
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-801
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.5, 0.6, 0.7
>            Reporter: Ryan King
>            Assignee: Stu Hood
>
> Just like the row cache, the key cache should be configurable by absolute numbers (not just a fraction). It would be nice to configure it by either memory size or entries (like the row cache).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-801) The Key Cache should be configurable by absolute numbers

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12834599#action_12834599 ] 

Jonathan Ellis commented on CASSANDRA-801:
------------------------------------------

should we change the default to be 10% keyscached?  imo we were too conservative w/ 1%.

> The Key Cache should be configurable by absolute numbers
> --------------------------------------------------------
>
>                 Key: CASSANDRA-801
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-801
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.5, 0.6, 0.7
>            Reporter: Ryan King
>            Assignee: Stu Hood
>             Fix For: 0.6, 0.7
>
>         Attachments: 0001-Convert-KeysCachedFraction-to-KeysCached.patch, 0002-Update-config-values.patch
>
>
> Just like the row cache, the key cache should be configurable by absolute numbers (not just a fraction). It would be nice to configure it by either memory size or entries (like the row cache).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-801) The Key Cache should be configurable by absolute numbers

Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12834619#action_12834619 ] 

Stu Hood commented on CASSANDRA-801:
------------------------------------

> should we change the default to be 10% keyscached? imo we were too conservative w/ 1%.
Oops... accidentally made the default 0 with this patch.

That would put the practical limits of a table at 60 millionish? Perhaps we should fix at 10,000 keys or something?


> The Key Cache should be configurable by absolute numbers
> --------------------------------------------------------
>
>                 Key: CASSANDRA-801
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-801
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.5, 0.6, 0.7
>            Reporter: Ryan King
>            Assignee: Stu Hood
>             Fix For: 0.6, 0.7
>
>         Attachments: 0001-Convert-KeysCachedFraction-to-KeysCached.patch, 0002-Update-config-values.patch
>
>
> Just like the row cache, the key cache should be configurable by absolute numbers (not just a fraction). It would be nice to configure it by either memory size or entries (like the row cache).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-801) The Key Cache should be configurable by absolute numbers

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-801:
-------------------------------------

    Attachment:     (was: trunk-0005-SSTableTracker-sets-the-cache-for-tracked-Readers.patch)

> The Key Cache should be configurable by absolute numbers
> --------------------------------------------------------
>
>                 Key: CASSANDRA-801
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-801
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.6
>            Reporter: Ryan King
>            Assignee: Stu Hood
>             Fix For: 0.6, 0.7
>
>
> Just like the row cache, the key cache should be configurable by absolute numbers (not just a fraction). It would be nice to configure it by either memory size or entries (like the row cache).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (CASSANDRA-801) The Key Cache should be configurable by absolute numbers

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12838693#action_12838693 ] 

Jonathan Ellis edited comment on CASSANDRA-801 at 2/26/10 3:50 AM:
-------------------------------------------------------------------

cleaned out old patches, combined patches 1 and 2 and 3,5,6, and did a bunch of cleanup.

03
    Migrate rowCache into SSTableTracker and recalculate cache size when sstable collection changes

02
    Unify key cache per CF under SSTableTracker, hooked in w/ setTrackedBy replacing addFinalizingReference

01
    Convert KeysCachedFraction to KeysCached, temporarily breaking things since it gives KeysCached per SSTable not per CF.  Also refactors how key cache is instantiated, and removes SSTableAccessor from test suite.  These should be separate patches but I ran out of energy.


      was (Author: jbellis):
    cleaned out old patches, combined patches 1 and 2 and 3,4,6, and did a bunch of cleanup.

03
    Migrate rowCache into SSTableTracker and recalculate cache size when sstable collection changes

02
    Unify key cache per CF under SSTableTracker, hooked in w/ setTrackedBy replacing addFinalizingReference

01
    Convert KeysCachedFraction to KeysCached, temporarily breaking things since it gives KeysCached per SSTable not per CF.  Also refactors how key cache is instantiated, and removes SSTableAccessor from test suite.  These should be separate patches but I ran out of energy.

  
> The Key Cache should be configurable by absolute numbers
> --------------------------------------------------------
>
>                 Key: CASSANDRA-801
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-801
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.6
>            Reporter: Ryan King
>            Assignee: Stu Hood
>             Fix For: 0.6, 0.7
>
>         Attachments: 0001-Convert-KeysCachedFraction-to-KeysCached-temporarily-b.txt, 0002-Unify-key-cache-per-CF-under-SSTableTracker-hooked-in-.txt, 0003-Migrate-rowCache-into-SSTableTracker-and-recalculate-c.txt
>
>
> Just like the row cache, the key cache should be configurable by absolute numbers (not just a fraction). It would be nice to configure it by either memory size or entries (like the row cache).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-801) The Key Cache should be configurable by absolute numbers

Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12837486#action_12837486 ] 

Stu Hood commented on CASSANDRA-801:
------------------------------------

Ack. Totally broken by the KS/CF descriptor refactor. I'll rebase this in the next few days.

> The Key Cache should be configurable by absolute numbers
> --------------------------------------------------------
>
>                 Key: CASSANDRA-801
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-801
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.5
>            Reporter: Ryan King
>            Assignee: Stu Hood
>             Fix For: 0.6, 0.7
>
>         Attachments: 0001-Convert-KeysCachedFraction-to-KeysCached.patch, 0002-Update-config-values.patch, 0003-Sane-defaults.patch
>
>
> Just like the row cache, the key cache should be configurable by absolute numbers (not just a fraction). It would be nice to configure it by either memory size or entries (like the row cache).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-801) The Key Cache should be configurable by absolute numbers

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12834811#action_12834811 ] 

Jonathan Ellis commented on CASSANDRA-801:
------------------------------------------

i don't think this splits up the keys cached among the different sstables the way JMXAggregating cache does?  that should be consistent one way or the other.

> The Key Cache should be configurable by absolute numbers
> --------------------------------------------------------
>
>                 Key: CASSANDRA-801
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-801
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.5, 0.6, 0.7
>            Reporter: Ryan King
>            Assignee: Stu Hood
>             Fix For: 0.6, 0.7
>
>         Attachments: 0001-Convert-KeysCachedFraction-to-KeysCached.patch, 0002-Update-config-values.patch, 0003-Sane-defaults.patch
>
>
> Just like the row cache, the key cache should be configurable by absolute numbers (not just a fraction). It would be nice to configure it by either memory size or entries (like the row cache).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-801) The Key Cache should be configurable by absolute numbers

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-801:
-------------------------------------

    Attachment:     (was: trunk-0004-Migrate-rowCache-into-SSTableTracker.patch)

> The Key Cache should be configurable by absolute numbers
> --------------------------------------------------------
>
>                 Key: CASSANDRA-801
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-801
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.6
>            Reporter: Ryan King
>            Assignee: Stu Hood
>             Fix For: 0.6, 0.7
>
>
> Just like the row cache, the key cache should be configurable by absolute numbers (not just a fraction). It would be nice to configure it by either memory size or entries (like the row cache).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-801) The Key Cache should be configurable by absolute numbers

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-801:
-------------------------------------

    Attachment:     (was: 0.6-0002-Update-config-values-and-defaults.patch)

> The Key Cache should be configurable by absolute numbers
> --------------------------------------------------------
>
>                 Key: CASSANDRA-801
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-801
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.6
>            Reporter: Ryan King
>            Assignee: Stu Hood
>             Fix For: 0.6, 0.7
>
>
> Just like the row cache, the key cache should be configurable by absolute numbers (not just a fraction). It would be nice to configure it by either memory size or entries (like the row cache).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-801) The Key Cache should be configurable by absolute numbers

Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stu Hood updated CASSANDRA-801:
-------------------------------

    Attachment: 0002-Update-config-values.patch
                0001-Convert-KeysCachedFraction-to-KeysCached.patch

Converts KeysCachedFraction to KeysCached, using the same semantics as RowsCached.

Since we cache keys on a per-sstable basis, the number of Keys cached can still grow considerably if you have many, many sstables, but perhaps we can address that in a separate issue.

> The Key Cache should be configurable by absolute numbers
> --------------------------------------------------------
>
>                 Key: CASSANDRA-801
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-801
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.5, 0.6, 0.7
>            Reporter: Ryan King
>            Assignee: Stu Hood
>             Fix For: 0.6, 0.7
>
>         Attachments: 0001-Convert-KeysCachedFraction-to-KeysCached.patch, 0002-Update-config-values.patch
>
>
> Just like the row cache, the key cache should be configurable by absolute numbers (not just a fraction). It would be nice to configure it by either memory size or entries (like the row cache).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-801) The Key Cache should be configurable by absolute numbers

Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stu Hood updated CASSANDRA-801:
-------------------------------

    Attachment: trunk-0006-Remove-JMXAggregatingCache.patch
                trunk-0005-SSTableTracker-sets-the-cache-for-tracked-Readers.patch
                trunk-0004-Migrate-rowCache-into-SSTableTracker.patch

Patches 3 through 6 for trunk and 0.6 remove JMXAggregatingCache, and instead use a merged cache for all SSTables. Using individual caches per table would have lead to fragmentation, no matter how we sized them.

Both the row and key caches are moved into SSTableTracker, and they are resized as the estimated number of keys for the CFS changes.

Patches were stress tested with trunk and 0.6

> The Key Cache should be configurable by absolute numbers
> --------------------------------------------------------
>
>                 Key: CASSANDRA-801
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-801
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.6
>            Reporter: Ryan King
>            Assignee: Stu Hood
>             Fix For: 0.6, 0.7
>
>         Attachments: 0.6-0001-Convert-KeysCachedFraction-to-KeysCached.patch, 0.6-0001-Convert-KeysCachedFraction-to-KeysCached.patch, 0.6-0002-Update-config-values-and-defaults.patch, 0.6-0002-Update-config-values-and-defaults.patch, 0.6-0003-Stop-aggregating-individual-key-caches-into-one.patch, 0.6-0004-Migrate-rowCache-into-SSTableTracker.patch, 0.6-0005-SSTableTracker-sets-the-cache-for-tracked-Readers.patch, 0.6-0006-Remove-JMXAggregatingCache.patch, trunk-0001-Convert-KeysCachedFraction-to-KeysCached.patch, trunk-0001-Convert-KeysCachedFraction-to-KeysCached.patch, trunk-0002-Update-config-values-and-defaults.patch, trunk-0002-Update-config-values-and-defaults.patch, trunk-0003-Stop-aggregating-individual-key-caches-into-one.patch, trunk-0004-Migrate-rowCache-into-SSTableTracker.patch, trunk-0005-SSTableTracker-sets-the-cache-for-tracked-Readers.patch, trunk-0006-Remove-JMXAggregatingCache.patch
>
>
> Just like the row cache, the key cache should be configurable by absolute numbers (not just a fraction). It would be nice to configure it by either memory size or entries (like the row cache).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-801) The Key Cache should be configurable by absolute numbers

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-801:
-------------------------------------

    Attachment:     (was: trunk-0001-Convert-KeysCachedFraction-to-KeysCached.patch)

> The Key Cache should be configurable by absolute numbers
> --------------------------------------------------------
>
>                 Key: CASSANDRA-801
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-801
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.6
>            Reporter: Ryan King
>            Assignee: Stu Hood
>             Fix For: 0.6, 0.7
>
>
> Just like the row cache, the key cache should be configurable by absolute numbers (not just a fraction). It would be nice to configure it by either memory size or entries (like the row cache).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-801) The Key Cache should be configurable by absolute numbers

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-801:
-------------------------------------

    Attachment:     (was: trunk-0002-Update-config-values-and-defaults.patch)

> The Key Cache should be configurable by absolute numbers
> --------------------------------------------------------
>
>                 Key: CASSANDRA-801
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-801
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.6
>            Reporter: Ryan King
>            Assignee: Stu Hood
>             Fix For: 0.6, 0.7
>
>
> Just like the row cache, the key cache should be configurable by absolute numbers (not just a fraction). It would be nice to configure it by either memory size or entries (like the row cache).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-801) The Key Cache should be configurable by absolute numbers

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12838693#action_12838693 ] 

Jonathan Ellis commented on CASSANDRA-801:
------------------------------------------

cleaned out old patches, combined patches 1 and 2 and 3,4,6, and did a bunch of cleanup.

03
    Migrate rowCache into SSTableTracker and recalculate cache size when sstable collection changes

02
    Unify key cache per CF under SSTableTracker, hooked in w/ setTrackedBy replacing addFinalizingReference

01
    Convert KeysCachedFraction to KeysCached, temporarily breaking things since it gives KeysCached per SSTable not per CF.  Also refactors how key cache is instantiated, and removes SSTableAccessor from test suite.  These should be separate patches but I ran out of energy.


> The Key Cache should be configurable by absolute numbers
> --------------------------------------------------------
>
>                 Key: CASSANDRA-801
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-801
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.6
>            Reporter: Ryan King
>            Assignee: Stu Hood
>             Fix For: 0.6, 0.7
>
>         Attachments: 0001-Convert-KeysCachedFraction-to-KeysCached-temporarily-b.txt, 0002-Unify-key-cache-per-CF-under-SSTableTracker-hooked-in-.txt, 0003-Migrate-rowCache-into-SSTableTracker-and-recalculate-c.txt
>
>
> Just like the row cache, the key cache should be configurable by absolute numbers (not just a fraction). It would be nice to configure it by either memory size or entries (like the row cache).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-801) The Key Cache should be configurable by absolute numbers

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12839414#action_12839414 ] 

Hudson commented on CASSANDRA-801:
----------------------------------

Integrated in Cassandra #368 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/368/])
    r/m files to finish 0.6 merge of 


> The Key Cache should be configurable by absolute numbers
> --------------------------------------------------------
>
>                 Key: CASSANDRA-801
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-801
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.6
>            Reporter: Ryan King
>            Assignee: Stu Hood
>             Fix For: 0.6, 0.7
>
>         Attachments: 0001-Convert-KeysCachedFraction-to-KeysCached-temporarily-b.txt, 0002-Unify-key-cache-per-CF-under-SSTableTracker-hooked-in-.txt, 0003-Migrate-rowCache-into-SSTableTracker-and-recalculate-c.txt
>
>
> Just like the row cache, the key cache should be configurable by absolute numbers (not just a fraction). It would be nice to configure it by either memory size or entries (like the row cache).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-801) The Key Cache should be configurable by absolute numbers

Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stu Hood updated CASSANDRA-801:
-------------------------------

    Attachment: 0.6-0006-Remove-JMXAggregatingCache.patch
                0.6-0005-SSTableTracker-sets-the-cache-for-tracked-Readers.patch
                0.6-0004-Migrate-rowCache-into-SSTableTracker.patch

> The Key Cache should be configurable by absolute numbers
> --------------------------------------------------------
>
>                 Key: CASSANDRA-801
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-801
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.5
>            Reporter: Ryan King
>            Assignee: Stu Hood
>             Fix For: 0.6, 0.7
>
>         Attachments: 0.6-0001-Convert-KeysCachedFraction-to-KeysCached.patch, 0.6-0001-Convert-KeysCachedFraction-to-KeysCached.patch, 0.6-0002-Update-config-values-and-defaults.patch, 0.6-0002-Update-config-values-and-defaults.patch, 0.6-0003-Stop-aggregating-individual-key-caches-into-one.patch, 0.6-0004-Migrate-rowCache-into-SSTableTracker.patch, 0.6-0005-SSTableTracker-sets-the-cache-for-tracked-Readers.patch, 0.6-0006-Remove-JMXAggregatingCache.patch, trunk-0001-Convert-KeysCachedFraction-to-KeysCached.patch, trunk-0001-Convert-KeysCachedFraction-to-KeysCached.patch, trunk-0002-Update-config-values-and-defaults.patch, trunk-0002-Update-config-values-and-defaults.patch, trunk-0003-Stop-aggregating-individual-key-caches-into-one.patch
>
>
> Just like the row cache, the key cache should be configurable by absolute numbers (not just a fraction). It would be nice to configure it by either memory size or entries (like the row cache).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-801) The Key Cache should be configurable by absolute numbers

Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stu Hood updated CASSANDRA-801:
-------------------------------

    Attachment:     (was: 0001-Convert-KeysCachedFraction-to-KeysCached.patch)

> The Key Cache should be configurable by absolute numbers
> --------------------------------------------------------
>
>                 Key: CASSANDRA-801
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-801
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.5
>            Reporter: Ryan King
>            Assignee: Stu Hood
>             Fix For: 0.6, 0.7
>
>         Attachments: 0003-Sane-defaults.patch
>
>
> Just like the row cache, the key cache should be configurable by absolute numbers (not just a fraction). It would be nice to configure it by either memory size or entries (like the row cache).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-801) The Key Cache should be configurable by absolute numbers

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-801:
-------------------------------------

    Attachment:     (was: trunk-0006-Remove-JMXAggregatingCache.patch)

> The Key Cache should be configurable by absolute numbers
> --------------------------------------------------------
>
>                 Key: CASSANDRA-801
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-801
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.6
>            Reporter: Ryan King
>            Assignee: Stu Hood
>             Fix For: 0.6, 0.7
>
>
> Just like the row cache, the key cache should be configurable by absolute numbers (not just a fraction). It would be nice to configure it by either memory size or entries (like the row cache).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-801) The Key Cache should be configurable by absolute numbers

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-801:
-------------------------------------

    Attachment:     (was: 0.6-0003-Stop-aggregating-individual-key-caches-into-one.patch)

> The Key Cache should be configurable by absolute numbers
> --------------------------------------------------------
>
>                 Key: CASSANDRA-801
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-801
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.6
>            Reporter: Ryan King
>            Assignee: Stu Hood
>             Fix For: 0.6, 0.7
>
>
> Just like the row cache, the key cache should be configurable by absolute numbers (not just a fraction). It would be nice to configure it by either memory size or entries (like the row cache).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-801) The Key Cache should be configurable by absolute numbers

Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stu Hood updated CASSANDRA-801:
-------------------------------

    Attachment: trunk-0002-Update-config-values-and-defaults.patch
                trunk-0001-Convert-KeysCachedFraction-to-KeysCached.patch

> The Key Cache should be configurable by absolute numbers
> --------------------------------------------------------
>
>                 Key: CASSANDRA-801
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-801
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.5
>            Reporter: Ryan King
>            Assignee: Stu Hood
>             Fix For: 0.6, 0.7
>
>         Attachments: trunk-0001-Convert-KeysCachedFraction-to-KeysCached.patch, trunk-0002-Update-config-values-and-defaults.patch
>
>
> Just like the row cache, the key cache should be configurable by absolute numbers (not just a fraction). It would be nice to configure it by either memory size or entries (like the row cache).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-801) The Key Cache should be configurable by absolute numbers

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-801:
-------------------------------------

    Attachment:     (was: 0.6-0004-Migrate-rowCache-into-SSTableTracker.patch)

> The Key Cache should be configurable by absolute numbers
> --------------------------------------------------------
>
>                 Key: CASSANDRA-801
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-801
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.6
>            Reporter: Ryan King
>            Assignee: Stu Hood
>             Fix For: 0.6, 0.7
>
>
> Just like the row cache, the key cache should be configurable by absolute numbers (not just a fraction). It would be nice to configure it by either memory size or entries (like the row cache).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-801) The Key Cache should be configurable by absolute numbers

Posted by "Ryan King (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12835301#action_12835301 ] 

Ryan King commented on CASSANDRA-801:
-------------------------------------

I think having this in 0.6 would be great.

> The Key Cache should be configurable by absolute numbers
> --------------------------------------------------------
>
>                 Key: CASSANDRA-801
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-801
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.5, 0.6, 0.7
>            Reporter: Ryan King
>            Assignee: Stu Hood
>             Fix For: 0.6, 0.7
>
>         Attachments: 0001-Convert-KeysCachedFraction-to-KeysCached.patch, 0002-Update-config-values.patch, 0003-Sane-defaults.patch
>
>
> Just like the row cache, the key cache should be configurable by absolute numbers (not just a fraction). It would be nice to configure it by either memory size or entries (like the row cache).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-801) The Key Cache should be configurable by absolute numbers

Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stu Hood updated CASSANDRA-801:
-------------------------------

    Attachment: 0.6-0002-Update-config-values-and-defaults.patch
                0.6-0001-Convert-KeysCachedFraction-to-KeysCached.patch

Rebased for trunk and 0.6. The only difference in these patches is that the default for RowsCached and KeysCached is now 10%.

I'll probably add one more patch later to implement the JMXAggregatingCache change to merge SSTable key caches.

> The Key Cache should be configurable by absolute numbers
> --------------------------------------------------------
>
>                 Key: CASSANDRA-801
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-801
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.5
>            Reporter: Ryan King
>            Assignee: Stu Hood
>             Fix For: 0.6, 0.7
>
>         Attachments: 0.6-0001-Convert-KeysCachedFraction-to-KeysCached.patch, 0.6-0002-Update-config-values-and-defaults.patch, trunk-0001-Convert-KeysCachedFraction-to-KeysCached.patch, trunk-0002-Update-config-values-and-defaults.patch
>
>
> Just like the row cache, the key cache should be configurable by absolute numbers (not just a fraction). It would be nice to configure it by either memory size or entries (like the row cache).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-801) The Key Cache should be configurable by absolute numbers

Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12835097#action_12835097 ] 

Stu Hood commented on CASSANDRA-801:
------------------------------------

Are we still interested in getting this in 0.6, or has it missed the boat? (assuming I make a rebased 0.6 version)

> The Key Cache should be configurable by absolute numbers
> --------------------------------------------------------
>
>                 Key: CASSANDRA-801
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-801
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.5, 0.6, 0.7
>            Reporter: Ryan King
>            Assignee: Stu Hood
>             Fix For: 0.6, 0.7
>
>         Attachments: 0001-Convert-KeysCachedFraction-to-KeysCached.patch, 0002-Update-config-values.patch, 0003-Sane-defaults.patch
>
>
> Just like the row cache, the key cache should be configurable by absolute numbers (not just a fraction). It would be nice to configure it by either memory size or entries (like the row cache).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-801) The Key Cache should be configurable by absolute numbers

Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stu Hood updated CASSANDRA-801:
-------------------------------

    Attachment:     (was: 0002-Update-config-values.patch)

> The Key Cache should be configurable by absolute numbers
> --------------------------------------------------------
>
>                 Key: CASSANDRA-801
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-801
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.5
>            Reporter: Ryan King
>            Assignee: Stu Hood
>             Fix For: 0.6, 0.7
>
>         Attachments: 0003-Sane-defaults.patch
>
>
> Just like the row cache, the key cache should be configurable by absolute numbers (not just a fraction). It would be nice to configure it by either memory size or entries (like the row cache).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-801) The Key Cache should be configurable by absolute numbers

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-801:
-------------------------------------

    Attachment:     (was: 0.6-0005-SSTableTracker-sets-the-cache-for-tracked-Readers.patch)

> The Key Cache should be configurable by absolute numbers
> --------------------------------------------------------
>
>                 Key: CASSANDRA-801
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-801
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.6
>            Reporter: Ryan King
>            Assignee: Stu Hood
>             Fix For: 0.6, 0.7
>
>
> Just like the row cache, the key cache should be configurable by absolute numbers (not just a fraction). It would be nice to configure it by either memory size or entries (like the row cache).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (CASSANDRA-801) The Key Cache should be configurable by absolute numbers

Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12834634#action_12834634 ] 

Stu Hood edited comment on CASSANDRA-801 at 2/17/10 4:15 AM:
-------------------------------------------------------------

One more patch to change the default key and row cache counts to 10,000 and 1,000 respectively.

EDIT: Didn't read the comments before posting... I'm fine with anything.

      was (Author: stuhood):
    One more patch to change the default key and row cache counts to 10,000 and 1,000 respectively.
  
> The Key Cache should be configurable by absolute numbers
> --------------------------------------------------------
>
>                 Key: CASSANDRA-801
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-801
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.5, 0.6, 0.7
>            Reporter: Ryan King
>            Assignee: Stu Hood
>             Fix For: 0.6, 0.7
>
>         Attachments: 0001-Convert-KeysCachedFraction-to-KeysCached.patch, 0002-Update-config-values.patch, 0003-Sane-defaults.patch
>
>
> Just like the row cache, the key cache should be configurable by absolute numbers (not just a fraction). It would be nice to configure it by either memory size or entries (like the row cache).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-801) The Key Cache should be configurable by absolute numbers

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-801:
-------------------------------------

    Attachment: 0003-Migrate-rowCache-into-SSTableTracker-and-recalculate-c.txt
                0002-Unify-key-cache-per-CF-under-SSTableTracker-hooked-in-.txt
                0001-Convert-KeysCachedFraction-to-KeysCached-temporarily-b.txt

> The Key Cache should be configurable by absolute numbers
> --------------------------------------------------------
>
>                 Key: CASSANDRA-801
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-801
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.6
>            Reporter: Ryan King
>            Assignee: Stu Hood
>             Fix For: 0.6, 0.7
>
>         Attachments: 0001-Convert-KeysCachedFraction-to-KeysCached-temporarily-b.txt, 0002-Unify-key-cache-per-CF-under-SSTableTracker-hooked-in-.txt, 0003-Migrate-rowCache-into-SSTableTracker-and-recalculate-c.txt
>
>
> Just like the row cache, the key cache should be configurable by absolute numbers (not just a fraction). It would be nice to configure it by either memory size or entries (like the row cache).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-801) The Key Cache should be configurable by absolute numbers

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-801:
-------------------------------------

    Attachment:     (was: 0.6-0001-Convert-KeysCachedFraction-to-KeysCached.patch)

> The Key Cache should be configurable by absolute numbers
> --------------------------------------------------------
>
>                 Key: CASSANDRA-801
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-801
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.6
>            Reporter: Ryan King
>            Assignee: Stu Hood
>             Fix For: 0.6, 0.7
>
>
> Just like the row cache, the key cache should be configurable by absolute numbers (not just a fraction). It would be nice to configure it by either memory size or entries (like the row cache).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-801) The Key Cache should be configurable by absolute numbers

Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stu Hood updated CASSANDRA-801:
-------------------------------

    Attachment: 0.6-0003-Stop-aggregating-individual-key-caches-into-one.patch
                0.6-0002-Update-config-values-and-defaults.patch
                0.6-0001-Convert-KeysCachedFraction-to-KeysCached.patch

> The Key Cache should be configurable by absolute numbers
> --------------------------------------------------------
>
>                 Key: CASSANDRA-801
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-801
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.5
>            Reporter: Ryan King
>            Assignee: Stu Hood
>             Fix For: 0.6, 0.7
>
>         Attachments: 0.6-0001-Convert-KeysCachedFraction-to-KeysCached.patch, 0.6-0001-Convert-KeysCachedFraction-to-KeysCached.patch, 0.6-0002-Update-config-values-and-defaults.patch, 0.6-0002-Update-config-values-and-defaults.patch, 0.6-0003-Stop-aggregating-individual-key-caches-into-one.patch, 0.6-0004-Migrate-rowCache-into-SSTableTracker.patch, 0.6-0005-SSTableTracker-sets-the-cache-for-tracked-Readers.patch, 0.6-0006-Remove-JMXAggregatingCache.patch, trunk-0001-Convert-KeysCachedFraction-to-KeysCached.patch, trunk-0001-Convert-KeysCachedFraction-to-KeysCached.patch, trunk-0002-Update-config-values-and-defaults.patch, trunk-0002-Update-config-values-and-defaults.patch, trunk-0003-Stop-aggregating-individual-key-caches-into-one.patch
>
>
> Just like the row cache, the key cache should be configurable by absolute numbers (not just a fraction). It would be nice to configure it by either memory size or entries (like the row cache).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-801) The Key Cache should be configurable by absolute numbers

Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stu Hood updated CASSANDRA-801:
-------------------------------

    Attachment: trunk-0003-Stop-aggregating-individual-key-caches-into-one.patch
                trunk-0002-Update-config-values-and-defaults.patch
                trunk-0001-Convert-KeysCachedFraction-to-KeysCached.patch

> The Key Cache should be configurable by absolute numbers
> --------------------------------------------------------
>
>                 Key: CASSANDRA-801
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-801
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.5
>            Reporter: Ryan King
>            Assignee: Stu Hood
>             Fix For: 0.6, 0.7
>
>         Attachments: 0.6-0001-Convert-KeysCachedFraction-to-KeysCached.patch, 0.6-0001-Convert-KeysCachedFraction-to-KeysCached.patch, 0.6-0002-Update-config-values-and-defaults.patch, 0.6-0002-Update-config-values-and-defaults.patch, 0.6-0003-Stop-aggregating-individual-key-caches-into-one.patch, 0.6-0004-Migrate-rowCache-into-SSTableTracker.patch, 0.6-0005-SSTableTracker-sets-the-cache-for-tracked-Readers.patch, 0.6-0006-Remove-JMXAggregatingCache.patch, trunk-0001-Convert-KeysCachedFraction-to-KeysCached.patch, trunk-0001-Convert-KeysCachedFraction-to-KeysCached.patch, trunk-0002-Update-config-values-and-defaults.patch, trunk-0002-Update-config-values-and-defaults.patch, trunk-0003-Stop-aggregating-individual-key-caches-into-one.patch
>
>
> Just like the row cache, the key cache should be configurable by absolute numbers (not just a fraction). It would be nice to configure it by either memory size or entries (like the row cache).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-801) The Key Cache should be configurable by absolute numbers

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12834631#action_12834631 ] 

Jonathan Ellis commented on CASSANDRA-801:
------------------------------------------

I'd rather do 10%, 10K is nothing (and the difference between 10k rows 100% cached, 100k rows 10% cached, and 1M rows 1% cached is pretty huge when you're stress testing.  a single run of py_stress will blow through all of those.) 

60M is plenty of headroom before you need to read the docs. :)

> The Key Cache should be configurable by absolute numbers
> --------------------------------------------------------
>
>                 Key: CASSANDRA-801
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-801
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.5, 0.6, 0.7
>            Reporter: Ryan King
>            Assignee: Stu Hood
>             Fix For: 0.6, 0.7
>
>         Attachments: 0001-Convert-KeysCachedFraction-to-KeysCached.patch, 0002-Update-config-values.patch
>
>
> Just like the row cache, the key cache should be configurable by absolute numbers (not just a fraction). It would be nice to configure it by either memory size or entries (like the row cache).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-801) The Key Cache should be configurable by absolute numbers

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-801:
-------------------------------------

    Attachment:     (was: 0.6-0006-Remove-JMXAggregatingCache.patch)

> The Key Cache should be configurable by absolute numbers
> --------------------------------------------------------
>
>                 Key: CASSANDRA-801
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-801
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.6
>            Reporter: Ryan King
>            Assignee: Stu Hood
>             Fix For: 0.6, 0.7
>
>
> Just like the row cache, the key cache should be configurable by absolute numbers (not just a fraction). It would be nice to configure it by either memory size or entries (like the row cache).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-801) The Key Cache should be configurable by absolute numbers

Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stu Hood updated CASSANDRA-801:
-------------------------------

    Attachment:     (was: 0003-Sane-defaults.patch)

> The Key Cache should be configurable by absolute numbers
> --------------------------------------------------------
>
>                 Key: CASSANDRA-801
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-801
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.5
>            Reporter: Ryan King
>            Assignee: Stu Hood
>             Fix For: 0.6, 0.7
>
>         Attachments: trunk-0001-Convert-KeysCachedFraction-to-KeysCached.patch, trunk-0002-Update-config-values-and-defaults.patch
>
>
> Just like the row cache, the key cache should be configurable by absolute numbers (not just a fraction). It would be nice to configure it by either memory size or entries (like the row cache).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-801) The Key Cache should be configurable by absolute numbers

Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12838722#action_12838722 ] 

Stu Hood commented on CASSANDRA-801:
------------------------------------

+1... let's get it in.

> The Key Cache should be configurable by absolute numbers
> --------------------------------------------------------
>
>                 Key: CASSANDRA-801
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-801
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.6
>            Reporter: Ryan King
>            Assignee: Stu Hood
>             Fix For: 0.6, 0.7
>
>         Attachments: 0001-Convert-KeysCachedFraction-to-KeysCached-temporarily-b.txt, 0002-Unify-key-cache-per-CF-under-SSTableTracker-hooked-in-.txt, 0003-Migrate-rowCache-into-SSTableTracker-and-recalculate-c.txt
>
>
> Just like the row cache, the key cache should be configurable by absolute numbers (not just a fraction). It would be nice to configure it by either memory size or entries (like the row cache).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.