You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/07/21 19:00:18 UTC
[GitHub] [beam] akashorabek opened a new pull request, #22399: [CdapIO] Fixed necessary warnings
akashorabek opened a new pull request, #22399:
URL: https://github.com/apache/beam/pull/22399
In CdapIO we have some warnings that come out when trying to build a project. Previously, we suppressed these warnings with the @SuppressWarnings annotation.
The purpose of this PR is to solve the necessary warnings without the @SuppressWarnings annotation and loss of IO functionality.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj merged pull request #22399: [CdapIO] Fixed necessary warnings
Posted by GitBox <gi...@apache.org>.
chamikaramj merged PR #22399:
URL: https://github.com/apache/beam/pull/22399
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on a diff in pull request #22399: [CdapIO] Fixed necessary warnings
Posted by GitBox <gi...@apache.org>.
Abacn commented on code in PR #22399:
URL: https://github.com/apache/beam/pull/22399#discussion_r927150767
##########
sdks/java/io/cdap/src/test/java/org/apache/beam/sdk/io/cdap/CdapIOTest.java:
##########
@@ -118,12 +118,6 @@ public void testReadObjectCreationFailsIfValueClassIsNull() {
IllegalArgumentException.class, () -> CdapIO.<String, String>read().withValueClass(null));
}
- @Test
- public void testReadValidationFailsMissingCdapPluginClass() {
Review Comment:
Good to preserve these error handling tests. now it throws at expansion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #22399: [CdapIO] Fixed necessary warnings
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22399:
URL: https://github.com/apache/beam/pull/22399#issuecomment-1191853145
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @kileys for label java.
R: @Abacn for label io.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Lizzfox commented on pull request #22399: [CdapIO] Fixed necessary warnings
Posted by GitBox <gi...@apache.org>.
Lizzfox commented on PR #22399:
URL: https://github.com/apache/beam/pull/22399#issuecomment-1192529993
> There are also other suppression annotations exists currently, are there also considered need to be resolved?
@Abacn, thank you for the comment. Yes, there are two classes with warnings suppression left in the CdapIO package.
1. In the `Plugin` class, the warnings will be fixed in the following PR where we will integrate SparkReceiverIO with CdapIO.
2. The `BatchContextImpl` class is an abstraction that we've implemented to make it possible to use CDAP abstractions in the Apache Beam context. Methods that produce warnings are overridden so we can't change their signature to resolve warnings. The suppressions in the `BatchContextImp` class aren't expected to be resolved anytime soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] akashorabek commented on a diff in pull request #22399: [CdapIO] Fixed necessary warnings
Posted by GitBox <gi...@apache.org>.
akashorabek commented on code in PR #22399:
URL: https://github.com/apache/beam/pull/22399#discussion_r927486698
##########
sdks/java/io/cdap/src/test/java/org/apache/beam/sdk/io/cdap/CdapIOTest.java:
##########
@@ -118,12 +118,6 @@ public void testReadObjectCreationFailsIfValueClassIsNull() {
IllegalArgumentException.class, () -> CdapIO.<String, String>read().withValueClass(null));
}
- @Test
- public void testReadValidationFailsMissingCdapPluginClass() {
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org