You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/09/09 21:43:33 UTC
[GitHub] [geode] pivotal-eshu opened a new pull request #5500: GEODE-8486: record TransactionDataRebalancedException if tx put failed
pivotal-eshu opened a new pull request #5500:
URL: https://github.com/apache/geode/pull/5500
This is used to handle a retry of transactional put.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] DonalEvans commented on a change in pull request #5500: GEODE-8486: record TransactionDataRebalancedException if tx put failed
Posted by GitBox <gi...@apache.org>.
DonalEvans commented on a change in pull request #5500:
URL: https://github.com/apache/geode/pull/5500#discussion_r485950037
##########
File path: geode-core/src/main/java/org/apache/geode/internal/cache/TXState.java
##########
@@ -146,7 +146,9 @@
/** keeps track of events, so as not to re-apply events */
protected Set<EventID> seenEvents = new HashSet<EventID>();
/** keeps track of results of txPutEntry */
- private Map<EventID, Boolean> seenResults = new HashMap<EventID, Boolean>();
+ private Map<EventID, Boolean> seenResults = new HashMap<>();
+ /** keeps track of TransactionDataRebalancedException during txPutEntry */
+ private Map<EventID, TransactionDataRebalancedException> failedExceptions = new HashMap<>();
Review comment:
This might be better named "failedEvents" or "eventExceptions."
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] pivotal-eshu merged pull request #5500: GEODE-8486: record TransactionDataRebalancedException if tx put failed
Posted by GitBox <gi...@apache.org>.
pivotal-eshu merged pull request #5500:
URL: https://github.com/apache/geode/pull/5500
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org