You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@helix.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2018/07/18 05:15:00 UTC
[jira] [Commented] (HELIX-738) [TASK] Remove quotaType APIs and
make jobs inherit type from workflows
[ https://issues.apache.org/jira/browse/HELIX-738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16547378#comment-16547378 ]
Hudson commented on HELIX-738:
------------------------------
FAILURE: Integrated in Jenkins build helix #1516 (See [https://builds.apache.org/job/helix/1516/])
[HELIX-738] Remove quotaType APIs and make jobs inherit type from (narendly: rev 36ab2a6028dad39b32d3a15da942b4385ff9fd1d)
* (edit) helix-core/src/main/java/org/apache/helix/task/ThreadCountBasedTaskAssignmentCalculator.java
* (edit) helix-core/src/main/java/org/apache/helix/task/WorkflowConfig.java
* (edit) helix-core/src/main/java/org/apache/helix/task/JobConfig.java
* (edit) helix-core/src/main/java/org/apache/helix/task/TaskAssignmentCalculator.java
* (edit) helix-core/src/test/java/org/apache/helix/integration/task/TestJobAndWorkflowType.java
* (edit) helix-core/src/test/java/org/apache/helix/integration/task/TestWorkflowTermination.java
* (edit) helix-core/src/main/java/org/apache/helix/task/AbstractTaskDispatcher.java
* (edit) helix-core/src/main/java/org/apache/helix/task/AssignableInstanceManager.java
* (edit) helix-core/src/main/java/org/apache/helix/task/FixedTargetTaskAssignmentCalculator.java
* (edit) helix-core/src/test/java/org/apache/helix/integration/task/TestQuotaBasedScheduling.java
> [TASK] Remove quotaType APIs and make jobs inherit type from workflows
> ----------------------------------------------------------------------
>
> Key: HELIX-738
> URL: https://issues.apache.org/jira/browse/HELIX-738
> Project: Apache Helix
> Issue Type: Improvement
> Reporter: Hunter L
> Priority: Major
>
> For quota-based task scheduling, for each job, we provided get/setQuotaType APIs. However, the use case for workflow types and job types were similar enough that we decided to merge them and begin using workflow/job types for quota-based scheduling. Job types will now be used as quota types, and all jobs will inherit the type, if set, from their parent workflow, at assignment and schedule time.
> Changelist:
> 1. Remove APIs around quotaType in Workflow/JobConfig
> 2. Add an internal method in TaskAssignmentCalculator that includes logic for determining which quota type each job should use
> 3. Adjust tests so that they test and pass successfully
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)