You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "hxmhlt (GitHub)" <gi...@apache.org> on 2019/09/11 13:26:46 UTC
[GitHub] [dubbo-go] hxmhlt opened pull request #201: Fix:fix url
params unsafe
<!-- Thanks for sending a pull request!
-->
**What this PR does**:
Fix fix url params unsafe completely.
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #200
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
```
[ Full content available at: https://github.com/apache/dubbo-go/pull/201 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on issue #201: Fix:fix url
params unsafe
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/201?src=pr&el=h1) Report
> Merging [#201](https://codecov.io/gh/apache/dubbo-go/pull/201?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/cf198d0e3e5977f77b52ced2d45da16b52f92d2e?src=pr&el=desc) will **increase** coverage by `1.21%`.
> The diff coverage is `81.66%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/201?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #201 +/- ##
===========================================
+ Coverage 66.7% 67.91% +1.21%
===========================================
Files 94 94
Lines 5820 5847 +27
===========================================
+ Hits 3882 3971 +89
+ Misses 1538 1474 -64
- Partials 400 402 +2
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/201?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [registry/consul/utils.go](https://codecov.io/gh/apache/dubbo-go/pull/201/diff?src=pr&el=tree#diff-cmVnaXN0cnkvY29uc3VsL3V0aWxzLmdv) | `68.08% <0%> (-3.03%)` | :arrow_down: |
| [registry/nacos/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/201/diff?src=pr&el=tree#diff-cmVnaXN0cnkvbmFjb3MvcmVnaXN0cnkuZ28=) | `74.5% <100%> (+0.5%)` | :arrow_up: |
| [registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/201/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL3JlZ2lzdHJ5Lmdv) | `62.91% <100%> (+0.31%)` | :arrow_up: |
| [registry/etcdv3/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/201/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL3JlZ2lzdHJ5Lmdv) | `57.38% <100%> (+1.63%)` | :arrow_up: |
| [...rotocol/protocolwrapper/protocol\_filter\_wrapper.go](https://codecov.io/gh/apache/dubbo-go/pull/201/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcHJvdG9jb2x3cmFwcGVyL3Byb3RvY29sX2ZpbHRlcl93cmFwcGVyLmdv) | `51.42% <100%> (ø)` | :arrow_up: |
| [common/url.go](https://codecov.io/gh/apache/dubbo-go/pull/201/diff?src=pr&el=tree#diff-Y29tbW9uL3VybC5nbw==) | `75.98% <83.33%> (+1.09%)` | :arrow_up: |
| [remoting/zookeeper/client.go](https://codecov.io/gh/apache/dubbo-go/pull/201/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2NsaWVudC5nbw==) | `63.58% <0%> (+0.86%)` | :arrow_up: |
| [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/201/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `46.9% <0%> (+1.54%)` | :arrow_up: |
| [protocol/dubbo/readwriter.go](https://codecov.io/gh/apache/dubbo-go/pull/201/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vcmVhZHdyaXRlci5nbw==) | `70.37% <0%> (+2.46%)` | :arrow_up: |
| ... and [3 more](https://codecov.io/gh/apache/dubbo-go/pull/201/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/201?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/201?src=pr&el=footer). Last update [cf198d0...9eec723](https://codecov.io/gh/apache/dubbo-go/pull/201?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo-go/pull/201 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on issue #201: Fix:fix url
params unsafe
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/201?src=pr&el=h1) Report
> Merging [#201](https://codecov.io/gh/apache/dubbo-go/pull/201?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/cf198d0e3e5977f77b52ced2d45da16b52f92d2e?src=pr&el=desc) will **increase** coverage by `1.17%`.
> The diff coverage is `83.33%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/201?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #201 +/- ##
===========================================
+ Coverage 66.7% 67.88% +1.17%
===========================================
Files 94 94
Lines 5820 5847 +27
===========================================
+ Hits 3882 3969 +87
+ Misses 1538 1476 -62
- Partials 400 402 +2
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/201?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [registry/consul/utils.go](https://codecov.io/gh/apache/dubbo-go/pull/201/diff?src=pr&el=tree#diff-cmVnaXN0cnkvY29uc3VsL3V0aWxzLmdv) | `68.08% <0%> (-3.03%)` | :arrow_down: |
| [registry/nacos/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/201/diff?src=pr&el=tree#diff-cmVnaXN0cnkvbmFjb3MvcmVnaXN0cnkuZ28=) | `74.5% <100%> (+0.5%)` | :arrow_up: |
| [registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/201/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL3JlZ2lzdHJ5Lmdv) | `62.91% <100%> (+0.31%)` | :arrow_up: |
| [registry/etcdv3/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/201/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL3JlZ2lzdHJ5Lmdv) | `56.25% <100%> (+0.5%)` | :arrow_up: |
| [...rotocol/protocolwrapper/protocol\_filter\_wrapper.go](https://codecov.io/gh/apache/dubbo-go/pull/201/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcHJvdG9jb2x3cmFwcGVyL3Byb3RvY29sX2ZpbHRlcl93cmFwcGVyLmdv) | `51.42% <100%> (ø)` | :arrow_up: |
| [common/url.go](https://codecov.io/gh/apache/dubbo-go/pull/201/diff?src=pr&el=tree#diff-Y29tbW9uL3VybC5nbw==) | `75.98% <85.71%> (+1.09%)` | :arrow_up: |
| [remoting/zookeeper/client.go](https://codecov.io/gh/apache/dubbo-go/pull/201/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2NsaWVudC5nbw==) | `63.58% <0%> (+0.86%)` | :arrow_up: |
| [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/201/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `46.9% <0%> (+1.54%)` | :arrow_up: |
| [protocol/dubbo/readwriter.go](https://codecov.io/gh/apache/dubbo-go/pull/201/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vcmVhZHdyaXRlci5nbw==) | `70.37% <0%> (+2.46%)` | :arrow_up: |
| [protocol/dubbo/codec.go](https://codecov.io/gh/apache/dubbo-go/pull/201/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY29kZWMuZ28=) | `82.35% <0%> (+5.88%)` | :arrow_up: |
| ... and [2 more](https://codecov.io/gh/apache/dubbo-go/pull/201/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/201?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/201?src=pr&el=footer). Last update [cf198d0...d6fadc1](https://codecov.io/gh/apache/dubbo-go/pull/201?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo-go/pull/201 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on issue #201: Fix:fix url
params unsafe
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/201?src=pr&el=h1) Report
> Merging [#201](https://codecov.io/gh/apache/dubbo-go/pull/201?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/cf198d0e3e5977f77b52ced2d45da16b52f92d2e?src=pr&el=desc) will **increase** coverage by `0.22%`.
> The diff coverage is `83.33%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/201?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #201 +/- ##
===========================================
+ Coverage 66.7% 66.92% +0.22%
===========================================
Files 94 94
Lines 5820 5847 +27
===========================================
+ Hits 3882 3913 +31
+ Misses 1538 1536 -2
+ Partials 400 398 -2
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/201?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [registry/consul/utils.go](https://codecov.io/gh/apache/dubbo-go/pull/201/diff?src=pr&el=tree#diff-cmVnaXN0cnkvY29uc3VsL3V0aWxzLmdv) | `68.08% <0%> (-3.03%)` | :arrow_down: |
| [registry/nacos/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/201/diff?src=pr&el=tree#diff-cmVnaXN0cnkvbmFjb3MvcmVnaXN0cnkuZ28=) | `74.5% <100%> (+0.5%)` | :arrow_up: |
| [registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/201/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL3JlZ2lzdHJ5Lmdv) | `62.91% <100%> (+0.31%)` | :arrow_up: |
| [registry/etcdv3/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/201/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL3JlZ2lzdHJ5Lmdv) | `56.25% <100%> (+0.5%)` | :arrow_up: |
| [...rotocol/protocolwrapper/protocol\_filter\_wrapper.go](https://codecov.io/gh/apache/dubbo-go/pull/201/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcHJvdG9jb2x3cmFwcGVyL3Byb3RvY29sX2ZpbHRlcl93cmFwcGVyLmdv) | `51.42% <100%> (ø)` | :arrow_up: |
| [common/url.go](https://codecov.io/gh/apache/dubbo-go/pull/201/diff?src=pr&el=tree#diff-Y29tbW9uL3VybC5nbw==) | `75.98% <85.71%> (+1.09%)` | :arrow_up: |
| [remoting/zookeeper/client.go](https://codecov.io/gh/apache/dubbo-go/pull/201/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2NsaWVudC5nbw==) | `63.58% <0%> (+0.86%)` | :arrow_up: |
| [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/201/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `46.9% <0%> (+1.54%)` | :arrow_up: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/201/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `80.64% <0%> (+2.15%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/201?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/201?src=pr&el=footer). Last update [cf198d0...d6fadc1](https://codecov.io/gh/apache/dubbo-go/pull/201?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo-go/pull/201 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org