You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by jl...@apache.org on 2009/04/16 11:49:53 UTC

svn commit: r765545 - in /ofbiz/trunk: ./ .classpath LICENSE applications/content/lib/poi-3.2-FINAL-20081019.jar applications/content/lib/poi.jar applications/product/src/org/ofbiz/product/spreadsheetimport/ImportProductServices.java

Author: jleroux
Date: Thu Apr 16 09:49:52 2009
New Revision: 765545

URL: http://svn.apache.org/viewvc?rev=765545&view=rev
Log:
A patch from Erwan de FERRIERES "use up-to-date poi.jar library" https://issues.apache.org/jira/browse/OFBIZ-2299


Added:
    ofbiz/trunk/applications/content/lib/poi-3.2-FINAL-20081019.jar   (with props)
Removed:
    ofbiz/trunk/applications/content/lib/poi.jar
Modified:
    ofbiz/trunk/   (props changed)
    ofbiz/trunk/.classpath
    ofbiz/trunk/LICENSE
    ofbiz/trunk/applications/product/src/org/ofbiz/product/spreadsheetimport/ImportProductServices.java

Propchange: ofbiz/trunk/
------------------------------------------------------------------------------
--- svn:ignore (original)
+++ svn:ignore Thu Apr 16 09:49:52 2009
@@ -7,3 +7,5 @@
 *.time
 .settings
 .project
+reports
+dropit

Modified: ofbiz/trunk/.classpath
URL: http://svn.apache.org/viewvc/ofbiz/trunk/.classpath?rev=765545&r1=765544&r2=765545&view=diff
==============================================================================
--- ofbiz/trunk/.classpath (original)
+++ ofbiz/trunk/.classpath Thu Apr 16 09:49:52 2009
@@ -55,7 +55,7 @@
 	<classpathentry kind="lib" path="framework/jetty/lib/jasper-compiler-5.5.15.jar"/>
 	<classpathentry kind="lib" path="framework/guiapp/lib/XuiCoreSwing-v3.2rc2b.jar"/>
 	<classpathentry kind="lib" path="framework/guiapp/lib/XuiOptional-v3.2rc2b.jar"/>
-	<classpathentry kind="lib" path="applications/content/lib/poi.jar"/>
+	<classpathentry kind="lib" path="applications/content/lib/poi-3.2-FINAL-20081019.jar"/>
 	<classpathentry kind="lib" path="applications/content/lib/lucene-2.2.0.jar"/>
 	<classpathentry kind="lib" path="framework/catalina/lib/tomcat-6.0.16-catalina-ha.jar"/>
 	<classpathentry kind="lib" path="framework/catalina/lib/tomcat-6.0.16-catalina-tribes.jar"/>

Modified: ofbiz/trunk/LICENSE
URL: http://svn.apache.org/viewvc/ofbiz/trunk/LICENSE?rev=765545&r1=765544&r2=765545&view=diff
==============================================================================
--- ofbiz/trunk/LICENSE (original)
+++ ofbiz/trunk/LICENSE Thu Apr 16 09:49:52 2009
@@ -101,7 +101,7 @@
 ofbiz/trunk/framework/webslinger/lib/webslinger-ext-20090312-2018a822aa51.jar
 ofbiz/trunk/framework/webslinger/lib/webslinger-launcher-20090312-2018a822aa51.jar
 ofbiz/trunk/applications/content/lib/lucene-2.2.0.jar
-ofbiz/trunk/applications/content/lib/poi.jar
+ofbiz/trunk/applications/content/lib/poi-3.2-FINAL-20081019.jar
 ==========================================================================
                                  Apache License
                            Version 2.0, January 2004

Added: ofbiz/trunk/applications/content/lib/poi-3.2-FINAL-20081019.jar
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/content/lib/poi-3.2-FINAL-20081019.jar?rev=765545&view=auto
==============================================================================
Binary file - no diff available.

Propchange: ofbiz/trunk/applications/content/lib/poi-3.2-FINAL-20081019.jar
------------------------------------------------------------------------------
    svn:mime-type = application/octet-stream

Modified: ofbiz/trunk/applications/product/src/org/ofbiz/product/spreadsheetimport/ImportProductServices.java
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/src/org/ofbiz/product/spreadsheetimport/ImportProductServices.java?rev=765545&r1=765544&r2=765545&view=diff
==============================================================================
--- ofbiz/trunk/applications/product/src/org/ofbiz/product/spreadsheetimport/ImportProductServices.java (original)
+++ ofbiz/trunk/applications/product/src/org/ofbiz/product/spreadsheetimport/ImportProductServices.java Thu Apr 16 09:49:52 2009
@@ -113,11 +113,11 @@
                 if (row != null) {
                     // read productId from first column "sheet column index
                     // starts from 0"
-                    HSSFCell cell1 = row.getCell((short) 1);
+                    HSSFCell cell1 = row.getCell((int) 1);
                     cell1.setCellType(HSSFCell.CELL_TYPE_STRING);
-                    String productId = cell1.getStringCellValue();
+                    String productId = cell1.getRichStringCellValue().toString();
                     // read QOH from ninth column
-                    HSSFCell cell8 = row.getCell((short) 8);
+                    HSSFCell cell8 = row.getCell((int) 8);
                     BigDecimal quantityOnHand = BigDecimal.ZERO;
                     if (cell8 != null && cell8.getCellType() == HSSFCell.CELL_TYPE_NUMERIC)
                         quantityOnHand = new BigDecimal(cell8.getNumericCellValue());



Re: svn commit: r765545 - in /ofbiz/trunk: ./ .classpath LICENSE applications/content/lib/poi-3.2-FINAL-20081019.jar applications/content/lib/poi.jar applications/product/src/org/ofbiz/product/spreadsheetimport/ImportProductServices.java

Posted by Jacques Le Roux <ja...@les7arts.com>.
Thanks Jacopo,

Indeed, reverted at revision: 765562  

Jacques

From: "Jacopo Cappellato" <ja...@hotwaxmedia.com>
> Hi Jacques,
> 
> I think that a part of this commit was unintentional.
> 
> Jacopo
> 
> On Apr 16, 2009, at 11:49 AM, jleroux@apache.org wrote:
> 
>> Propchange: ofbiz/trunk/
>> ------------------------------------------------------------------------------
>> --- svn:ignore (original)
>> +++ svn:ignore Thu Apr 16 09:49:52 2009
>> @@ -7,3 +7,5 @@
>> *.time
>> .settings
>> .project
>> +reports
>> +dropit
> 
>


Re: svn commit: r765545 - in /ofbiz/trunk: ./ .classpath LICENSE applications/content/lib/poi-3.2-FINAL-20081019.jar applications/content/lib/poi.jar applications/product/src/org/ofbiz/product/spreadsheetimport/ImportProductServices.java

Posted by Jacopo Cappellato <ja...@hotwaxmedia.com>.
Hi Jacques,

I think that a part of this commit was unintentional.

Jacopo

On Apr 16, 2009, at 11:49 AM, jleroux@apache.org wrote:

> Propchange: ofbiz/trunk/
> ------------------------------------------------------------------------------
> --- svn:ignore (original)
> +++ svn:ignore Thu Apr 16 09:49:52 2009
> @@ -7,3 +7,5 @@
> *.time
> .settings
> .project
> +reports
> +dropit