You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "Michael Bieniosek (JIRA)" <ji...@apache.org> on 2008/08/28 19:26:47 UTC

[jira] Created: (HBASE-850) bin/hbase should check `which java` to find java

bin/hbase should check `which java` to find java
------------------------------------------------

                 Key: HBASE-850
                 URL: https://issues.apache.org/jira/browse/HBASE-850
             Project: Hadoop HBase
          Issue Type: Bug
          Components: scripts
            Reporter: Michael Bieniosek
            Priority: Minor


Currently, the bin/hbase script tries to find java in JAVA_HOME/bin/java. If the bin/hbase script isn't there, it errors out.

Instead, I think it should check `which java 2>/dev/null` to see if there is a java on the user's PATH. If a java is on the user's path, the script should just set JAVA=java.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-850) bin/hbase should check `which java` to find java

Posted by "Michael Bieniosek (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Bieniosek updated HBASE-850:
------------------------------------

    Description: 
Currently, the bin/hbase script tries to find java in JAVA_HOME/bin/java. If JAVA_HOME isn't set, it errors out.

Instead, I think it should check `which java 2>/dev/null` to see if there is a java on the user's PATH. If a java is on the user's path, the script should just set JAVA=java.

  was:
Currently, the bin/hbase script tries to find java in JAVA_HOME/bin/java. If the bin/hbase script isn't there, it errors out.

Instead, I think it should check `which java 2>/dev/null` to see if there is a java on the user's PATH. If a java is on the user's path, the script should just set JAVA=java.


> bin/hbase should check `which java` to find java
> ------------------------------------------------
>
>                 Key: HBASE-850
>                 URL: https://issues.apache.org/jira/browse/HBASE-850
>             Project: Hadoop HBase
>          Issue Type: Bug
>          Components: scripts
>            Reporter: Michael Bieniosek
>            Priority: Minor
>
> Currently, the bin/hbase script tries to find java in JAVA_HOME/bin/java. If JAVA_HOME isn't set, it errors out.
> Instead, I think it should check `which java 2>/dev/null` to see if there is a java on the user's PATH. If a java is on the user's path, the script should just set JAVA=java.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-850) bin/hbase should check `which java` to find java

Posted by "Izaak Rubin (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629587#action_12629587 ] 

Izaak Rubin commented on HBASE-850:
-----------------------------------

I think we're going to pass on this one.  the bin/hbase script first calls conf/hbase-env.sh, which should define JAVA_HOME.  JAVA_HOME really should be defined in conf/hbase-env.sh... it's one of the few strictly required configurations, so if it isn't defined there's a much bigger problem.

> bin/hbase should check `which java` to find java
> ------------------------------------------------
>
>                 Key: HBASE-850
>                 URL: https://issues.apache.org/jira/browse/HBASE-850
>             Project: Hadoop HBase
>          Issue Type: Bug
>          Components: scripts
>            Reporter: Michael Bieniosek
>            Priority: Minor
>
> Currently, the bin/hbase script tries to find java in JAVA_HOME/bin/java. If JAVA_HOME isn't set, it errors out.
> Instead, I think it should check `which java 2>/dev/null` to see if there is a java on the user's PATH. If a java is on the user's path, the script should just set JAVA=java.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-850) bin/hbase should check `which java` to find java

Posted by "Michael Bieniosek (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12715577#action_12715577 ] 

Michael Bieniosek commented on HBASE-850:
-----------------------------------------

> we need to be really careful here - on most Debian based distros, the standard /usr/bin/java is a highly obsolete, non-sun JDK that is 150% inappropriate for running HBase. 

That sounds like a different problem.  I have machines where /usr/bin/java is the correct Sun java to use.

> bin/hbase should check `which java` to find java
> ------------------------------------------------
>
>                 Key: HBASE-850
>                 URL: https://issues.apache.org/jira/browse/HBASE-850
>             Project: Hadoop HBase
>          Issue Type: Bug
>          Components: scripts
>            Reporter: Michael Bieniosek
>            Priority: Minor
>
> Currently, the bin/hbase script tries to find java in JAVA_HOME/bin/java. If JAVA_HOME isn't set, it errors out.
> Instead, I think it should check `which java 2>/dev/null` to see if there is a java on the user's PATH. If a java is on the user's path, the script should just set JAVA=java.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-850) bin/hbase should check `which java` to find java

Posted by "ryan rawson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12715302#action_12715302 ] 

ryan rawson commented on HBASE-850:
-----------------------------------

we need to be really careful here - on most Debian based distros, the standard /usr/bin/java is a highly obsolete, non-sun JDK that is 150% inappropriate for running HBase.

Falling back on a non-sun JVM is never going to be the right thing to do for a while. 

> bin/hbase should check `which java` to find java
> ------------------------------------------------
>
>                 Key: HBASE-850
>                 URL: https://issues.apache.org/jira/browse/HBASE-850
>             Project: Hadoop HBase
>          Issue Type: Bug
>          Components: scripts
>            Reporter: Michael Bieniosek
>            Priority: Minor
>
> Currently, the bin/hbase script tries to find java in JAVA_HOME/bin/java. If JAVA_HOME isn't set, it errors out.
> Instead, I think it should check `which java 2>/dev/null` to see if there is a java on the user's PATH. If a java is on the user's path, the script should just set JAVA=java.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-850) bin/hbase should check `which java` to find java

Posted by "Phil Hagelberg (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Phil Hagelberg updated HBASE-850:
---------------------------------

    Comment: was deleted

(was: Adding "export JAVA_HOME=`java-config -O`" to hbase-env.sh (if JAVA_HOME isn't set) should make this work out of the box with zero config, right? I don't see why manually setting JAVA_HOME is required; it's easily determined programatically.)

> bin/hbase should check `which java` to find java
> ------------------------------------------------
>
>                 Key: HBASE-850
>                 URL: https://issues.apache.org/jira/browse/HBASE-850
>             Project: Hadoop HBase
>          Issue Type: Bug
>          Components: scripts
>            Reporter: Michael Bieniosek
>            Priority: Minor
>
> Currently, the bin/hbase script tries to find java in JAVA_HOME/bin/java. If JAVA_HOME isn't set, it errors out.
> Instead, I think it should check `which java 2>/dev/null` to see if there is a java on the user's PATH. If a java is on the user's path, the script should just set JAVA=java.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-850) bin/hbase should check `which java` to find java

Posted by "Phil Hagelberg (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12715288#action_12715288 ] 

Phil Hagelberg commented on HBASE-850:
--------------------------------------

Adding "export JAVA_HOME=`java-config -O`" to hbase-env.sh (if JAVA_HOME isn't set) should make this work out of the box with zero config, right? I don't see why manually setting JAVA_HOME is required; it's easily determined programatically.

> bin/hbase should check `which java` to find java
> ------------------------------------------------
>
>                 Key: HBASE-850
>                 URL: https://issues.apache.org/jira/browse/HBASE-850
>             Project: Hadoop HBase
>          Issue Type: Bug
>          Components: scripts
>            Reporter: Michael Bieniosek
>            Priority: Minor
>
> Currently, the bin/hbase script tries to find java in JAVA_HOME/bin/java. If JAVA_HOME isn't set, it errors out.
> Instead, I think it should check `which java 2>/dev/null` to see if there is a java on the user's PATH. If a java is on the user's path, the script should just set JAVA=java.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (HBASE-850) bin/hbase should check `which java` to find java

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack resolved HBASE-850.
-------------------------

    Resolution: Fixed

Addressed by HBASE-2074.

> bin/hbase should check `which java` to find java
> ------------------------------------------------
>
>                 Key: HBASE-850
>                 URL: https://issues.apache.org/jira/browse/HBASE-850
>             Project: Hadoop HBase
>          Issue Type: Bug
>          Components: scripts
>            Reporter: Michael Bieniosek
>            Priority: Minor
>
> Currently, the bin/hbase script tries to find java in JAVA_HOME/bin/java. If JAVA_HOME isn't set, it errors out.
> Instead, I think it should check `which java 2>/dev/null` to see if there is a java on the user's PATH. If a java is on the user's path, the script should just set JAVA=java.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.