You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/03/28 08:54:18 UTC

[GitHub] [flink] zoucao commented on a change in pull request #15267: [Flink-21738][table]use cache in module to reduce unnecessary method calls

zoucao commented on a change in pull request #15267:
URL: https://github.com/apache/flink/pull/15267#discussion_r602852156



##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/module/CoreModule.java
##########
@@ -29,19 +32,28 @@
 /** Module of default core metadata in Flink. */
 public class CoreModule implements Module {
     public static final CoreModule INSTANCE = new CoreModule();
+    private List<BuiltInFunctionDefinition> builtInFunctionDefinitions;

Review comment:
       Thanks for your review，I have revised the above two.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org