You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/14 08:07:18 UTC
[GitHub] [arrow] kou opened a new pull request, #14412: ARROW-18048: [Dev][Archery][Crossbow] Comment bot waits for a while before generate a report
kou opened a new pull request, #14412:
URL: https://github.com/apache/arrow/pull/14412
If we generate a report immediately after we submit CI tasks, the generated report doesn't have suitable task CI task URL. Because CI tasks aren't started. We need to wait for a while before we generate a report to collect suitable CI task URLs.
Before:
https://github.com/apache/arrow/pull/14409#issuecomment-1278396923
https://github.com/ursacomputing/crossbow/tree/actions-1e49219a52-github-r-binary-packages is used.
After:
https://github.com/apache/arrow/pull/14409#issuecomment-1278625825
https://github.com/ursacomputing/crossbow/actions/runs/3248297802/jobs/5329340988 is used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou merged pull request #14412: ARROW-18048: [Dev][Archery][Crossbow] Comment bot waits for a while before generate a report
Posted by GitBox <gi...@apache.org>.
kou merged PR #14412:
URL: https://github.com/apache/arrow/pull/14412
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] raulcd commented on a diff in pull request #14412: ARROW-18048: [Dev][Archery][Crossbow] Comment bot waits for a while before generate a report
Posted by GitBox <gi...@apache.org>.
raulcd commented on code in PR #14412:
URL: https://github.com/apache/arrow/pull/14412#discussion_r996357372
##########
dev/archery/archery/bot.py:
##########
@@ -269,6 +272,10 @@ def submit(obj, tasks, groups, params, arrow_version):
queue.put(job, prefix="actions", increment_job_id=False)
queue.push()
+ # # wait for tasks of the job are triggered to collect more
+ # # suitable task URLs
+ time.sleep(wait)
Review Comment:
you are correct, sorry about that, we probably should only wait if there are no links to the individual task. In that case I would expect the links to be available and the wait to be only for the first one:
```
if not task.status().build_links and self._wait_for_task:
time.sleep(self.__wait_for_task)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #14412: ARROW-18048: [Dev][Archery][Crossbow] Comment bot waits for a while before generate a report
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #14412:
URL: https://github.com/apache/arrow/pull/14412#issuecomment-1279870077
Benchmark runs are scheduled for baseline = fc01a9c3e11822fc3661ee440ca6f4a5e32a7f42 and contender = d1a8f4ba19f6dcb2ddbd5fb50a88d37b17c39cea. d1a8f4ba19f6dcb2ddbd5fb50a88d37b17c39cea is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/ff7628f0bd1449969963be15ace89b18...ca118f2b462146e08fe57fb13eb7a363/)
[Failed :arrow_down:0.0% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/226a3671697d40149f345519ab41907b...24feaadd869341ee9387e6bead832f6d/)
[Failed :arrow_down:0.27% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/647de01e0d9e41ecb226e3187904169a...be64611253a549d098e5e1c7f373f092/)
[Finished :arrow_down:0.04% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/d7366903e3dd4654b8c8ac8059add777...cd8f2b99553c4bea8bbb640a8796450d/)
Buildkite builds:
[Finished] [`d1a8f4ba` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1703)
[Failed] [`d1a8f4ba` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1722)
[Failed] [`d1a8f4ba` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1705)
[Finished] [`d1a8f4ba` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1716)
[Finished] [`fc01a9c3` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1702)
[Failed] [`fc01a9c3` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1721)
[Failed] [`fc01a9c3` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1704)
[Finished] [`fc01a9c3` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1715)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] raulcd commented on a diff in pull request #14412: ARROW-18048: [Dev][Archery][Crossbow] Comment bot waits for a while before generate a report
Posted by GitBox <gi...@apache.org>.
raulcd commented on code in PR #14412:
URL: https://github.com/apache/arrow/pull/14412#discussion_r995567721
##########
dev/archery/archery/bot.py:
##########
@@ -269,6 +272,10 @@ def submit(obj, tasks, groups, params, arrow_version):
queue.put(job, prefix="actions", increment_job_id=False)
queue.push()
+ # # wait for tasks of the job are triggered to collect more
+ # # suitable task URLs
+ time.sleep(wait)
Review Comment:
I am ok with the heuristic implementation but I think I would prefer this to be implemented inside the `CommentReport` and the `task_url` itself as I can see us requiring to wait for the job to trigger on other places. I had something like this patch in mind:
```
diff --git a/dev/archery/archery/bot.py b/dev/archery/archery/bot.py
index c548e9a..8b02dc7 100644
--- a/dev/archery/archery/bot.py
+++ b/dev/archery/archery/bot.py
@@ -270,7 +270,7 @@ def submit(obj, tasks, groups, params, arrow_version):
queue.push()
# render the response comment's content
- report = CommentReport(job, crossbow_repo=crossbow_repo)
+ report = CommentReport(job, crossbow_repo=crossbow_repo, wait_for_task=wait)
# send the response
pull_request.create_issue_comment(report.show())
diff --git a/dev/archery/archery/crossbow/reports.py b/dev/archery/archery/crossbow/reports.py
index a3958d8..d887574 100644
--- a/dev/archery/archery/crossbow/reports.py
+++ b/dev/archery/archery/crossbow/reports.py
@@ -20,6 +20,7 @@ import csv
import operator
import fnmatch
import functools
+import time
import click
import requests
@@ -41,7 +42,7 @@ class Report:
"arrow_commit",
]
- def __init__(self, job, task_filters=None):
+ def __init__(self, job, task_filters=None, wait_for_task=None):
self.job = job
tasks = sorted(job.tasks.items())
@@ -53,6 +54,7 @@ class Report:
tasks = [(name, task) for name, task in tasks if name in filtered]
self._tasks = dict(tasks)
+ self._wait_for_task = wait_for_task
@property
def repo_url(self):
@@ -66,6 +68,8 @@ class Report:
return '{}/tree/{}'.format(self.repo_url, branch)
def task_url(self, task):
+ if self._wait_for_task:
+ time.wait(self._wait_for_task)
if task.status().build_links:
# show link to the actual build, some CI providers implement
# the statuses API others implement the checks API, retrieve any.
```
what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a diff in pull request #14412: ARROW-18048: [Dev][Archery][Crossbow] Comment bot waits for a while before generate a report
Posted by GitBox <gi...@apache.org>.
kou commented on code in PR #14412:
URL: https://github.com/apache/arrow/pull/14412#discussion_r995717001
##########
dev/archery/archery/bot.py:
##########
@@ -269,6 +272,10 @@ def submit(obj, tasks, groups, params, arrow_version):
queue.put(job, prefix="actions", increment_job_id=False)
queue.push()
+ # # wait for tasks of the job are triggered to collect more
+ # # suitable task URLs
+ time.sleep(wait)
Review Comment:
OK. I changed to use the approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #14412: ARROW-18048: [Dev][Archery][Crossbow] Comment bot waits for a while before generate a report
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14412:
URL: https://github.com/apache/arrow/pull/14412#issuecomment-1278643346
:warning: Ticket **has not been started in JIRA**, please click 'Start Progress'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a diff in pull request #14412: ARROW-18048: [Dev][Archery][Crossbow] Comment bot waits for a while before generate a report
Posted by GitBox <gi...@apache.org>.
kou commented on code in PR #14412:
URL: https://github.com/apache/arrow/pull/14412#discussion_r996357975
##########
dev/archery/archery/bot.py:
##########
@@ -269,6 +272,10 @@ def submit(obj, tasks, groups, params, arrow_version):
queue.put(job, prefix="actions", increment_job_id=False)
queue.push()
+ # # wait for tasks of the job are triggered to collect more
+ # # suitable task URLs
+ time.sleep(wait)
Review Comment:
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a diff in pull request #14412: ARROW-18048: [Dev][Archery][Crossbow] Comment bot waits for a while before generate a report
Posted by GitBox <gi...@apache.org>.
kou commented on code in PR #14412:
URL: https://github.com/apache/arrow/pull/14412#discussion_r996356187
##########
dev/archery/archery/bot.py:
##########
@@ -269,6 +272,10 @@ def submit(obj, tasks, groups, params, arrow_version):
queue.put(job, prefix="actions", increment_job_id=False)
queue.push()
+ # # wait for tasks of the job are triggered to collect more
+ # # suitable task URLs
+ time.sleep(wait)
Review Comment:
Hmm... It seems that the approach may do N `wait` sleeps when we run N tasks. For example, `crossbow submit -g wheel` will sleep 9 times.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] raulcd commented on a diff in pull request #14412: ARROW-18048: [Dev][Archery][Crossbow] Comment bot waits for a while before generate a report
Posted by GitBox <gi...@apache.org>.
raulcd commented on code in PR #14412:
URL: https://github.com/apache/arrow/pull/14412#discussion_r996357859
##########
dev/archery/archery/bot.py:
##########
@@ -269,6 +272,10 @@ def submit(obj, tasks, groups, params, arrow_version):
queue.put(job, prefix="actions", increment_job_id=False)
queue.push()
+ # # wait for tasks of the job are triggered to collect more
+ # # suitable task URLs
+ time.sleep(wait)
Review Comment:
sorry this won't work because if present it would be a string. I might take a look tomorrow if is still not solved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #14412: ARROW-18048: [Dev][Archery][Crossbow] Comment bot waits for a while before generate a report
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14412:
URL: https://github.com/apache/arrow/pull/14412#issuecomment-1278643296
https://issues.apache.org/jira/browse/ARROW-18048
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #14412: ARROW-18048: [Dev][Archery][Crossbow] Comment bot waits for a while before generate a report
Posted by GitBox <gi...@apache.org>.
kou commented on PR #14412:
URL: https://github.com/apache/arrow/pull/14412#issuecomment-1278643432
@raulcd What do you think about this (heuristic) approach?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org