You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Jason Rutherglen (JIRA)" <ji...@apache.org> on 2009/09/15 00:27:57 UTC
[jira] Created: (SOLR-1431) CommComponent abstracted
CommComponent abstracted
------------------------
Key: SOLR-1431
URL: https://issues.apache.org/jira/browse/SOLR-1431
Project: Solr
Issue Type: Improvement
Components: search
Affects Versions: 1.4
Reporter: Jason Rutherglen
Priority: Trivial
Fix For: 1.5
We'll abstract CommComponent in this issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-1431) CommComponent abstracted
Posted by "Jason Rutherglen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jason Rutherglen updated SOLR-1431:
-----------------------------------
Attachment: SOLR-1431.patch
* Changed the class names to the MultiShardHandler theme
* Added Apache license headers
> CommComponent abstracted
> ------------------------
>
> Key: SOLR-1431
> URL: https://issues.apache.org/jira/browse/SOLR-1431
> Project: Solr
> Issue Type: Improvement
> Components: search
> Affects Versions: 1.4
> Reporter: Jason Rutherglen
> Assignee: Noble Paul
> Priority: Trivial
> Fix For: 1.5
>
> Attachments: SOLR-1431.patch, SOLR-1431.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> We'll abstract CommComponent in this issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-1431) CommComponent abstracted
Posted by "Noble Paul (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Noble Paul updated SOLR-1431:
-----------------------------
Attachment: SOLR-1431.patch
> CommComponent abstracted
> ------------------------
>
> Key: SOLR-1431
> URL: https://issues.apache.org/jira/browse/SOLR-1431
> Project: Solr
> Issue Type: Improvement
> Components: search
> Affects Versions: 1.4
> Reporter: Jason Rutherglen
> Assignee: Noble Paul
> Priority: Trivial
> Fix For: 1.5
>
> Attachments: SOLR-1431.patch, SOLR-1431.patch, SOLR-1431.patch, SOLR-1431.patch, SOLR-1431.patch, SOLR-1431.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> We'll abstract CommComponent in this issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1431) CommComponent abstracted
Posted by "Noble Paul (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12782802#action_12782802 ]
Noble Paul commented on SOLR-1431:
----------------------------------
Still needs to eliminate the ResponseBuildr#shards field. We have no means of knowing the no:of of shards available in the prepare phase.The ShardHandler decides just in time the no:of shards available at any given point in time.
> CommComponent abstracted
> ------------------------
>
> Key: SOLR-1431
> URL: https://issues.apache.org/jira/browse/SOLR-1431
> Project: Solr
> Issue Type: Improvement
> Components: search
> Affects Versions: 1.4
> Reporter: Jason Rutherglen
> Assignee: Noble Paul
> Priority: Trivial
> Fix For: 1.5
>
> Attachments: SOLR-1431.patch, SOLR-1431.patch, SOLR-1431.patch, SOLR-1431.patch, SOLR-1431.patch, SOLR-1431.patch, SOLR-1431.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> We'll abstract CommComponent in this issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-1431) CommComponent abstracted
Posted by "Noble Paul (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Noble Paul updated SOLR-1431:
-----------------------------
Attachment: SOLR-1431.patch
> CommComponent abstracted
> ------------------------
>
> Key: SOLR-1431
> URL: https://issues.apache.org/jira/browse/SOLR-1431
> Project: Solr
> Issue Type: Improvement
> Components: search
> Affects Versions: 1.4
> Reporter: Jason Rutherglen
> Assignee: Noble Paul
> Priority: Trivial
> Fix For: 1.5
>
> Attachments: SOLR-1431.patch, SOLR-1431.patch, SOLR-1431.patch, SOLR-1431.patch, SOLR-1431.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> We'll abstract CommComponent in this issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (SOLR-1431) CommComponent abstracted
Posted by "Noble Paul (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12765474#action_12765474 ]
Noble Paul edited comment on SOLR-1431 at 10/14/09 5:21 AM:
------------------------------------------------------------
The MultiShardHandler interface should automatically handle the shards and the search handler should be agnostic of the shard names .
The MultiShardHandler interface can be simplified to this
{code:java}
public interface ShardHandler {
public List<Callable<ShardResponse>> submit(ShardRequest sreq, ModifiableSolrParams params);
}
{code}
was (Author: noble.paul):
The MultiShardHandler interface should automatically handle the shards and the search handler should be agnostic of the shard names .
The MultiShardHandler interface can be simplified to this
{code:java}
public interface MultiShardHandler {
public List<Future<ShardResponse>> submit(ShardRequest sreq, ModifiableSolrParams params);
}
{code}
> CommComponent abstracted
> ------------------------
>
> Key: SOLR-1431
> URL: https://issues.apache.org/jira/browse/SOLR-1431
> Project: Solr
> Issue Type: Improvement
> Components: search
> Affects Versions: 1.4
> Reporter: Jason Rutherglen
> Assignee: Noble Paul
> Priority: Trivial
> Fix For: 1.5
>
> Attachments: SOLR-1431.patch, SOLR-1431.patch, SOLR-1431.patch, SOLR-1431.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> We'll abstract CommComponent in this issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-1431) CommComponent abstracted
Posted by "Jason Rutherglen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jason Rutherglen updated SOLR-1431:
-----------------------------------
Attachment: SOLR-1431.patch
Same as the previous
> CommComponent abstracted
> ------------------------
>
> Key: SOLR-1431
> URL: https://issues.apache.org/jira/browse/SOLR-1431
> Project: Solr
> Issue Type: Improvement
> Components: search
> Affects Versions: 1.4
> Reporter: Jason Rutherglen
> Assignee: Noble Paul
> Priority: Trivial
> Fix For: 1.5
>
> Attachments: SOLR-1431.patch, SOLR-1431.patch, SOLR-1431.patch, SOLR-1431.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> We'll abstract CommComponent in this issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1431) CommComponent abstracted
Posted by "Noble Paul (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12765910#action_12765910 ]
Noble Paul commented on SOLR-1431:
----------------------------------
sample of setting up a new ShardHandler
{code:xml}
<requestHandler name="standard" class="solr.SearchHandler" default="true">
<!-- other params go here -->
<shardHandler class="HttpShardHandler">
<!-- To be implemented-->
<int name="httpReadTimeOut">1000</int>
<int name="httpConnTimeOut">5000</int>
</shardHandler>
</requestHandler>
{code}
> CommComponent abstracted
> ------------------------
>
> Key: SOLR-1431
> URL: https://issues.apache.org/jira/browse/SOLR-1431
> Project: Solr
> Issue Type: Improvement
> Components: search
> Affects Versions: 1.4
> Reporter: Jason Rutherglen
> Assignee: Noble Paul
> Priority: Trivial
> Fix For: 1.5
>
> Attachments: SOLR-1431.patch, SOLR-1431.patch, SOLR-1431.patch, SOLR-1431.patch, SOLR-1431.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> We'll abstract CommComponent in this issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-1431) CommComponent abstracted
Posted by "Jason Rutherglen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jason Rutherglen updated SOLR-1431:
-----------------------------------
Attachment: SOLR-1431.patch
All tests pass (except the unrelated DirectUpdateHandlerTest)
> CommComponent abstracted
> ------------------------
>
> Key: SOLR-1431
> URL: https://issues.apache.org/jira/browse/SOLR-1431
> Project: Solr
> Issue Type: Improvement
> Components: search
> Affects Versions: 1.4
> Reporter: Jason Rutherglen
> Priority: Trivial
> Fix For: 1.5
>
> Attachments: SOLR-1431.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> We'll abstract CommComponent in this issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1431) CommComponent abstracted
Posted by "Jason Rutherglen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12755343#action_12755343 ]
Jason Rutherglen commented on SOLR-1431:
----------------------------------------
Well, it's not always used in distributed mode (see MultiEmbeddedSearchHandler where we're querying multiple local cores), so DistributedCommComponent wouldn't work either. Maybe MultiShardHandler?
> CommComponent abstracted
> ------------------------
>
> Key: SOLR-1431
> URL: https://issues.apache.org/jira/browse/SOLR-1431
> Project: Solr
> Issue Type: Improvement
> Components: search
> Affects Versions: 1.4
> Reporter: Jason Rutherglen
> Assignee: Noble Paul
> Priority: Trivial
> Fix For: 1.5
>
> Attachments: SOLR-1431.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> We'll abstract CommComponent in this issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1431) CommComponent abstracted
Posted by "Noble Paul (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12765474#action_12765474 ]
Noble Paul commented on SOLR-1431:
----------------------------------
The MultiShardHandler interface should automatically handle the shards and the search handler should be agnostic of the shard names .
The MultiShardHandler interface can be simplified to this
{code:java}
public interface MultiShardHandler {
public List<Future<ShardResponse>> submit(ShardRequest sreq, ModifiableSolrParams params);
}
{code}
> CommComponent abstracted
> ------------------------
>
> Key: SOLR-1431
> URL: https://issues.apache.org/jira/browse/SOLR-1431
> Project: Solr
> Issue Type: Improvement
> Components: search
> Affects Versions: 1.4
> Reporter: Jason Rutherglen
> Assignee: Noble Paul
> Priority: Trivial
> Fix For: 1.5
>
> Attachments: SOLR-1431.patch, SOLR-1431.patch, SOLR-1431.patch, SOLR-1431.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> We'll abstract CommComponent in this issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1431) CommComponent abstracted
Posted by "Noble Paul (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12755862#action_12755862 ]
Noble Paul commented on SOLR-1431:
----------------------------------
should we have a separate plugin in solrconfig.xml like
{code:xml}
<shardHandler class="ZkHadoopRpcHandler" name="zk">
<str name="zkServer">http://foo</str>
</shardHandler>
{code}
and in the SearchHandler configuration it may have a reference to this
{code}
<str name="shardHandler">zk</str>
{code}
This will help the Handler to have its own configuration
> CommComponent abstracted
> ------------------------
>
> Key: SOLR-1431
> URL: https://issues.apache.org/jira/browse/SOLR-1431
> Project: Solr
> Issue Type: Improvement
> Components: search
> Affects Versions: 1.4
> Reporter: Jason Rutherglen
> Assignee: Noble Paul
> Priority: Trivial
> Fix For: 1.5
>
> Attachments: SOLR-1431.patch, SOLR-1431.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> We'll abstract CommComponent in this issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1431) CommComponent abstracted
Posted by "Noble Paul (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12755330#action_12755330 ]
Noble Paul commented on SOLR-1431:
----------------------------------
is it the best name ?. It somehow does not suggest that it is used for distributed search .
> CommComponent abstracted
> ------------------------
>
> Key: SOLR-1431
> URL: https://issues.apache.org/jira/browse/SOLR-1431
> Project: Solr
> Issue Type: Improvement
> Components: search
> Affects Versions: 1.4
> Reporter: Jason Rutherglen
> Assignee: Noble Paul
> Priority: Trivial
> Fix For: 1.5
>
> Attachments: SOLR-1431.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> We'll abstract CommComponent in this issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-1431) CommComponent abstracted
Posted by "Noble Paul (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Noble Paul updated SOLR-1431:
-----------------------------
Attachment: SOLR-1431.patch
Search component is agnostic of the actual shards now. Some more work to be done to remove dependency on the ResponseBuilder#shards field by components.
> CommComponent abstracted
> ------------------------
>
> Key: SOLR-1431
> URL: https://issues.apache.org/jira/browse/SOLR-1431
> Project: Solr
> Issue Type: Improvement
> Components: search
> Affects Versions: 1.4
> Reporter: Jason Rutherglen
> Assignee: Noble Paul
> Priority: Trivial
> Fix For: 1.5
>
> Attachments: SOLR-1431.patch, SOLR-1431.patch, SOLR-1431.patch, SOLR-1431.patch, SOLR-1431.patch, SOLR-1431.patch, SOLR-1431.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> We'll abstract CommComponent in this issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-1431) CommComponent abstracted
Posted by "Jason Rutherglen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jason Rutherglen updated SOLR-1431:
-----------------------------------
Attachment: SOLR-1431.patch
Changed SearchHandler.getCommComponent to getMultiSearchHandler
> CommComponent abstracted
> ------------------------
>
> Key: SOLR-1431
> URL: https://issues.apache.org/jira/browse/SOLR-1431
> Project: Solr
> Issue Type: Improvement
> Components: search
> Affects Versions: 1.4
> Reporter: Jason Rutherglen
> Assignee: Noble Paul
> Priority: Trivial
> Fix For: 1.5
>
> Attachments: SOLR-1431.patch, SOLR-1431.patch, SOLR-1431.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> We'll abstract CommComponent in this issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (SOLR-1431) CommComponent abstracted
Posted by "Noble Paul (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Noble Paul reassigned SOLR-1431:
--------------------------------
Assignee: Noble Paul
> CommComponent abstracted
> ------------------------
>
> Key: SOLR-1431
> URL: https://issues.apache.org/jira/browse/SOLR-1431
> Project: Solr
> Issue Type: Improvement
> Components: search
> Affects Versions: 1.4
> Reporter: Jason Rutherglen
> Assignee: Noble Paul
> Priority: Trivial
> Fix For: 1.5
>
> Attachments: SOLR-1431.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> We'll abstract CommComponent in this issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.