You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "franz1981 (via GitHub)" <gi...@apache.org> on 2025/02/11 16:04:47 UTC
[PR] Close the Jackson Generator to save buffer leaks [avro]
franz1981 opened a new pull request, #3310:
URL: https://github.com/apache/avro/pull/3310
Since https://github.com/FasterXML/jackson-core/issues/919 jackson now requires to close its `JsonGenerator` to save buffer leaks - and eventually cause further big allocations due to not be able to reuse the existing one.
This can be saved by correctly closing the used `JsonGenerator`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Close the Jackson Generator to save buffer leaks [avro]
Posted by "franz1981 (via GitHub)" <gi...@apache.org>.
franz1981 commented on PR #3310:
URL: https://github.com/apache/avro/pull/3310#issuecomment-2685646703
Thanks both folks and let me know if you need the follow up others suggested by @MichalFoksa
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Close the Jackson Generator to save buffer leaks [avro]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko merged PR #3310:
URL: https://github.com/apache/avro/pull/3310
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Close the Jackson Generator to save buffer leaks [avro]
Posted by "franz1981 (via GitHub)" <gi...@apache.org>.
franz1981 commented on PR #3310:
URL: https://github.com/apache/avro/pull/3310#issuecomment-2660438765
Just for reference, this change is saving to allocate a fresh new 4K sized char[] buffer each time, see https://github.com/FasterXML/jackson-core/blob/bef7d7a199a99f881732758199d8e6d0349bdb28/src/main/java/com/fasterxml/jackson/core/util/BufferRecycler.java#L96
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Close the Jackson Generator to save buffer leaks [avro]
Posted by "franz1981 (via GitHub)" <gi...@apache.org>.
franz1981 commented on PR #3310:
URL: https://github.com/apache/avro/pull/3310#issuecomment-2652188225
@belugabehr :pray:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Close the Jackson Generator to save buffer leaks [avro]
Posted by "franz1981 (via GitHub)" <gi...@apache.org>.
franz1981 commented on PR #3310:
URL: https://github.com/apache/avro/pull/3310#issuecomment-2654410357
IDK @martin-g if the failure is related to this change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Close the Jackson Generator to save buffer leaks [avro]
Posted by "franz1981 (via GitHub)" <gi...@apache.org>.
franz1981 commented on PR #3310:
URL: https://github.com/apache/avro/pull/3310#issuecomment-2685304707
do you know @MichalFoksa who I can ping for this?
as said, this is a severe performance issue which can be fixed with a one-liner...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Close the Jackson Generator to save buffer leaks [avro]
Posted by "MichalFoksa (via GitHub)" <gi...@apache.org>.
MichalFoksa commented on PR #3310:
URL: https://github.com/apache/avro/pull/3310#issuecomment-2685344052
Maybe @Fokko <https://github.com/Fokko> and @martin-g
<https://github.com/martin-g>
On Wed, 26 Feb 2025 at 15:53, Francesco Nigro ***@***.***>
wrote:
> do you know @MichalFoksa <https://github.com/MichalFoksa> who I can ping
> for this?
> as said, this is a severe performance issue which can be fixed with a
> one-liner...
>
> β
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/avro/pull/3310#issuecomment-2685304707>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ACNGENUKBIQ3DF5DM36P7D32RXIQBAVCNFSM6AAAAABW5NQIZGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOBVGMYDINZQG4>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
> [image: franz1981]*franz1981* left a comment (apache/avro#3310)
> <https://github.com/apache/avro/pull/3310#issuecomment-2685304707>
>
> do you know @MichalFoksa <https://github.com/MichalFoksa> who I can ping
> for this?
> as said, this is a severe performance issue which can be fixed with a
> one-liner...
>
> β
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/avro/pull/3310#issuecomment-2685304707>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ACNGENUKBIQ3DF5DM36P7D32RXIQBAVCNFSM6AAAAABW5NQIZGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOBVGMYDINZQG4>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Close the Jackson Generator to save buffer leaks [avro]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on PR #3310:
URL: https://github.com/apache/avro/pull/3310#issuecomment-2685635759
This is great @franz1981 thanks for making this change! And thanks @MichalFoksa for pinging me π
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Close the Jackson Generator to save buffer leaks [avro]
Posted by "franz1981 (via GitHub)" <gi...@apache.org>.
franz1981 commented on PR #3310:
URL: https://github.com/apache/avro/pull/3310#issuecomment-2656259976
Hi @jbonofre it's Franz (I was working Artemis years ago) sorry for the naked ping but this one is causing some performance degradation to our Quarkus and Apicurio users, can you take a look? π
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Close the Jackson Generator to save buffer leaks [avro]
Posted by "MichalFoksa (via GitHub)" <gi...@apache.org>.
MichalFoksa commented on PR #3310:
URL: https://github.com/apache/avro/pull/3310#issuecomment-2661042374
@franz1981
:( I can't help speed up your issue - I just happened to be the last committer to the main branch. I donβt have any "displacement" in this project.
However, I think closing JsonGenerator could also be useful in:
- org.apache.avro.Protocol#toString(boolean)
- org.apache.avro.Protocol.Message#toString
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Close the Jackson Generator to save buffer leaks [avro]
Posted by "franz1981 (via GitHub)" <gi...@apache.org>.
franz1981 commented on PR #3310:
URL: https://github.com/apache/avro/pull/3310#issuecomment-2660433856
@MichalFoksa there is anything I can do to help here, or anything I am missing? π
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org