You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Jeff Trawick <tr...@gmail.com> on 2012/12/18 14:29:21 UTC

Re: svn commit: r1423353 - in /httpd/httpd/trunk: docs/log-message-tags/next-number modules/proxy/mod_proxy_ftp.c

On Tue, Dec 18, 2012 at 4:01 AM, <jo...@apache.org> wrote:

> Author: jorton
> Date: Tue Dec 18 09:01:02 2012
> New Revision: 1423353
>
> URL: http://svn.apache.org/viewvc?rev=1423353&view=rev
> Log:
> * modules/proxy/mod_proxy_ftp.c: Fill in APLOGNO.
>
> Modified:
>     httpd/httpd/trunk/docs/log-message-tags/next-number
>     httpd/httpd/trunk/modules/proxy/mod_proxy_ftp.c
>
> Modified: httpd/httpd/trunk/docs/log-message-tags/next-number
> URL:
> http://svn.apache.org/viewvc/httpd/httpd/trunk/docs/log-message-tags/next-number?rev=1423353&r1=1423352&r2=1423353&view=diff
>
> ==============================================================================
> --- httpd/httpd/trunk/docs/log-message-tags/next-number (original)
> +++ httpd/httpd/trunk/docs/log-message-tags/next-number Tue Dec 18
> 09:01:02 2012
> @@ -1 +1 @@
> -2410
> +2411
>
> Modified: httpd/httpd/trunk/modules/proxy/mod_proxy_ftp.c
> URL:
> http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/proxy/mod_proxy_ftp.c?rev=1423353&r1=1423352&r2=1423353&view=diff
>
> ==============================================================================
> --- httpd/httpd/trunk/modules/proxy/mod_proxy_ftp.c (original)
> +++ httpd/httpd/trunk/modules/proxy/mod_proxy_ftp.c Tue Dec 18 09:01:02
> 2012
> @@ -1465,7 +1465,7 @@ static int proxy_ftp_handler(request_rec
>
>   "EPSV attempt to connect to %pI failed - firewall/NAT?", &epsv_addr));
>                  }
>                  else {
> -                    ap_log_rerror(APLOG_MARK, APLOG_TRACE1, 0, r,
> APLOGNO()
> +                    ap_log_rerror(APLOG_MARK, APLOG_TRACE1, 0, r,
> APLOGNO(02410)
>                                    "connected data socket to %pI",
> &epsv_addr);
>

My understanding is that we don't maintain messages numbers for TRACE
messages, so the APLOGNO() could have been simply deleted.

(I see several mod_lua messages that don't follow this pattern.)



>                      connect = 1;
>                  }
>
>
>


-- 
Born in Roswell... married an alien...
http://emptyhammock.com/

Re: svn commit: r1423353 - in /httpd/httpd/trunk: docs/log-message-tags/next-number modules/proxy/mod_proxy_ftp.c

Posted by Jeff Trawick <tr...@gmail.com>.
On Tue, Dec 18, 2012 at 10:54 AM, Joe Orton <jo...@redhat.com> wrote:

> On Tue, Dec 18, 2012 at 08:29:21AM -0500, Jeff Trawick wrote:
> > My understanding is that we don't maintain messages numbers for TRACE
> > messages, so the APLOGNO() could have been simply deleted.
> >
> > (I see several mod_lua messages that don't follow this pattern.)
>
> Ah, sorry, I didn't realise that.  ISTR the empty macro broke the build
> on some platform from last time I screwed that up, so we need to fix it
> either way?
>

yeah; I think the thing to do is to delete the APLOGNO() altogether from
the message


>
> Regards, Joe
>



-- 
Born in Roswell... married an alien...
http://emptyhammock.com/

Re: svn commit: r1423353 - in /httpd/httpd/trunk: docs/log-message-tags/next-number modules/proxy/mod_proxy_ftp.c

Posted by Joe Orton <jo...@redhat.com>.
On Tue, Dec 18, 2012 at 08:29:21AM -0500, Jeff Trawick wrote:
> My understanding is that we don't maintain messages numbers for TRACE
> messages, so the APLOGNO() could have been simply deleted.
> 
> (I see several mod_lua messages that don't follow this pattern.)

Ah, sorry, I didn't realise that.  ISTR the empty macro broke the build 
on some platform from last time I screwed that up, so we need to fix it 
either way?

Regards, Joe