You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/01/19 14:28:51 UTC

[GitHub] [flink] rkhachatryan opened a new pull request #18402: [FLINK-25678][runtime] Make TaskExecutorStateChangelogStoragesManager.shutdown thread-safe

rkhachatryan opened a new pull request #18402:
URL: https://github.com/apache/flink/pull/18402


   ## What is the purpose of the change
   
   The method is called from the shutdown hook and must be thread-safe.
   
   ## Verifying this change
   
   The change is relateively simple and related to concurrency so covering it doesn't seem worth the effort.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? no
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #18402: [FLINK-25678][runtime] Make TaskExecutorStateChangelogStoragesManager.shutdown thread-safe

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18402:
URL: https://github.com/apache/flink/pull/18402#issuecomment-1016522710


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8b2d331b346e6fac39327472caf6881612e33b01",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29718",
       "triggerID" : "8b2d331b346e6fac39327472caf6881612e33b01",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8b2d331b346e6fac39327472caf6881612e33b01 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29718) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #18402: [FLINK-25678][runtime] Make TaskExecutorStateChangelogStoragesManager.shutdown thread-safe

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18402:
URL: https://github.com/apache/flink/pull/18402#issuecomment-1016522710


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8b2d331b346e6fac39327472caf6881612e33b01",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29718",
       "triggerID" : "8b2d331b346e6fac39327472caf6881612e33b01",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b1c8b62f507402d3e3ea03f3d48100e8c9834c59",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "b1c8b62f507402d3e3ea03f3d48100e8c9834c59",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8b2d331b346e6fac39327472caf6881612e33b01 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29718) 
   * b1c8b62f507402d3e3ea03f3d48100e8c9834c59 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #18402: [FLINK-25678][runtime] Make TaskExecutorStateChangelogStoragesManager.shutdown thread-safe

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18402:
URL: https://github.com/apache/flink/pull/18402#issuecomment-1016525296


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 8b2d331b346e6fac39327472caf6881612e33b01 (Wed Jan 19 14:34:31 UTC 2022)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
    * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-25678).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #18402: [FLINK-25678][runtime] Make TaskExecutorStateChangelogStoragesManager.shutdown thread-safe

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18402:
URL: https://github.com/apache/flink/pull/18402#issuecomment-1016522710


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8b2d331b346e6fac39327472caf6881612e33b01",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29718",
       "triggerID" : "8b2d331b346e6fac39327472caf6881612e33b01",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8b2d331b346e6fac39327472caf6881612e33b01 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29718) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] rkhachatryan commented on pull request #18402: [FLINK-25678][runtime] Make TaskExecutorStateChangelogStoragesManager.shutdown thread-safe

Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on pull request #18402:
URL: https://github.com/apache/flink/pull/18402#issuecomment-1018260949


   Thanks for the reivew! I'll squash the commits and merge the PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] rkhachatryan merged pull request #18402: [FLINK-25678][runtime] Make TaskExecutorStateChangelogStoragesManager.shutdown thread-safe

Posted by GitBox <gi...@apache.org>.
rkhachatryan merged pull request #18402:
URL: https://github.com/apache/flink/pull/18402


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #18402: [FLINK-25678][runtime] Make TaskExecutorStateChangelogStoragesManager.shutdown thread-safe

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18402:
URL: https://github.com/apache/flink/pull/18402#issuecomment-1016522710


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8b2d331b346e6fac39327472caf6881612e33b01",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29718",
       "triggerID" : "8b2d331b346e6fac39327472caf6881612e33b01",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b1c8b62f507402d3e3ea03f3d48100e8c9834c59",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29781",
       "triggerID" : "b1c8b62f507402d3e3ea03f3d48100e8c9834c59",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8b2d331b346e6fac39327472caf6881612e33b01 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29718) 
   * b1c8b62f507402d3e3ea03f3d48100e8c9834c59 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29781) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #18402: [FLINK-25678][runtime] Make TaskExecutorStateChangelogStoragesManager.shutdown thread-safe

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18402:
URL: https://github.com/apache/flink/pull/18402#issuecomment-1016522710


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8b2d331b346e6fac39327472caf6881612e33b01",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29718",
       "triggerID" : "8b2d331b346e6fac39327472caf6881612e33b01",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b1c8b62f507402d3e3ea03f3d48100e8c9834c59",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29781",
       "triggerID" : "b1c8b62f507402d3e3ea03f3d48100e8c9834c59",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2d4e9be07b558eba3348aa1ef46d14cba4d3d46d",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29866",
       "triggerID" : "2d4e9be07b558eba3348aa1ef46d14cba4d3d46d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2d4e9be07b558eba3348aa1ef46d14cba4d3d46d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29866) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #18402: [FLINK-25678][runtime] Make TaskExecutorStateChangelogStoragesManager.shutdown thread-safe

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18402:
URL: https://github.com/apache/flink/pull/18402#issuecomment-1016522710


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8b2d331b346e6fac39327472caf6881612e33b01",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29718",
       "triggerID" : "8b2d331b346e6fac39327472caf6881612e33b01",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b1c8b62f507402d3e3ea03f3d48100e8c9834c59",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29781",
       "triggerID" : "b1c8b62f507402d3e3ea03f3d48100e8c9834c59",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * b1c8b62f507402d3e3ea03f3d48100e8c9834c59 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29781) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] Zakelly commented on pull request #18402: [FLINK-25678][runtime] Make TaskExecutorStateChangelogStoragesManager.shutdown thread-safe

Posted by GitBox <gi...@apache.org>.
Zakelly commented on pull request #18402:
URL: https://github.com/apache/flink/pull/18402#issuecomment-1017181880


   Thanks for the PR! Overall it looks good to me. Would you mind removing the "No thread-safe" from the java doc of this class? Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #18402: [FLINK-25678][runtime] Make TaskExecutorStateChangelogStoragesManager.shutdown thread-safe

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18402:
URL: https://github.com/apache/flink/pull/18402#issuecomment-1016522710


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8b2d331b346e6fac39327472caf6881612e33b01",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29718",
       "triggerID" : "8b2d331b346e6fac39327472caf6881612e33b01",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b1c8b62f507402d3e3ea03f3d48100e8c9834c59",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29781",
       "triggerID" : "b1c8b62f507402d3e3ea03f3d48100e8c9834c59",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2d4e9be07b558eba3348aa1ef46d14cba4d3d46d",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29866",
       "triggerID" : "2d4e9be07b558eba3348aa1ef46d14cba4d3d46d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * b1c8b62f507402d3e3ea03f3d48100e8c9834c59 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29781) 
   * 2d4e9be07b558eba3348aa1ef46d14cba4d3d46d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29866) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #18402: [FLINK-25678][runtime] Make TaskExecutorStateChangelogStoragesManager.shutdown thread-safe

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18402:
URL: https://github.com/apache/flink/pull/18402#issuecomment-1016522710


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8b2d331b346e6fac39327472caf6881612e33b01",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29718",
       "triggerID" : "8b2d331b346e6fac39327472caf6881612e33b01",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b1c8b62f507402d3e3ea03f3d48100e8c9834c59",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29781",
       "triggerID" : "b1c8b62f507402d3e3ea03f3d48100e8c9834c59",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2d4e9be07b558eba3348aa1ef46d14cba4d3d46d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "2d4e9be07b558eba3348aa1ef46d14cba4d3d46d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * b1c8b62f507402d3e3ea03f3d48100e8c9834c59 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29781) 
   * 2d4e9be07b558eba3348aa1ef46d14cba4d3d46d UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #18402: [FLINK-25678][runtime] Make TaskExecutorStateChangelogStoragesManager.shutdown thread-safe

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18402:
URL: https://github.com/apache/flink/pull/18402#issuecomment-1016522710


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8b2d331b346e6fac39327472caf6881612e33b01",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "8b2d331b346e6fac39327472caf6881612e33b01",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8b2d331b346e6fac39327472caf6881612e33b01 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org