[lucene-solr] branch branch_8x updated: SOLR-13492: perform explicit GC concurrently (#1370)

[mu...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

munendrasn pushed a commit to branch branch_8x
in repository https://gitbox.apache.org/repos/asf/lucene-solr.git


The following commit(s) were added to refs/heads/branch_8x by this push:
     new b674d50  SOLR-13492: perform explicit GC concurrently (#1370)
b674d50 is described below

commit b674d50ae3282641e8f29007b5a288349d8328f6
Author: Guna Sekhar Dora Kovvuru <gu...@gmail.com>
AuthorDate: Sun Jun 7 15:44:30 2020 +0530

    SOLR-13492: perform explicit GC concurrently (#1370)
---
 solr/CHANGES.txt     | 3 +++
 solr/bin/solr        | 3 ++-
 solr/bin/solr.cmd    | 3 ++-
 solr/bin/solr.in.cmd | 1 +
 solr/bin/solr.in.sh  | 1 +
 5 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/solr/CHANGES.txt b/solr/CHANGES.txt
index 13a8883..7ab2fd0 100644
--- a/solr/CHANGES.txt
+++ b/solr/CHANGES.txt
@@ -227,6 +227,9 @@ Other Changes
 
 * SOLR-14480: Fix or suppress warnings in solr/cloud/api (Erick Erickson)
 
+* SOLR-13492: Ensure explicit GCs are concurrent by adding '+ExplicitGCInvokesConcurrent'.
+  (Guna Sekhar Dora, Shawn Heisey, Munendra S N)
+
 ==================  8.5.2 ==================
 
 Consult the LUCENE_CHANGES.txt file for additional, low level, changes in this release.
diff --git a/solr/bin/solr b/solr/bin/solr
index 91c0144..3d09ccd 100755
--- a/solr/bin/solr
+++ b/solr/bin/solr
@@ -2136,7 +2136,8 @@ function start_solr() {
         '-XX:+ParallelRefProcEnabled' \
         '-XX:MaxGCPauseMillis=250' \
         '-XX:+UseLargePages' \
-        '-XX:+AlwaysPreTouch')
+        '-XX:+AlwaysPreTouch' \
+        '-XX:+ExplicitGCInvokesConcurrent')
   else
     GC_TUNE=($GC_TUNE)
   fi
diff --git a/solr/bin/solr.cmd b/solr/bin/solr.cmd
index 301806e..93950ab 100755
--- a/solr/bin/solr.cmd
+++ b/solr/bin/solr.cmd
@@ -1193,7 +1193,8 @@ IF "%GC_TUNE%"=="" (
     -XX:+ParallelRefProcEnabled ^
     -XX:MaxGCPauseMillis=250 ^
     -XX:+UseLargePages ^
-    -XX:+AlwaysPreTouch
+    -XX:+AlwaysPreTouch ^
+    -XX:+ExplicitGCInvokesConcurrent
 )
 
 if !JAVA_MAJOR_VERSION! GEQ 9  (
diff --git a/solr/bin/solr.in.cmd b/solr/bin/solr.in.cmd
index 9ff422f..1a40c62 100755
--- a/solr/bin/solr.in.cmd
+++ b/solr/bin/solr.in.cmd
@@ -34,6 +34,7 @@ REM set GC_LOG_OPTS=-verbose:gc -XX:+PrintHeapAtGC -XX:+PrintGCDetails -XX:+Prin
 
 REM Various GC settings have shown to work well for a number of common Solr workloads.
 REM See solr.cmd GC_TUNE for the default list.
+REM set GC_TUNE=-XX:+ExplicitGCInvokesConcurrent
 REM set GC_TUNE=-XX:SurvivorRatio=4
 REM set GC_TUNE=%GC_TUNE% -XX:TargetSurvivorRatio=90
 REM set GC_TUNE=%GC_TUNE% -XX:MaxTenuringThreshold=8
diff --git a/solr/bin/solr.in.sh b/solr/bin/solr.in.sh
index d5f8d7c..6160eaa 100644
--- a/solr/bin/solr.in.sh
+++ b/solr/bin/solr.in.sh
@@ -47,6 +47,7 @@
 
 # These GC settings have shown to work well for a number of common Solr workloads
 #GC_TUNE=" \
+#-XX:+ExplicitGCInvokesConcurrent \
 #-XX:SurvivorRatio=4 \
 #-XX:TargetSurvivorRatio=90 \
 #-XX:MaxTenuringThreshold=8 \