You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/02/22 00:25:21 UTC

[GitHub] [kafka] jsancio commented on a change in pull request #10157: MINOR: Raft request thread should discover api versions

jsancio commented on a change in pull request #10157:
URL: https://github.com/apache/kafka/pull/10157#discussion_r579892241



##########
File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java
##########
@@ -2244,7 +2244,6 @@ private Long append(int epoch, List<T> records, boolean isAtomic) {
 
     @Override
     public void close() {
-        log.close();

Review comment:
       The remove was done here: https://github.com/apache/kafka/pull/10168
   
   Both the `RaftManager` and `KafkaRaftClient` where closing the `ReplicatedLog`. It was decided that the `RaftManager` owns the log and should close it instead of the `KafkaRaftClient`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org