You are viewing a plain text version of this content. The canonical link for it is here.
Posted to scm@geronimo.apache.org by va...@apache.org on 2007/10/31 22:13:58 UTC
svn commit: r590833 - in /geronimo/server:
branches/2.0/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/
trunk/framework/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/
trunk/mo...
Author: vamsic007
Date: Wed Oct 31 14:13:57 2007
New Revision: 590833
URL: http://svn.apache.org/viewvc?rev=590833&view=rev
Log:
Remove redundant code. The catch block handles this part.
Modified:
geronimo/server/branches/2.0/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/LDAPLoginModule.java
geronimo/server/trunk/framework/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/LDAPLoginModule.java
geronimo/server/trunk/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/LDAPLoginModule.java
Modified: geronimo/server/branches/2.0/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/LDAPLoginModule.java
URL: http://svn.apache.org/viewvc/geronimo/server/branches/2.0/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/LDAPLoginModule.java?rev=590833&r1=590832&r2=590833&view=diff
==============================================================================
--- geronimo/server/branches/2.0/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/LDAPLoginModule.java (original)
+++ geronimo/server/branches/2.0/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/LDAPLoginModule.java Wed Oct 31 14:13:57 2007
@@ -177,10 +177,6 @@
try {
boolean result = authenticate(cbUsername, cbPassword);
if (!result) {
- // Clear out the private state
- cbUsername = null;
- cbPassword = null;
- groups.retainAll(Collections.EMPTY_SET);
throw new FailedLoginException();
}
} catch (LoginException e) {
Modified: geronimo/server/trunk/framework/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/LDAPLoginModule.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/framework/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/LDAPLoginModule.java?rev=590833&r1=590832&r2=590833&view=diff
==============================================================================
--- geronimo/server/trunk/framework/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/LDAPLoginModule.java (original)
+++ geronimo/server/trunk/framework/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/LDAPLoginModule.java Wed Oct 31 14:13:57 2007
@@ -177,10 +177,6 @@
try {
boolean result = authenticate(cbUsername, cbPassword);
if (!result) {
- // Clear out the private state
- cbUsername = null;
- cbPassword = null;
- groups.retainAll(Collections.EMPTY_SET);
throw new FailedLoginException();
}
} catch (LoginException e) {
Modified: geronimo/server/trunk/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/LDAPLoginModule.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/LDAPLoginModule.java?rev=590833&r1=590832&r2=590833&view=diff
==============================================================================
--- geronimo/server/trunk/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/LDAPLoginModule.java (original)
+++ geronimo/server/trunk/modules/geronimo-security/src/main/java/org/apache/geronimo/security/realm/providers/LDAPLoginModule.java Wed Oct 31 14:13:57 2007
@@ -177,10 +177,6 @@
try {
boolean result = authenticate(cbUsername, cbPassword);
if (!result) {
- // Clear out the private state
- cbUsername = null;
- cbPassword = null;
- groups.retainAll(Collections.EMPTY_SET);
throw new FailedLoginException();
}
} catch (LoginException e) {