You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "pitrou (via GitHub)" <gi...@apache.org> on 2023/07/06 16:18:06 UTC

[GitHub] [arrow] pitrou opened a new pull request, #36507: MINOR: [CI][C++] Re-enable optimizations in Valgrind build

pitrou opened a new pull request, #36507:
URL: https://github.com/apache/arrow/pull/36507

   ARROW_CXXFLAGS does not take priority anymore, need to pass optimization flags differently.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] github-actions[bot] commented on pull request #36507: MINOR: [CI][C++] Re-enable optimizations in Valgrind build

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36507:
URL: https://github.com/apache/arrow/pull/36507#issuecomment-1623961870

   Revision: 118d144a6beb56deb04645f15d18d32330091889
   
   Submitted crossbow builds: [ursacomputing/crossbow @ actions-02d9889ad2](https://github.com/ursacomputing/crossbow/branches/all?query=actions-02d9889ad2)
   
   |Task|Status|
   |----|------|
   |test-conda-cpp-valgrind|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-02d9889ad2-azure-test-conda-cpp-valgrind)](https://github.com/ursacomputing/crossbow/runs/14833539388)|


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] pitrou commented on pull request #36507: MINOR: [CI][C++] Re-enable optimizations in Valgrind build

Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #36507:
URL: https://github.com/apache/arrow/pull/36507#issuecomment-1623958076

   @github-actions crossbow submit *cpp*valgrind*


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] conbench-apache-arrow[bot] commented on pull request #36507: MINOR: [CI][C++] Re-enable optimizations in Valgrind build

Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #36507:
URL: https://github.com/apache/arrow/pull/36507#issuecomment-1634654752

   Conbench analyzed the 6 benchmark runs on commit `f522bc62`.
   
   There were 5 benchmark results indicating a performance regression:
   
   - Commit Run on `ursa-thinkcentre-m75q` at [2023-07-10 17:06:32Z](http://conbench.ursa.dev/compare/runs/2f2ca65578244365838126bfa90d2c20...7cc74fd64f874925b44803e2ade3f0a6/)
     - [params=4096, source=cpp-micro, suite=parquet-encoding-benchmark](http://conbench.ursa.dev/compare/benchmarks/064ac1217f9f70328000e6043414fff7...064ac3b19d1a75098000237e9c371a8c)
     - [params=<MonthDayNanoBetween, time64_type>/524288/0, source=cpp-micro, suite=arrow-compute-scalar-temporal-benchmark](http://conbench.ursa.dev/compare/benchmarks/064ac124e6c77b598000aa36d02ae0c4...064ac3b4b0aa7ced80003e5227ce8950)
   - and 3 more (see the report linked below)
   
   The [full Conbench report](https://github.com/apache/arrow/runs/15022935664) has more details.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] kou merged pull request #36507: MINOR: [CI][C++] Re-enable optimizations in Valgrind build

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #36507:
URL: https://github.com/apache/arrow/pull/36507


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] pitrou commented on pull request #36507: MINOR: [CI][C++] Re-enable optimizations in Valgrind build

Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #36507:
URL: https://github.com/apache/arrow/pull/36507#issuecomment-1624019049

   @felipecrv FYI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] pitrou commented on pull request #36507: MINOR: [CI][C++] Re-enable optimizations in Valgrind build

Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #36507:
URL: https://github.com/apache/arrow/pull/36507#issuecomment-1624018728

   [Previous build](https://dev.azure.com/ursacomputing/crossbow/_build/results?buildId=50764&view=logs&j=0da5d1d9-276d-5173-c4c4-9d4d4ed14fdb&t=d9b15392-e4ce-5e4c-0c8c-b69645229181): 1 h 17 min
   [This build](https://dev.azure.com/ursacomputing/crossbow/_build/results?buildId=50802&view=logs&j=0da5d1d9-276d-5173-c4c4-9d4d4ed14fdb&t=d9b15392-e4ce-5e4c-0c8c-b69645229181): 42 min


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org