[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #3201: ARTEMIS-2820 Undeploy diverts by removing them from broker.xml

[GitBox <gi...@apache.org>]

clebertsuconic commented on a change in pull request #3201:
URL: https://github.com/apache/activemq-artemis/pull/3201#discussion_r447989516



##########
File path: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/RedeployTest.java
##########
@@ -448,6 +450,63 @@ public void testRedeployQueueDefaults() throws Exception {
       }
    }
 
+   @Test
+   public void testUndeployDivert() throws Exception {

Review comment:
       @michaelpearce-gain  / @jsmucr any chance you can look at why this test is failing?
   
   if you run it as part of the test suite (mvn -Ptests test) it breaks most of the time.
   
   And this is blocking me from releasing.
   
   
   Another point is the clash of the user redeployment as it's clashing with a previous definition.. see my PR.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org