You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@daffodil.apache.org by "Michael Beckerle (JIRA)" <ji...@apache.org> on 2018/02/12 23:56:00 UTC
[jira] [Commented] (DAFFODIL-1900) Test files should include
licenses, TDMLRunner should strip before tests
[ https://issues.apache.org/jira/browse/DAFFODIL-1900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16361611#comment-16361611 ]
Michael Beckerle commented on DAFFODIL-1900:
--------------------------------------------
I have no issue with adding Apache license headers to XML input and output data. XML Comments are fine for this.
The TDML runner I believe strips comments when comparing, and if not it can easily be made to do so.
But we cannot mess with "native format" data files. That wouldn't fly with me or any Daffodil user.
The TDML runner already has the pre-processing feature needed to cover all test data with Apache license banners. We just represent the data inside the TDML using <documentPart type="bytes">....big hex string here </documentPart>, then the apache banner at the top of the TDML covers everything.
If there are any data files too big for that, then we really should take them out of the primary source tree anyway.
> Test files should include licenses, TDMLRunner should strip before tests
> ------------------------------------------------------------------------
>
> Key: DAFFODIL-1900
> URL: https://issues.apache.org/jira/browse/DAFFODIL-1900
> Project: Daffodil
> Issue Type: Bug
> Components: TDML Runner
> Reporter: Steve Lawrence
> Priority: Major
> Fix For: 2.2.0
>
>
> Ideally separate test files, both inputs and expected outputs, would contain the Apache license. In general, include an apache license header in the files would causes tests to fail since the header is not expected. One potential solution to this is to modify the TDML Runner so that if a file begins with an apache license header then the header is stripped off before use. This does add some difficulties (e.g. manual tests require removing the license header, etc.) so care should be taken to make this work without getting in the way.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)