You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@iotdb.apache.org by 谭新宇 <ta...@qq.com> on 2020/10/30 06:04:24 UTC

Support `delete storage group '

Greetings,


Currently, it seems that the user can delete all data and timeseries:&nbsp;
delete timeseries root.*; 


But this sql cann't delete all related storage groups. In addition, such an approach would be more time-consuming than simply deleting specified storage groups.

So I believe it's better for `delete storage group FullPath` command to support wildcard, which can be regarded as `delete storage group <prefixPath&gt;`

For example, all sgs and data can be deleted by one sql efficiently:
delete storage group root.*; 


This sql is useful for some users in many scenarios, such as system cleanup during continuous testing.




I have implemented this feature and created a PR[1], you can take a review if you are interested in it.




[1] https://github.com/apache/iotdb/pull/1881




Best:)

--------

Xinyu Tan

Re: Support `delete storage group '

Posted by 谭新宇 <10...@qq.com>.
Many Thanks for reviewing PR and introducing implementation solution on JIRA.

I will describe solutions for next new_feature_PR on both the JIRA and mailing list.

Best
————
Xinyu Tan

> 在 2020年11月1日，上午10:02，Xiangdong Huang <sa...@gmail.com> 写道：
> 
> Hi,
> 
> I have merged this PR.
> 
> It is better to describe your main implementation solution on both the
> mailing list and the JIRA.
> 
> Best,
> -----------------------------------
> Xiangdong Huang
> School of Software, Tsinghua University
> 
> 黄向东
> 清华大学 软件学院
> 
> 
> Jialin Qiao <qj...@mails.tsinghua.edu.cn> 于2020年10月30日周五 下午10:34写道：
> 
>> Hi,
>> 
>>> So I believe it's better for `delete storage group FullPath` command to
>> support wildcard, which can be regarded as `delete storage group
>> <prefixPath>`
>> 
>> +1, this is a good function
>> 
>> Thanks,
>> --
>> Jialin Qiao
>> School of Software, Tsinghua University
>> 
>> 乔嘉林
>> 清华大学 软件学院
>> 
>>> -----原始邮件-----
>>> 发件人: "谭新宇" <ta...@qq.com>
>>> 发送时间: 2020-10-30 14:04:24 (星期五)
>>> 收件人: dev <de...@iotdb.apache.org>
>>> 抄送:
>>> 主题: Support `delete storage group <prefixPath>'
>>> 
>>> Greetings,
>>> 
>>> 
>>> Currently, it seems that the user can delete all data and
>> timeseries:&nbsp;
>>> delete timeseries root.*;
>>> 
>>> 
>>> But this sql cann't delete all related storage groups. In addition, such
>> an approach would be more time-consuming than simply deleting specified
>> storage groups.
>>> 
>>> So I believe it's better for `delete storage group FullPath` command to
>> support wildcard, which can be regarded as `delete storage group
>> <prefixPath&gt;`
>>> 
>>> For example, all sgs and data can be deleted by one sql efficiently:
>>> delete storage group root.*;
>>> 
>>> 
>>> This sql is useful for some users in many scenarios, such as system
>> cleanup during continuous testing.
>>> 
>>> 
>>> 
>>> 
>>> I have implemented this feature and created a PR[1], you can take a
>> review if you are interested in it.
>>> 
>>> 
>>> 
>>> 
>>> [1] https://github.com/apache/iotdb/pull/1881
>>> 
>>> 
>>> 
>>> 
>>> Best:)
>>> 
>>> --------
>>> 
>>> Xinyu Tan
>> 
>

Re: Support `delete storage group '

Posted by Xiangdong Huang <sa...@gmail.com>.
Hi,

I have merged this PR.

It is better to describe your main implementation solution on both the
mailing list and the JIRA.

Best,
-----------------------------------
Xiangdong Huang
School of Software, Tsinghua University

 黄向东
清华大学 软件学院


Jialin Qiao <qj...@mails.tsinghua.edu.cn> 于2020年10月30日周五 下午10:34写道：

> Hi,
>
> > So I believe it's better for `delete storage group FullPath` command to
> support wildcard, which can be regarded as `delete storage group
> <prefixPath>`
>
> +1, this is a good function
>
> Thanks,
> --
> Jialin Qiao
> School of Software, Tsinghua University
>
> 乔嘉林
> 清华大学 软件学院
>
> > -----原始邮件-----
> > 发件人: "谭新宇" <ta...@qq.com>
> > 发送时间: 2020-10-30 14:04:24 (星期五)
> > 收件人: dev <de...@iotdb.apache.org>
> > 抄送:
> > 主题: Support `delete storage group <prefixPath>'
> >
> > Greetings,
> >
> >
> > Currently, it seems that the user can delete all data and
> timeseries:&nbsp;
> > delete timeseries root.*;
> >
> >
> > But this sql cann't delete all related storage groups. In addition, such
> an approach would be more time-consuming than simply deleting specified
> storage groups.
> >
> > So I believe it's better for `delete storage group FullPath` command to
> support wildcard, which can be regarded as `delete storage group
> <prefixPath&gt;`
> >
> > For example, all sgs and data can be deleted by one sql efficiently:
> > delete storage group root.*;
> >
> >
> > This sql is useful for some users in many scenarios, such as system
> cleanup during continuous testing.
> >
> >
> >
> >
> > I have implemented this feature and created a PR[1], you can take a
> review if you are interested in it.
> >
> >
> >
> >
> > [1] https://github.com/apache/iotdb/pull/1881
> >
> >
> >
> >
> > Best:)
> >
> > --------
> >
> > Xinyu Tan
>

Re: Support `delete storage group '

Posted by Jialin Qiao <qj...@mails.tsinghua.edu.cn>.
Hi,

> So I believe it's better for `delete storage group FullPath` command to support wildcard, which can be regarded as `delete storage group <prefixPath>`

+1, this is a good function

Thanks,
--
Jialin Qiao
School of Software, Tsinghua University

乔嘉林
清华大学 软件学院

> -----原始邮件-----
> 发件人: "谭新宇" <ta...@qq.com>
> 发送时间: 2020-10-30 14:04:24 (星期五)
> 收件人: dev <de...@iotdb.apache.org>
> 抄送: 
> 主题: Support `delete storage group <prefixPath>'
> 
> Greetings,
> 
> 
> Currently, it seems that the user can delete all data and timeseries:&nbsp;
> delete timeseries root.*; 
> 
> 
> But this sql cann't delete all related storage groups. In addition, such an approach would be more time-consuming than simply deleting specified storage groups.
> 
> So I believe it's better for `delete storage group FullPath` command to support wildcard, which can be regarded as `delete storage group <prefixPath&gt;`
> 
> For example, all sgs and data can be deleted by one sql efficiently:
> delete storage group root.*; 
> 
> 
> This sql is useful for some users in many scenarios, such as system cleanup during continuous testing.
> 
> 
> 
> 
> I have implemented this feature and created a PR[1], you can take a review if you are interested in it.
> 
> 
> 
> 
> [1] https://github.com/apache/iotdb/pull/1881
> 
> 
> 
> 
> Best:)
> 
> --------
> 
> Xinyu Tan