You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2019/12/31 01:32:19 UTC
[GitHub] [cordova-plugin-inappbrowser] brodybits commented on issue #600:
[MAJOR] (all platforms): remove "window.open" overwrite
brodybits commented on issue #600: [MAJOR] (all platforms): remove "window.open" overwrite
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/600#issuecomment-569844633
Thanks. I think I cannot stress enough how important it is to make it absolutely clear if a PR contains a breaking change. While we should expect current InAppBrowser maintainers to pick this up, we have seen maintainers come and go due to external factors. (I can only imagine if another maintainer would just do LGTM, merge and release without realizing that this is a breaking change ... kaboom!)
It was certainly not clear to me from first glance in this PR and #599 that you wanted to discuss the next major release in #599.
That said, I just sent a proposal to the mailing list to do a version bump and get this PR reviewed & potentially merged. Thanks for your quick work on this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org