You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by kunal642 <gi...@git.apache.org> on 2018/04/11 14:58:35 UTC
[GitHub] carbondata pull request #2160: [CARBONDATA-2335] Fix auto handoff for preagg...
GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/2160
[CARBONDATA-2335] Fix auto handoff for preaggregate table with streaming
Solution: MetaListener was not called for auto handoff case therefore child load commands were not being created thus throwing NullPointerException.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
- [ ] Any backward compatibility impacted?
- [ ] Document update required?
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kunal642/carbondata fix_auto_handoff_aggregate_load
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2160.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2160
----
commit f6bc57708f8d3da77d547640ea373e4e5c9b970a
Author: kunal642 <ku...@...>
Date: 2018-04-11T14:56:01Z
fix auto handoff for preaggregate table with streaming
----
---
[GitHub] carbondata issue #2160: [CARBONDATA-2335] Fix auto handoff for preaggregate ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2160
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3732/
---
[GitHub] carbondata issue #2160: [CARBONDATA-2335] Fix auto handoff for preaggregate ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2160
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5076/
---
[GitHub] carbondata issue #2160: [CARBONDATA-2335] Fix auto handoff for preaggregate ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2160
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3830/
---
[GitHub] carbondata issue #2160: [CARBONDATA-2335] Fix auto handoff for preaggregate ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2160
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4951/
---
[GitHub] carbondata issue #2160: [CARBONDATA-2335] Fix auto handoff for preaggregate ...
Posted by kunal642 <gi...@git.apache.org>.
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2160
retest this please
---
[GitHub] carbondata issue #2160: [CARBONDATA-2335] Fix auto handoff for preaggregate ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2160
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3733/
---
[GitHub] carbondata issue #2160: [CARBONDATA-2335] Fix auto handoff for preaggregate ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2160
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5064/
---
[GitHub] carbondata issue #2160: [CARBONDATA-2335] Fix auto handoff for preaggregate ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2160
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4407/
---
[GitHub] carbondata issue #2160: [CARBONDATA-2335] Fix auto handoff for preaggregate ...
Posted by kunal642 <gi...@git.apache.org>.
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2160
retest this please
---
[GitHub] carbondata issue #2160: [CARBONDATA-2335] Fix auto handoff for preaggregate ...
Posted by kumarvishal09 <gi...@git.apache.org>.
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/2160
LGTM
---
[GitHub] carbondata pull request #2160: [CARBONDATA-2335] Fix auto handoff for preagg...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2160
---
[GitHub] carbondata issue #2160: [CARBONDATA-2335] Fix auto handoff for preaggregate ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2160
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5048/
---
[GitHub] carbondata pull request #2160: [CARBONDATA-2335] Fix auto handoff for preagg...
Posted by kumarvishal09 <gi...@git.apache.org>.
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2160#discussion_r181716090
--- Diff: integration/spark-common/src/main/scala/org/apache/spark/sql/execution/streaming/CarbonAppendableStreamSink.scala ---
@@ -163,7 +162,7 @@ class CarbonAppendableStreamSink(
/**
* if the directory size of current segment beyond the threshold, hand off new segment
*/
- private def checkOrHandOffSegment(): Unit = {
+ private def checkOrHandOffSegment(operationContext: OperationContext): Unit = {
--- End diff --
No need to change method signature use the same operation context passed in CarbonAppendableStreamSink
---
[GitHub] carbondata issue #2160: [CARBONDATA-2335] Fix auto handoff for preaggregate ...
Posted by kunal642 <gi...@git.apache.org>.
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2160
retest this please
---
[GitHub] carbondata issue #2160: [CARBONDATA-2335] Fix auto handoff for preaggregate ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2160
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4969/
---
[GitHub] carbondata issue #2160: [CARBONDATA-2335] Fix auto handoff for preaggregate ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2160
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4408/
---
[GitHub] carbondata issue #2160: [CARBONDATA-2335] Fix auto handoff for preaggregate ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2160
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3842/
---
[GitHub] carbondata issue #2160: [CARBONDATA-2335] Fix auto handoff for preaggregate ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2160
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3854/
---
[GitHub] carbondata pull request #2160: [CARBONDATA-2335] Fix auto handoff for preagg...
Posted by kumarvishal09 <gi...@git.apache.org>.
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2160#discussion_r181716258
--- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/streaming/StreamSinkFactory.scala ---
@@ -110,6 +110,8 @@ object StreamSinkFactory {
val segmentId = getStreamSegmentId(carbonTable)
carbonLoadModel.setSegmentId(segmentId)
+ val loadMetaEvent = new LoadMetadataEvent(carbonTable, false)
+ OperationListenerBus.getInstance().fireEvent(loadMetaEvent, operationContext)
--- End diff --
Please add comments
---