You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by GitBox <gi...@apache.org> on 2023/01/11 08:54:51 UTC
[GitHub] [rocketmq] ShadowySpirits opened a new pull request, #5864: [ISSUE #5863] implement tiered store metadata
ShadowySpirits opened a new pull request, #5864:
URL: https://github.com/apache/rocketmq/pull/5864
close #5863
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] aaron-ai commented on pull request #5864: [ISSUE #5863] implement tiered store metadata
Posted by GitBox <gi...@apache.org>.
aaron-ai commented on PR #5864:
URL: https://github.com/apache/rocketmq/pull/5864#issuecomment-1379919338
Could you add more comments about each metadata class - overall this PR looks solid.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] ShadowySpirits commented on a diff in pull request #5864: [ISSUE #5863] implement tiered store metadata
Posted by GitBox <gi...@apache.org>.
ShadowySpirits commented on code in PR #5864:
URL: https://github.com/apache/rocketmq/pull/5864#discussion_r1067834169
##########
tieredstore/src/main/java/org/apache/rocketmq/store/tiered/common/TieredMessageStoreConfig.java:
##########
@@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.rocketmq.store.tiered.common;
+
+import java.io.File;
+
+public class TieredMessageStoreConfig {
+ private String storePathRootDir = System.getProperty("user.home") + File.separator + "store";
Review Comment:
I do plan to use the same dir. The broker will manage MessageStoreConfig, config with the same name will be overwritten.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] ShadowySpirits commented on pull request #5864: [ISSUE #5863] implement tiered store metadata
Posted by GitBox <gi...@apache.org>.
ShadowySpirits commented on PR #5864:
URL: https://github.com/apache/rocketmq/pull/5864#issuecomment-1379934098
> Could you add more comments about each metadata class - overall this PR looks solid.
Ok, I will add more comments in next pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] lollipopjin commented on a diff in pull request #5864: [ISSUE #5863] implement tiered store metadata
Posted by GitBox <gi...@apache.org>.
lollipopjin commented on code in PR #5864:
URL: https://github.com/apache/rocketmq/pull/5864#discussion_r1067751983
##########
tieredstore/src/main/java/org/apache/rocketmq/store/tiered/common/TieredMessageStoreConfig.java:
##########
@@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.rocketmq.store.tiered.common;
+
+import java.io.File;
+
+public class TieredMessageStoreConfig {
+ private String storePathRootDir = System.getProperty("user.home") + File.separator + "store";
Review Comment:
How about use the same rootDir in org.apache.rocketmq.store.config.MessageStoreConfig ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] lollipopjin merged pull request #5864: [ISSUE #5863] implement tiered store metadata
Posted by GitBox <gi...@apache.org>.
lollipopjin merged PR #5864:
URL: https://github.com/apache/rocketmq/pull/5864
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org