You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@livy.apache.org by GitBox <gi...@apache.org> on 2019/09/17 08:10:14 UTC

[GitHub] [incubator-livy] runzhiwang opened a new pull request #225: [LIVY-657][TEST]Fix travis failed on should not create sessions with duplicate names

runzhiwang opened a new pull request #225: [LIVY-657][TEST]Fix travis failed on should not create sessions with duplicate names
URL: https://github.com/apache/incubator-livy/pull/225
 
 
   
   ## What changes were proposed in this pull request?
   
   Fix travis failed on "should not create sessions with duplicate names"
   
   The cause of failed is as follows:
   
   1. When session2 was stopped, it will call stop() method in Session.scala asynchronously by Scala Future. So when assert(session2.stopped), if the stop() method has not been executed asynchronously, the test will fail.
   
   ## How was this patch tested?
   
   Existed UT and IT.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services