You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2019/07/10 04:11:15 UTC

[GitHub] [incubator-gobblin] sv2000 commented on a change in pull request #2663: [GOBBLIN-796] Add support partial updates for flowConfig

sv2000 commented on a change in pull request #2663: [GOBBLIN-796] Add support partial updates for flowConfig
URL: https://github.com/apache/incubator-gobblin/pull/2663#discussion_r301879302
 
 

 ##########
 File path: gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-client/src/test/java/org/apache/gobblin/service/FlowConfigV2Test.java
 ##########
 @@ -122,6 +127,39 @@ public void testCheckFlowExecutionId() throws Exception {
     Assert.assertEquals(_client.createFlowConfig(flowConfig).getFlowExecutionId().longValue(), -1L);
   }
 
+  @Test
+  public void testPartialUpdate() throws Exception {
 
 Review comment:
   Can we test for an exception being thrown in case of a bad partial update?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services