[GitHub] [spark] beliefer commented on a change in pull request #31356: [SPARK-34257][SQL] Improve performance for last_value over unbounded window frame

[GitBox <gi...@apache.org>]

beliefer commented on a change in pull request #31356:
URL: https://github.com/apache/spark/pull/31356#discussion_r586061452



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowExecBase.scala
##########
@@ -237,6 +240,11 @@ trait WindowExecBase extends UnaryExecNode {
               new UnboundedWindowFunctionFrame(target, processor)
             }
 
+          case ("AGGREGATE_LAST", _, UnboundedPreceding, UnboundedFollowing, _) =>

Review comment:
       You mean I understand. It is not worthwhile to optimize the `last_value` alone in the framework.
   I also feel that way. If we can find other functions that are the same as `last_value` in the future, then we can do it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org