You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "jonahgao (via GitHub)" <gi...@apache.org> on 2024/05/14 06:28:55 UTC
[PR] Minor: remove unused source file udf.rs [datafusion]
jonahgao opened a new pull request, #10497:
URL: https://github.com/apache/datafusion/pull/10497
## Which issue does this PR close?
N/A
## Rationale for this change
I have checked that all the UDFs in the file have already been implemented in other modules.
Moreover, udf.rs is not appearing in [lib.rs](https://github.com/apache/datafusion/blob/main/datafusion/functions-array/src/lib.rs).
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
## Are these changes tested?
Yes. By existing tests.
## Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Minor: remove unused source file `udf.rs` [datafusion]
Posted by "jonahgao (via GitHub)" <gi...@apache.org>.
jonahgao merged PR #10497:
URL: https://github.com/apache/datafusion/pull/10497
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Minor: remove unused source file `udf.rs` [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #10497:
URL: https://github.com/apache/datafusion/pull/10497#discussion_r1599867014
##########
datafusion/functions-array/src/udf.rs:
##########
@@ -1,688 +0,0 @@
-// Licensed to the Apache Software Foundation (ASF) under one
-// or more contributor license agreements. See the NOTICE file
-// distributed with this work for additional information
-// regarding copyright ownership. The ASF licenses this file
-// to you under the Apache License, Version 2.0 (the
-// "License"); you may not use this file except in compliance
-// with the License. You may obtain a copy of the License at
-//
-// http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing,
-// software distributed under the License is distributed on an
-// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-// KIND, either express or implied. See the License for the
-// specific language governing permissions and limitations
-// under the License.
-
-//! [`ScalarUDFImpl`] definitions for array functions.
-
-use arrow::array::{NullArray, StringArray};
-use arrow::datatypes::DataType;
-use arrow::datatypes::Field;
-use arrow::datatypes::IntervalUnit::MonthDayNano;
-use arrow_schema::DataType::{LargeUtf8, List, Utf8};
-use datafusion_common::exec_err;
-use datafusion_common::plan_err;
-use datafusion_common::Result;
-use datafusion_expr::expr::ScalarFunction;
-use datafusion_expr::Expr;
-use datafusion_expr::TypeSignature;
-use datafusion_expr::{ColumnarValue, ScalarUDFImpl, Signature, Volatility};
-use std::any::Any;
-use std::sync::Arc;
-
-// Create static instances of ScalarUDFs for each function
-make_udf_function!(ArrayToString,
Review Comment:
Here is the other copy: https://github.com/apache/datafusion/blob/cd36ee3b305dc4e50b9a5feb8ea88199ae17527a/datafusion/functions-array/src/string.rs#L113-L132
##########
datafusion/functions-array/src/udf.rs:
##########
@@ -1,688 +0,0 @@
-// Licensed to the Apache Software Foundation (ASF) under one
-// or more contributor license agreements. See the NOTICE file
-// distributed with this work for additional information
-// regarding copyright ownership. The ASF licenses this file
-// to you under the Apache License, Version 2.0 (the
-// "License"); you may not use this file except in compliance
-// with the License. You may obtain a copy of the License at
-//
-// http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing,
-// software distributed under the License is distributed on an
-// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-// KIND, either express or implied. See the License for the
-// specific language governing permissions and limitations
-// under the License.
-
-//! [`ScalarUDFImpl`] definitions for array functions.
-
-use arrow::array::{NullArray, StringArray};
-use arrow::datatypes::DataType;
-use arrow::datatypes::Field;
-use arrow::datatypes::IntervalUnit::MonthDayNano;
-use arrow_schema::DataType::{LargeUtf8, List, Utf8};
-use datafusion_common::exec_err;
-use datafusion_common::plan_err;
-use datafusion_common::Result;
-use datafusion_expr::expr::ScalarFunction;
-use datafusion_expr::Expr;
-use datafusion_expr::TypeSignature;
-use datafusion_expr::{ColumnarValue, ScalarUDFImpl, Signature, Volatility};
-use std::any::Any;
-use std::sync::Arc;
-
-// Create static instances of ScalarUDFs for each function
-make_udf_function!(ArrayToString,
- array_to_string,
- array delimiter, // arg name
- "converts each element to its text representation.", // doc
- array_to_string_udf // internal function name
-);
-#[derive(Debug)]
-pub struct ArrayToString {
- signature: Signature,
- aliases: Vec<String>,
-}
-
-impl ArrayToString {
- pub fn new() -> Self {
- Self {
- signature: Signature::variadic_any(Volatility::Immutable),
- aliases: vec![
- String::from("array_to_string"),
- String::from("list_to_string"),
- String::from("array_join"),
- String::from("list_join"),
- ],
- }
- }
-}
-
-impl ScalarUDFImpl for ArrayToString {
- fn as_any(&self) -> &dyn Any {
- self
- }
- fn name(&self) -> &str {
- "array_to_string"
- }
-
- fn signature(&self) -> &Signature {
- &self.signature
- }
-
- fn return_type(&self, arg_types: &[DataType]) -> Result<DataType> {
- use DataType::*;
- Ok(match arg_types[0] {
- List(_) | LargeList(_) | FixedSizeList(_, _) => Utf8,
- _ => {
- return plan_err!("The array_to_string function can only accept List/LargeList/FixedSizeList.");
- }
- })
- }
-
- fn invoke(&self, args: &[ColumnarValue]) -> Result<ColumnarValue> {
- let args = ColumnarValue::values_to_arrays(args)?;
- crate::kernels::array_to_string(&args).map(ColumnarValue::Array)
- }
-
- fn aliases(&self) -> &[String] {
- &self.aliases
- }
-}
-
-make_udf_function!(StringToArray,
- string_to_array,
- string delimiter null_string, // arg name
- "splits a `string` based on a `delimiter` and returns an array of parts. Any parts matching the optional `null_string` will be replaced with `NULL`", // doc
- string_to_array_udf // internal function name
-);
-#[derive(Debug)]
-pub struct StringToArray {
- signature: Signature,
- aliases: Vec<String>,
-}
-
-impl StringToArray {
- pub fn new() -> Self {
- Self {
- signature: Signature::variadic_any(Volatility::Immutable),
- aliases: vec![
- String::from("string_to_array"),
- String::from("string_to_list"),
- ],
- }
- }
-}
-
-impl ScalarUDFImpl for StringToArray {
- fn as_any(&self) -> &dyn Any {
- self
- }
- fn name(&self) -> &str {
- "string_to_array"
- }
-
- fn signature(&self) -> &Signature {
- &self.signature
- }
-
- fn return_type(&self, arg_types: &[DataType]) -> Result<DataType> {
- use DataType::*;
- Ok(match arg_types[0] {
- Utf8 | LargeUtf8 => {
- List(Arc::new(Field::new("item", arg_types[0].clone(), true)))
- }
- _ => {
- return plan_err!(
- "The string_to_array function can only accept Utf8 or LargeUtf8."
- );
- }
- })
- }
-
- fn invoke(&self, args: &[ColumnarValue]) -> Result<ColumnarValue> {
- let mut args = ColumnarValue::values_to_arrays(args)?;
- // Case: delimiter is NULL, needs to be handled as well.
- if args[1].as_any().is::<NullArray>() {
- args[1] = Arc::new(StringArray::new_null(args[1].len()));
- };
-
- match args[0].data_type() {
- Utf8 => {
- crate::kernels::string_to_array::<i32>(&args).map(ColumnarValue::Array)
- }
- LargeUtf8 => {
- crate::kernels::string_to_array::<i64>(&args).map(ColumnarValue::Array)
- }
- other => {
- exec_err!("unsupported type for string_to_array function as {other}")
- }
- }
- }
-
- fn aliases(&self) -> &[String] {
- &self.aliases
- }
-}
-
-make_udf_function!(
Review Comment:
Here is the current copy of the code https://github.com/apache/datafusion/blob/cd36ee3b305dc4e50b9a5feb8ea88199ae17527a/datafusion/functions-array/src/dimension.rs#L45-L50
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Minor: remove unused source file `udf.rs` [datafusion]
Posted by "jonahgao (via GitHub)" <gi...@apache.org>.
jonahgao commented on PR #10497:
URL: https://github.com/apache/datafusion/pull/10497#issuecomment-2111431245
Thank you for double-checking @alamb .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org