Re: [PR] [SPARK-48476] fix NPE error message for null delmiter csv [spark]

["yaooqinn (via GitHub)" <gi...@apache.org>]

yaooqinn commented on code in PR #46810:
URL: https://github.com/apache/spark/pull/46810#discussion_r1621619425


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/csv/CSVExprUtils.scala:
##########
@@ -120,6 +120,11 @@ object CSVExprUtils {
    * @throws SparkIllegalArgumentException if any of the individual input chunks are illegal
    */
   def toDelimiterStr(str: String): String = {
+    if (str == null) {

Review Comment:
   QQ: Is "" valid? Do we know how users specified null?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org