You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/09/16 13:30:04 UTC

[GitHub] [incubator-tvm] roastduck opened a new issue #6492: [TOPI] Typo in operator key

roastduck opened a new issue #6492:
URL: https://github.com/apache/incubator-tvm/issues/6492


   https://github.com/apache/incubator-tvm/blob/bdfefbb03f5aab96ee677ee28a166dd6ab5dbf3f/python/tvm/topi/bifrost/dense.py#L26
   
   "biforst" should be "bifrost". This bug makes the op totally unavailable in Relay.
   
   I can fix this bug if expected, but I don't know how to add a proper test.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-tvm] zhiics commented on issue #6492: [TOPI] Typo in operator key

Posted by GitBox <gi...@apache.org>.
zhiics commented on issue #6492:
URL: https://github.com/apache/incubator-tvm/issues/6492#issuecomment-693501794


   cc @mbaret @icemelon9 
   
   I think we I have test in test_topi: https://github.com/apache/incubator-tvm/blob/master/tests/python/topi/python/test_topi_dense.py#L40, but the target is probably not enabled in the CI


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-tvm] mbaret commented on issue #6492: [TOPI] Typo in operator key

Posted by GitBox <gi...@apache.org>.
mbaret commented on issue #6492:
URL: https://github.com/apache/incubator-tvm/issues/6492#issuecomment-693510104


   Ah yes... It's very difficult to keep these maintained due to the lack of a Mali GPU in CI. I don't have immediate access to one either but that change looks obviously correct to me.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-tvm] masahi closed issue #6492: [TOPI] Typo in operator key

Posted by GitBox <gi...@apache.org>.
masahi closed issue #6492:
URL: https://github.com/apache/incubator-tvm/issues/6492


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-tvm] tqchen commented on issue #6492: [TOPI] Typo in operator key

Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #6492:
URL: https://github.com/apache/incubator-tvm/issues/6492#issuecomment-693543552


   Thanks @roastduck please send a PR


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org