You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/01/09 05:30:37 UTC
[GitHub] [flink] zuston opened a new pull request #18306: [FLINK-25445] No need to create local recovery dirs when disabled loc…
zuston opened a new pull request #18306:
URL: https://github.com/apache/flink/pull/18306
…al-recovery in TaskExecutorLocalStateStoresManager
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
*(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)*
## Brief change log
*(for example:)*
- *The TaskInfo is stored in the blob store on job creation time as a persistent artifact*
- *Deployments RPC transmits only the blob storage reference*
- *TaskManagers retrieve the TaskInfo from the blob cache*
## Verifying this change
Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (100MB)*
- *Extended integration test for recovery after master (JobManager) failure*
- *Added test that validates that TaskInfo is transferred only once across recoveries*
- *Manually verified the change by running a 4 node cluser with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / no)
- The serializers: (yes / no / don't know)
- The runtime per-record code paths (performance sensitive): (yes / no / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
- The S3 file system connector: (yes / no / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dmvk commented on a change in pull request #18306: [FLINK-25445] No need to create local recovery dirs when disabled loc…
Posted by GitBox <gi...@apache.org>.
dmvk commented on a change in pull request #18306:
URL: https://github.com/apache/flink/pull/18306#discussion_r782148099
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/LocalRecoveryConfig.java
##########
@@ -31,11 +29,10 @@
private final boolean localRecoveryEnabled;
/** Encapsulates the root directories and the subtask-specific path. */
- @Nonnull private final LocalRecoveryDirectoryProvider localStateDirectories;
+ private final LocalRecoveryDirectoryProvider localStateDirectories;
public LocalRecoveryConfig(
- boolean localRecoveryEnabled,
- @Nonnull LocalRecoveryDirectoryProvider directoryProvider) {
+ boolean localRecoveryEnabled, LocalRecoveryDirectoryProvider directoryProvider) {
Review comment:
```suggestion
boolean localRecoveryEnabled, @Nullable LocalRecoveryDirectoryProvider directoryProvider) {
```
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/LocalRecoveryConfig.java
##########
@@ -44,7 +41,6 @@ public boolean isLocalRecoveryEnabled() {
return localRecoveryEnabled;
}
- @Nonnull
public LocalRecoveryDirectoryProvider getLocalStateDirectoryProvider() {
Review comment:
Would it make sense to change the signature to `Optional<LocalRecoveryDirectoryProvider> getLocalStateDirectoryProvider()` to make sure the change is properly reflected in all places?
Other option would be adding some explicit exception when getting a null provider.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zuston commented on pull request #18306: [FLINK-25445] No need to create local recovery dirs when disabled loc…
Posted by GitBox <gi...@apache.org>.
zuston commented on pull request #18306:
URL: https://github.com/apache/flink/pull/18306#issuecomment-1014384445
Updated @dmvk. Could you help check again?
Thanks~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18306: [FLINK-25445] No need to create local recovery dirs when disabled loc…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18306:
URL: https://github.com/apache/flink/pull/18306#issuecomment-1008234006
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7d972d43be4188ad9dad3d53e45f5710fdb8b754",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29144",
"triggerID" : "7d972d43be4188ad9dad3d53e45f5710fdb8b754",
"triggerType" : "PUSH"
}, {
"hash" : "32883ca0240ef8ef0f3fb7162035a3aff23cdb7d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29293",
"triggerID" : "32883ca0240ef8ef0f3fb7162035a3aff23cdb7d",
"triggerType" : "PUSH"
}, {
"hash" : "3efa1bed35ddcfcf74e1de739ebc355e404eb73b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29505",
"triggerID" : "3efa1bed35ddcfcf74e1de739ebc355e404eb73b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 32883ca0240ef8ef0f3fb7162035a3aff23cdb7d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29293)
* 3efa1bed35ddcfcf74e1de739ebc355e404eb73b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29505)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zuston commented on pull request #18306: [FLINK-25445] No need to create local recovery dirs when disabled loc…
Posted by GitBox <gi...@apache.org>.
zuston commented on pull request #18306:
URL: https://github.com/apache/flink/pull/18306#issuecomment-1021036013
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zuston commented on pull request #18306: [FLINK-25445] No need to create local recovery dirs when disabled loc…
Posted by GitBox <gi...@apache.org>.
zuston commented on pull request #18306:
URL: https://github.com/apache/flink/pull/18306#issuecomment-1013103407
@dmvk Gentle ping. If you have time, could you help review it? At weekends, i will have more time to deal with it.
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zuston commented on pull request #18306: [FLINK-25445] No need to create local recovery dirs when disabled loc…
Posted by GitBox <gi...@apache.org>.
zuston commented on pull request #18306:
URL: https://github.com/apache/flink/pull/18306#issuecomment-1010957872
Updated @dmvk Could you help review again? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18306: [FLINK-25445] No need to create local recovery dirs when disabled loc…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18306:
URL: https://github.com/apache/flink/pull/18306#issuecomment-1008234006
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7d972d43be4188ad9dad3d53e45f5710fdb8b754",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29144",
"triggerID" : "7d972d43be4188ad9dad3d53e45f5710fdb8b754",
"triggerType" : "PUSH"
}, {
"hash" : "32883ca0240ef8ef0f3fb7162035a3aff23cdb7d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29293",
"triggerID" : "32883ca0240ef8ef0f3fb7162035a3aff23cdb7d",
"triggerType" : "PUSH"
}, {
"hash" : "3efa1bed35ddcfcf74e1de739ebc355e404eb73b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29505",
"triggerID" : "3efa1bed35ddcfcf74e1de739ebc355e404eb73b",
"triggerType" : "PUSH"
}, {
"hash" : "7c716c0de1cfe85b1c67d44c6a94454a2700c043",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29538",
"triggerID" : "7c716c0de1cfe85b1c67d44c6a94454a2700c043",
"triggerType" : "PUSH"
}, {
"hash" : "f8c4b9cfcf8dd3fc85472dac9b8165c7c2c846dc",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30056",
"triggerID" : "f8c4b9cfcf8dd3fc85472dac9b8165c7c2c846dc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f8c4b9cfcf8dd3fc85472dac9b8165c7c2c846dc Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30056)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18306: [FLINK-25445] No need to create local recovery dirs when disabled loc…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18306:
URL: https://github.com/apache/flink/pull/18306#issuecomment-1008234006
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7d972d43be4188ad9dad3d53e45f5710fdb8b754",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29144",
"triggerID" : "7d972d43be4188ad9dad3d53e45f5710fdb8b754",
"triggerType" : "PUSH"
}, {
"hash" : "32883ca0240ef8ef0f3fb7162035a3aff23cdb7d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29293",
"triggerID" : "32883ca0240ef8ef0f3fb7162035a3aff23cdb7d",
"triggerType" : "PUSH"
}, {
"hash" : "3efa1bed35ddcfcf74e1de739ebc355e404eb73b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29505",
"triggerID" : "3efa1bed35ddcfcf74e1de739ebc355e404eb73b",
"triggerType" : "PUSH"
}, {
"hash" : "7c716c0de1cfe85b1c67d44c6a94454a2700c043",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29538",
"triggerID" : "7c716c0de1cfe85b1c67d44c6a94454a2700c043",
"triggerType" : "PUSH"
}, {
"hash" : "f8c4b9cfcf8dd3fc85472dac9b8165c7c2c846dc",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30056",
"triggerID" : "f8c4b9cfcf8dd3fc85472dac9b8165c7c2c846dc",
"triggerType" : "PUSH"
}, {
"hash" : "f8c4b9cfcf8dd3fc85472dac9b8165c7c2c846dc",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30056",
"triggerID" : "1021036013",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* f8c4b9cfcf8dd3fc85472dac9b8165c7c2c846dc Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30056)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zuston commented on a change in pull request #18306: [FLINK-25445] No need to create local recovery dirs when disabled loc…
Posted by GitBox <gi...@apache.org>.
zuston commented on a change in pull request #18306:
URL: https://github.com/apache/flink/pull/18306#discussion_r782169884
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/LocalRecoveryConfig.java
##########
@@ -44,7 +41,6 @@ public boolean isLocalRecoveryEnabled() {
return localRecoveryEnabled;
}
- @Nonnull
public LocalRecoveryDirectoryProvider getLocalStateDirectoryProvider() {
Review comment:
The signature of optional may be a better option. We could use orElseThrow to throw exceptions although it should not happen when enabled task local recovery.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zuston commented on pull request #18306: [FLINK-25445] No need to create local recovery dirs when disabled loc…
Posted by GitBox <gi...@apache.org>.
zuston commented on pull request #18306:
URL: https://github.com/apache/flink/pull/18306#issuecomment-1009993659
Thanks for your review @dmvk
By the way, why we make task local-recovery enabled defaultly? Only due to the uncompatility with unaligned checkpoint?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zuston commented on pull request #18306: [FLINK-25445] No need to create local recovery dirs when disabled loc…
Posted by GitBox <gi...@apache.org>.
zuston commented on pull request #18306:
URL: https://github.com/apache/flink/pull/18306#issuecomment-1010018103
Thank very much @dmvk . I’ll take a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18306: [FLINK-25445] No need to create local recovery dirs when disabled loc…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18306:
URL: https://github.com/apache/flink/pull/18306#issuecomment-1008234006
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7d972d43be4188ad9dad3d53e45f5710fdb8b754",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29144",
"triggerID" : "7d972d43be4188ad9dad3d53e45f5710fdb8b754",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7d972d43be4188ad9dad3d53e45f5710fdb8b754 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29144)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zuston edited a comment on pull request #18306: [FLINK-25445] No need to create local recovery dirs when disabled loc…
Posted by GitBox <gi...@apache.org>.
zuston edited a comment on pull request #18306:
URL: https://github.com/apache/flink/pull/18306#issuecomment-1009993659
Thanks for your review @dmvk
By the way, why we make task local-recovery disabled defaultly? Only due to the uncompatility with unaligned checkpoint?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zuston commented on pull request #18306: [FLINK-25445] No need to create local recovery dirs when disabled loc…
Posted by GitBox <gi...@apache.org>.
zuston commented on pull request #18306:
URL: https://github.com/apache/flink/pull/18306#issuecomment-1026838228
@dmvk Gentle ping. Could u help review it ? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zuston commented on pull request #18306: [FLINK-25445] No need to create local recovery dirs when disabled loc…
Posted by GitBox <gi...@apache.org>.
zuston commented on pull request #18306:
URL: https://github.com/apache/flink/pull/18306#issuecomment-1016325347
Gentle ping @dmvk . Thanks :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dmvk commented on a change in pull request #18306: [FLINK-25445] No need to create local recovery dirs when disabled loc…
Posted by GitBox <gi...@apache.org>.
dmvk commented on a change in pull request #18306:
URL: https://github.com/apache/flink/pull/18306#discussion_r784971098
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/LocalRecoveryConfig.java
##########
@@ -58,4 +63,24 @@ public String toString() {
+ localStateDirectories
+ '}';
}
+
+ /**
+ * An {@link NullOfDirProviderException} is thrown when the {@link
+ * LocalRecoveryDirectoryProvider} is null.
+ */
+ @Internal
+ public static class NullOfDirProviderException extends RuntimeException {
+ public NullOfDirProviderException(String message, Throwable cause) {
+ super(message, cause);
+ }
+
+ public NullOfDirProviderException(String message) {
+ super(message);
+ }
+
+ public NullOfDirProviderException() {
+ this(
+ "When task local recovery is enabled, the NullPointerException of LocalRecoveryDirectoryProvider should not happen.");
+ }
+ }
Review comment:
```suggestion
public static Supplier<IllegalStateException> localRecoveryNotEnabled() {
return () ->
new IllegalStateException(
"Getting a LocalRecoveryDirectoryProvider is only supported with the local recovery enabled. This is a bug and should be reported.");
}
```
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/LocalRecoveryConfig.java
##########
@@ -44,9 +48,10 @@ public boolean isLocalRecoveryEnabled() {
return localRecoveryEnabled;
}
- @Nonnull
- public LocalRecoveryDirectoryProvider getLocalStateDirectoryProvider() {
- return localStateDirectories;
+ public Optional<LocalRecoveryDirectoryProvider> getLocalStateDirectoryProvider() {
+ return localStateDirectories == null
+ ? Optional.empty()
+ : Optional.of(localStateDirectories);
Review comment:
```suggestion
return Optional.ofNullable(localStateDirectories);
```
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/LocalRecoveryConfig.java
##########
@@ -44,9 +48,10 @@ public boolean isLocalRecoveryEnabled() {
return localRecoveryEnabled;
Review comment:
```suggestion
return localStateDirectories != null;
```
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/LocalRecoveryConfig.java
##########
@@ -31,11 +35,11 @@
private final boolean localRecoveryEnabled;
/** Encapsulates the root directories and the subtask-specific path. */
- @Nonnull private final LocalRecoveryDirectoryProvider localStateDirectories;
+ @Nullable private final LocalRecoveryDirectoryProvider localStateDirectories;
public LocalRecoveryConfig(
boolean localRecoveryEnabled,
Review comment:
I think we might want to get rid of this parameter completely. This two parameters having the same meaning thing, just leads into some weird implementations.
For example we can now easily get rid of the `SavepointLocalRecoveryProvider` from the state processor API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zuston commented on pull request #18306: [FLINK-25445] No need to create local recovery dirs when disabled loc…
Posted by GitBox <gi...@apache.org>.
zuston commented on pull request #18306:
URL: https://github.com/apache/flink/pull/18306#issuecomment-1020171967
Rebase latest master and squash all commits. @dmvk If you have time, could you help review again? Thanks :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18306: [FLINK-25445] No need to create local recovery dirs when disabled loc…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18306:
URL: https://github.com/apache/flink/pull/18306#issuecomment-1008234006
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7d972d43be4188ad9dad3d53e45f5710fdb8b754",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29144",
"triggerID" : "7d972d43be4188ad9dad3d53e45f5710fdb8b754",
"triggerType" : "PUSH"
}, {
"hash" : "32883ca0240ef8ef0f3fb7162035a3aff23cdb7d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29293",
"triggerID" : "32883ca0240ef8ef0f3fb7162035a3aff23cdb7d",
"triggerType" : "PUSH"
}, {
"hash" : "3efa1bed35ddcfcf74e1de739ebc355e404eb73b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29505",
"triggerID" : "3efa1bed35ddcfcf74e1de739ebc355e404eb73b",
"triggerType" : "PUSH"
}, {
"hash" : "7c716c0de1cfe85b1c67d44c6a94454a2700c043",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29538",
"triggerID" : "7c716c0de1cfe85b1c67d44c6a94454a2700c043",
"triggerType" : "PUSH"
}, {
"hash" : "f8c4b9cfcf8dd3fc85472dac9b8165c7c2c846dc",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30056",
"triggerID" : "f8c4b9cfcf8dd3fc85472dac9b8165c7c2c846dc",
"triggerType" : "PUSH"
}, {
"hash" : "f8c4b9cfcf8dd3fc85472dac9b8165c7c2c846dc",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30056",
"triggerID" : "1021036013",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* f8c4b9cfcf8dd3fc85472dac9b8165c7c2c846dc Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30056)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18306: [FLINK-25445] No need to create local recovery dirs when disabled loc…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18306:
URL: https://github.com/apache/flink/pull/18306#issuecomment-1008234006
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7d972d43be4188ad9dad3d53e45f5710fdb8b754",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29144",
"triggerID" : "7d972d43be4188ad9dad3d53e45f5710fdb8b754",
"triggerType" : "PUSH"
}, {
"hash" : "32883ca0240ef8ef0f3fb7162035a3aff23cdb7d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29293",
"triggerID" : "32883ca0240ef8ef0f3fb7162035a3aff23cdb7d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 32883ca0240ef8ef0f3fb7162035a3aff23cdb7d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29293)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zuston commented on a change in pull request #18306: [FLINK-25445] No need to create local recovery dirs when disabled loc…
Posted by GitBox <gi...@apache.org>.
zuston commented on a change in pull request #18306:
URL: https://github.com/apache/flink/pull/18306#discussion_r785844211
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/LocalRecoveryConfig.java
##########
@@ -58,4 +63,24 @@ public String toString() {
+ localStateDirectories
+ '}';
}
+
+ /**
+ * An {@link NullOfDirProviderException} is thrown when the {@link
+ * LocalRecoveryDirectoryProvider} is null.
+ */
+ @Internal
+ public static class NullOfDirProviderException extends RuntimeException {
+ public NullOfDirProviderException(String message, Throwable cause) {
+ super(message, cause);
+ }
+
+ public NullOfDirProviderException(String message) {
+ super(message);
+ }
+
+ public NullOfDirProviderException() {
+ this(
+ "When task local recovery is enabled, the NullPointerException of LocalRecoveryDirectoryProvider should not happen.");
+ }
+ }
Review comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18306: [FLINK-25445] No need to create local recovery dirs when disabled loc…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18306:
URL: https://github.com/apache/flink/pull/18306#issuecomment-1008234006
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7d972d43be4188ad9dad3d53e45f5710fdb8b754",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29144",
"triggerID" : "7d972d43be4188ad9dad3d53e45f5710fdb8b754",
"triggerType" : "PUSH"
}, {
"hash" : "32883ca0240ef8ef0f3fb7162035a3aff23cdb7d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29293",
"triggerID" : "32883ca0240ef8ef0f3fb7162035a3aff23cdb7d",
"triggerType" : "PUSH"
}, {
"hash" : "3efa1bed35ddcfcf74e1de739ebc355e404eb73b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29505",
"triggerID" : "3efa1bed35ddcfcf74e1de739ebc355e404eb73b",
"triggerType" : "PUSH"
}, {
"hash" : "7c716c0de1cfe85b1c67d44c6a94454a2700c043",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29538",
"triggerID" : "7c716c0de1cfe85b1c67d44c6a94454a2700c043",
"triggerType" : "PUSH"
}, {
"hash" : "f8c4b9cfcf8dd3fc85472dac9b8165c7c2c846dc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f8c4b9cfcf8dd3fc85472dac9b8165c7c2c846dc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7c716c0de1cfe85b1c67d44c6a94454a2700c043 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29538)
* f8c4b9cfcf8dd3fc85472dac9b8165c7c2c846dc UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] XComp merged pull request #18306: [FLINK-25445] No need to create local recovery dirs when disabled loc…
Posted by GitBox <gi...@apache.org>.
XComp merged pull request #18306:
URL: https://github.com/apache/flink/pull/18306
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18306: [FLINK-25445] No need to create local recovery dirs when disabled loc…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18306:
URL: https://github.com/apache/flink/pull/18306#issuecomment-1008234006
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7d972d43be4188ad9dad3d53e45f5710fdb8b754",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29144",
"triggerID" : "7d972d43be4188ad9dad3d53e45f5710fdb8b754",
"triggerType" : "PUSH"
}, {
"hash" : "32883ca0240ef8ef0f3fb7162035a3aff23cdb7d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29293",
"triggerID" : "32883ca0240ef8ef0f3fb7162035a3aff23cdb7d",
"triggerType" : "PUSH"
}, {
"hash" : "3efa1bed35ddcfcf74e1de739ebc355e404eb73b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29505",
"triggerID" : "3efa1bed35ddcfcf74e1de739ebc355e404eb73b",
"triggerType" : "PUSH"
}, {
"hash" : "7c716c0de1cfe85b1c67d44c6a94454a2700c043",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29538",
"triggerID" : "7c716c0de1cfe85b1c67d44c6a94454a2700c043",
"triggerType" : "PUSH"
}, {
"hash" : "f8c4b9cfcf8dd3fc85472dac9b8165c7c2c846dc",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30056",
"triggerID" : "f8c4b9cfcf8dd3fc85472dac9b8165c7c2c846dc",
"triggerType" : "PUSH"
}, {
"hash" : "f8c4b9cfcf8dd3fc85472dac9b8165c7c2c846dc",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30056",
"triggerID" : "1021036013",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* f8c4b9cfcf8dd3fc85472dac9b8165c7c2c846dc Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30056)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zuston commented on a change in pull request #18306: [FLINK-25445] No need to create local recovery dirs when disabled loc…
Posted by GitBox <gi...@apache.org>.
zuston commented on a change in pull request #18306:
URL: https://github.com/apache/flink/pull/18306#discussion_r782161943
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/LocalRecoveryConfig.java
##########
@@ -31,11 +29,10 @@
private final boolean localRecoveryEnabled;
/** Encapsulates the root directories and the subtask-specific path. */
- @Nonnull private final LocalRecoveryDirectoryProvider localStateDirectories;
+ private final LocalRecoveryDirectoryProvider localStateDirectories;
public LocalRecoveryConfig(
- boolean localRecoveryEnabled,
- @Nonnull LocalRecoveryDirectoryProvider directoryProvider) {
+ boolean localRecoveryEnabled, LocalRecoveryDirectoryProvider directoryProvider) {
Review comment:
Got it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18306: [FLINK-25445] No need to create local recovery dirs when disabled loc…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18306:
URL: https://github.com/apache/flink/pull/18306#issuecomment-1008234006
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7d972d43be4188ad9dad3d53e45f5710fdb8b754",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29144",
"triggerID" : "7d972d43be4188ad9dad3d53e45f5710fdb8b754",
"triggerType" : "PUSH"
}, {
"hash" : "32883ca0240ef8ef0f3fb7162035a3aff23cdb7d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29293",
"triggerID" : "32883ca0240ef8ef0f3fb7162035a3aff23cdb7d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7d972d43be4188ad9dad3d53e45f5710fdb8b754 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29144)
* 32883ca0240ef8ef0f3fb7162035a3aff23cdb7d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29293)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18306: [FLINK-25445] No need to create local recovery dirs when disabled loc…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18306:
URL: https://github.com/apache/flink/pull/18306#issuecomment-1008234006
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7d972d43be4188ad9dad3d53e45f5710fdb8b754",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29144",
"triggerID" : "7d972d43be4188ad9dad3d53e45f5710fdb8b754",
"triggerType" : "PUSH"
}, {
"hash" : "32883ca0240ef8ef0f3fb7162035a3aff23cdb7d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "32883ca0240ef8ef0f3fb7162035a3aff23cdb7d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7d972d43be4188ad9dad3d53e45f5710fdb8b754 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29144)
* 32883ca0240ef8ef0f3fb7162035a3aff23cdb7d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zuston commented on pull request #18306: [FLINK-25445] No need to create local recovery dirs when disabled loc…
Posted by GitBox <gi...@apache.org>.
zuston commented on pull request #18306:
URL: https://github.com/apache/flink/pull/18306#issuecomment-1009959147
Could you help review? @dmvk Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dmvk commented on pull request #18306: [FLINK-25445] No need to create local recovery dirs when disabled loc…
Posted by GitBox <gi...@apache.org>.
dmvk commented on pull request #18306:
URL: https://github.com/apache/flink/pull/18306#issuecomment-1010010732
The behavior of the local recovery highly depends on the state backend. AFAIK heap state backend still doesn't support it. For RocksDB you can find some context in https://issues.apache.org/jira/browse/FLINK-15507
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18306: [FLINK-25445] No need to create local recovery dirs when disabled loc…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18306:
URL: https://github.com/apache/flink/pull/18306#issuecomment-1008234006
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7d972d43be4188ad9dad3d53e45f5710fdb8b754",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29144",
"triggerID" : "7d972d43be4188ad9dad3d53e45f5710fdb8b754",
"triggerType" : "PUSH"
}, {
"hash" : "32883ca0240ef8ef0f3fb7162035a3aff23cdb7d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29293",
"triggerID" : "32883ca0240ef8ef0f3fb7162035a3aff23cdb7d",
"triggerType" : "PUSH"
}, {
"hash" : "3efa1bed35ddcfcf74e1de739ebc355e404eb73b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29505",
"triggerID" : "3efa1bed35ddcfcf74e1de739ebc355e404eb73b",
"triggerType" : "PUSH"
}, {
"hash" : "7c716c0de1cfe85b1c67d44c6a94454a2700c043",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29538",
"triggerID" : "7c716c0de1cfe85b1c67d44c6a94454a2700c043",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3efa1bed35ddcfcf74e1de739ebc355e404eb73b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29505)
* 7c716c0de1cfe85b1c67d44c6a94454a2700c043 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29538)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18306: [FLINK-25445] No need to create local recovery dirs when disabled loc…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18306:
URL: https://github.com/apache/flink/pull/18306#issuecomment-1008234006
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7d972d43be4188ad9dad3d53e45f5710fdb8b754",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29144",
"triggerID" : "7d972d43be4188ad9dad3d53e45f5710fdb8b754",
"triggerType" : "PUSH"
}, {
"hash" : "32883ca0240ef8ef0f3fb7162035a3aff23cdb7d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29293",
"triggerID" : "32883ca0240ef8ef0f3fb7162035a3aff23cdb7d",
"triggerType" : "PUSH"
}, {
"hash" : "3efa1bed35ddcfcf74e1de739ebc355e404eb73b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29505",
"triggerID" : "3efa1bed35ddcfcf74e1de739ebc355e404eb73b",
"triggerType" : "PUSH"
}, {
"hash" : "7c716c0de1cfe85b1c67d44c6a94454a2700c043",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29538",
"triggerID" : "7c716c0de1cfe85b1c67d44c6a94454a2700c043",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7c716c0de1cfe85b1c67d44c6a94454a2700c043 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29538)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18306: [FLINK-25445] No need to create local recovery dirs when disabled loc…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18306:
URL: https://github.com/apache/flink/pull/18306#issuecomment-1008234006
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7d972d43be4188ad9dad3d53e45f5710fdb8b754",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7d972d43be4188ad9dad3d53e45f5710fdb8b754",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7d972d43be4188ad9dad3d53e45f5710fdb8b754 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zuston commented on pull request #18306: [FLINK-25445] No need to create local recovery dirs when disabled loc…
Posted by GitBox <gi...@apache.org>.
zuston commented on pull request #18306:
URL: https://github.com/apache/flink/pull/18306#issuecomment-1021036013
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18306: [FLINK-25445] No need to create local recovery dirs when disabled loc…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18306:
URL: https://github.com/apache/flink/pull/18306#issuecomment-1008234006
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18306: [FLINK-25445] No need to create local recovery dirs when disabled loc…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18306:
URL: https://github.com/apache/flink/pull/18306#issuecomment-1008234006
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7d972d43be4188ad9dad3d53e45f5710fdb8b754",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29144",
"triggerID" : "7d972d43be4188ad9dad3d53e45f5710fdb8b754",
"triggerType" : "PUSH"
}, {
"hash" : "32883ca0240ef8ef0f3fb7162035a3aff23cdb7d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29293",
"triggerID" : "32883ca0240ef8ef0f3fb7162035a3aff23cdb7d",
"triggerType" : "PUSH"
}, {
"hash" : "3efa1bed35ddcfcf74e1de739ebc355e404eb73b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29505",
"triggerID" : "3efa1bed35ddcfcf74e1de739ebc355e404eb73b",
"triggerType" : "PUSH"
}, {
"hash" : "7c716c0de1cfe85b1c67d44c6a94454a2700c043",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29538",
"triggerID" : "7c716c0de1cfe85b1c67d44c6a94454a2700c043",
"triggerType" : "PUSH"
}, {
"hash" : "f8c4b9cfcf8dd3fc85472dac9b8165c7c2c846dc",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30056",
"triggerID" : "f8c4b9cfcf8dd3fc85472dac9b8165c7c2c846dc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7c716c0de1cfe85b1c67d44c6a94454a2700c043 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29538)
* f8c4b9cfcf8dd3fc85472dac9b8165c7c2c846dc Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30056)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18306: [FLINK-25445] No need to create local recovery dirs when disabled loc…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18306:
URL: https://github.com/apache/flink/pull/18306#issuecomment-1008234192
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 7d972d43be4188ad9dad3d53e45f5710fdb8b754 (Sun Jan 09 05:35:41 UTC 2022)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-25445).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18306: [FLINK-25445] No need to create local recovery dirs when disabled loc…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18306:
URL: https://github.com/apache/flink/pull/18306#issuecomment-1008234006
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7d972d43be4188ad9dad3d53e45f5710fdb8b754",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29144",
"triggerID" : "7d972d43be4188ad9dad3d53e45f5710fdb8b754",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7d972d43be4188ad9dad3d53e45f5710fdb8b754 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29144)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18306: [FLINK-25445] No need to create local recovery dirs when disabled loc…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18306:
URL: https://github.com/apache/flink/pull/18306#issuecomment-1008234006
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7d972d43be4188ad9dad3d53e45f5710fdb8b754",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29144",
"triggerID" : "7d972d43be4188ad9dad3d53e45f5710fdb8b754",
"triggerType" : "PUSH"
}, {
"hash" : "32883ca0240ef8ef0f3fb7162035a3aff23cdb7d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29293",
"triggerID" : "32883ca0240ef8ef0f3fb7162035a3aff23cdb7d",
"triggerType" : "PUSH"
}, {
"hash" : "3efa1bed35ddcfcf74e1de739ebc355e404eb73b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3efa1bed35ddcfcf74e1de739ebc355e404eb73b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 32883ca0240ef8ef0f3fb7162035a3aff23cdb7d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29293)
* 3efa1bed35ddcfcf74e1de739ebc355e404eb73b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18306: [FLINK-25445] No need to create local recovery dirs when disabled loc…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18306:
URL: https://github.com/apache/flink/pull/18306#issuecomment-1008234006
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7d972d43be4188ad9dad3d53e45f5710fdb8b754",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29144",
"triggerID" : "7d972d43be4188ad9dad3d53e45f5710fdb8b754",
"triggerType" : "PUSH"
}, {
"hash" : "32883ca0240ef8ef0f3fb7162035a3aff23cdb7d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29293",
"triggerID" : "32883ca0240ef8ef0f3fb7162035a3aff23cdb7d",
"triggerType" : "PUSH"
}, {
"hash" : "3efa1bed35ddcfcf74e1de739ebc355e404eb73b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29505",
"triggerID" : "3efa1bed35ddcfcf74e1de739ebc355e404eb73b",
"triggerType" : "PUSH"
}, {
"hash" : "7c716c0de1cfe85b1c67d44c6a94454a2700c043",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7c716c0de1cfe85b1c67d44c6a94454a2700c043",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3efa1bed35ddcfcf74e1de739ebc355e404eb73b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29505)
* 7c716c0de1cfe85b1c67d44c6a94454a2700c043 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18306: [FLINK-25445] No need to create local recovery dirs when disabled loc…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18306:
URL: https://github.com/apache/flink/pull/18306#issuecomment-1008234006
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7d972d43be4188ad9dad3d53e45f5710fdb8b754",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29144",
"triggerID" : "7d972d43be4188ad9dad3d53e45f5710fdb8b754",
"triggerType" : "PUSH"
}, {
"hash" : "32883ca0240ef8ef0f3fb7162035a3aff23cdb7d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29293",
"triggerID" : "32883ca0240ef8ef0f3fb7162035a3aff23cdb7d",
"triggerType" : "PUSH"
}, {
"hash" : "3efa1bed35ddcfcf74e1de739ebc355e404eb73b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29505",
"triggerID" : "3efa1bed35ddcfcf74e1de739ebc355e404eb73b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3efa1bed35ddcfcf74e1de739ebc355e404eb73b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29505)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org