[GitHub] [spark] peter-toth commented on a diff in pull request #36440: [SPARK-37259][SQL] Support CTE and temp table queries with MSSQL JDBC

[GitBox <gi...@apache.org>]

peter-toth commented on code in PR #36440:
URL: https://github.com/apache/spark/pull/36440#discussion_r866631665


##########
connector/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/MsSqlServerIntegrationSuite.scala:
##########
@@ -374,4 +375,58 @@ class MsSqlServerIntegrationSuite extends DockerJDBCIntegrationSuite {
     val filtered = df.where(col("c") === 0).collect()
     assert(filtered.length == 0)
   }
+
+  test("prepareQuery and query JDBC options") {

Review Comment:
   Added in https://github.com/apache/spark/pull/36440/commits/aca8fa236f2de5144eb68e970f3b00255433ab7b



##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCOptions.scala:
##########
@@ -222,6 +222,8 @@ class JDBCOptions(
 
   // User specified JDBC connection provider name
   val connectionProviderName = parameters.get(JDBC_CONNECTION_PROVIDER)
+
+  val prepareQuery = parameters.get(JDBC_PREPARE_QUERY).map(_ + " ").getOrElse("")

Review Comment:
   Fixed in https://github.com/apache/spark/pull/36440/commits/aca8fa236f2de5144eb68e970f3b00255433ab7b



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org