[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4182: Generate inverted index in purge task if it exists

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on a change in pull request #4182: Generate inverted index in purge task if it exists
URL: https://github.com/apache/incubator-pinot/pull/4182#discussion_r280549375
 
 

 ##########
 File path: pinot-core/src/main/java/org/apache/pinot/core/minion/SegmentPurger.java
 ##########
 @@ -100,14 +105,28 @@ public File purgeSegment()
         config.setSegmentTimeUnit(segmentMetadata.getTimeUnit());
       }
 
+      // Generate inverted index if it exists in the original segment
+      // TODO: once the column metadata correctly reflects whether inverted index exists for the column, use that
 
 Review comment:
   SegmentDirectory is an abstraction layer on top of files, which can handle all segment format properly.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org