You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/02/18 12:56:58 UTC
[GitHub] [airflow] aduico-peax opened a new pull request #21666: Change upgrade to init
aduico-peax opened a new pull request #21666:
URL: https://github.com/apache/airflow/pull/21666
Change `airflow db upgrade` to `airflow db init` in setting-up-the-database.rst
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #21666: Change upgrade to init
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #21666:
URL: https://github.com/apache/airflow/pull/21666#issuecomment-1044486264
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #21666: Change upgrade to init
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #21666:
URL: https://github.com/apache/airflow/pull/21666#discussion_r810111316
##########
File path: docs/apache-airflow/installation/setting-up-the-database.rst
##########
@@ -22,7 +22,7 @@ Airflow requires a database. If you're just experimenting and learning Airflow,
default SQLite option. If you don't want to use SQLite, then take a look at
:doc:`/howto/set-up-database` to setup a different database.
-Usually, you need to run ``airflow db upgrade`` in order to create the database schema that Airflow can use.
+Usually, you need to run ``airflow db init`` in order to create the database schema that Airflow can use.
Review comment:
Agree with Jarek
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #21666: Change upgrade to init
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #21666:
URL: https://github.com/apache/airflow/pull/21666#issuecomment-1044533233
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #21666: Change upgrade to init
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #21666:
URL: https://github.com/apache/airflow/pull/21666#discussion_r810015790
##########
File path: docs/apache-airflow/installation/setting-up-the-database.rst
##########
@@ -22,7 +22,7 @@ Airflow requires a database. If you're just experimenting and learning Airflow,
default SQLite option. If you don't want to use SQLite, then take a look at
:doc:`/howto/set-up-database` to setup a different database.
-Usually, you need to run ``airflow db upgrade`` in order to create the database schema that Airflow can use.
+Usually, you need to run ``airflow db init`` in order to create the database schema that Airflow can use.
Review comment:
Well. This is not entirely true.
* `airflow db upgrade` creates DB schema
* `airflow db init` does what upgrade does but it also adds default connections for example - which might be not expected.
I'd say we should describe both usages here.
##########
File path: docs/apache-airflow/installation/setting-up-the-database.rst
##########
@@ -22,7 +22,7 @@ Airflow requires a database. If you're just experimenting and learning Airflow,
default SQLite option. If you don't want to use SQLite, then take a look at
:doc:`/howto/set-up-database` to setup a different database.
-Usually, you need to run ``airflow db upgrade`` in order to create the database schema that Airflow can use.
+Usually, you need to run ``airflow db init`` in order to create the database schema that Airflow can use.
Review comment:
Well. This is not entirely true.
* `airflow db upgrade` creates DB schema
* `airflow db init` does what upgrade does but it also adds default connections for example - which might be not expected/wanted
I'd say we should describe both usages here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #21666: Change upgrade to init
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #21666:
URL: https://github.com/apache/airflow/pull/21666#discussion_r810015790
##########
File path: docs/apache-airflow/installation/setting-up-the-database.rst
##########
@@ -22,7 +22,7 @@ Airflow requires a database. If you're just experimenting and learning Airflow,
default SQLite option. If you don't want to use SQLite, then take a look at
:doc:`/howto/set-up-database` to setup a different database.
-Usually, you need to run ``airflow db upgrade`` in order to create the database schema that Airflow can use.
+Usually, you need to run ``airflow db init`` in order to create the database schema that Airflow can use.
Review comment:
Well. This is not entirely true.
* `airflow db upgrade` creates DB schema
* `airflow db init` also does what upgrade does but it also adds default connections for example - which might be not expected.
I'd say we should describe both usages here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #21666: Change upgrade to init
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #21666:
URL: https://github.com/apache/airflow/pull/21666#discussion_r810015790
##########
File path: docs/apache-airflow/installation/setting-up-the-database.rst
##########
@@ -22,7 +22,7 @@ Airflow requires a database. If you're just experimenting and learning Airflow,
default SQLite option. If you don't want to use SQLite, then take a look at
:doc:`/howto/set-up-database` to setup a different database.
-Usually, you need to run ``airflow db upgrade`` in order to create the database schema that Airflow can use.
+Usually, you need to run ``airflow db init`` in order to create the database schema that Airflow can use.
Review comment:
Well. This is not entirely true. When you have new DB:
* `airflow db upgrade` creates DB schema
* `airflow db init` does what upgrade does but it also adds default connections for example - which might be not expected/wanted
I'd say we should describe both usages here.
I've seen contradicting advices on that and while I agree "db upgrade" is not the best command to "install" airflow - it has been recommended as the way to start clean DB without the extra connections created.
Maybe we should change those commands to have better names in the future, but for now documenting the two usages is I think good idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #21666: Change upgrade to init
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #21666:
URL: https://github.com/apache/airflow/pull/21666#discussion_r810015790
##########
File path: docs/apache-airflow/installation/setting-up-the-database.rst
##########
@@ -22,7 +22,7 @@ Airflow requires a database. If you're just experimenting and learning Airflow,
default SQLite option. If you don't want to use SQLite, then take a look at
:doc:`/howto/set-up-database` to setup a different database.
-Usually, you need to run ``airflow db upgrade`` in order to create the database schema that Airflow can use.
+Usually, you need to run ``airflow db init`` in order to create the database schema that Airflow can use.
Review comment:
Well. This is not entirely true.
* `airflow db upgrade` creates DB schema
* `airflow db init` does what upgrade does but it also adds default connections for example - which might be not expected/wanted
I'd say we should describe both usages here.
I've seen contradicting advices on that and while I agree "db upgrade" is not the best command to "install" airflow - it has been recommended as the way to start clean DB without the extra connections created.
Maybe we should change those commands to have better names in the future, but for now documenting the two usages is I think good idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org