[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1226: MINIFICPP-1673: ProcessSession::write/ProcessSession::append should o…

[GitBox <gi...@apache.org>]

adamdebreceni commented on a change in pull request #1226:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1226#discussion_r768631049



##########
File path: libminifi/src/core/ProcessSession.cpp
##########
@@ -212,6 +212,10 @@ void ProcessSession::transfer(const std::shared_ptr<core::FlowFile> &flow, Relat
 }
 
 void ProcessSession::write(const std::shared_ptr<core::FlowFile> &flow, OutputStreamCallback *callback) {
+  gsl_ExpectsAudit(_updatedFlowFiles.contains(flow->getUUID())

Review comment:
       as we provide access to the session to custom code through the script extension, this feels like an invariant we should always check, turning the `std::map`s (and the `_clonedFlowFiles` vector) into `std::unordered_map`s would make the check an `O(1)` operation




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org