You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by sitalkedia <gi...@git.apache.org> on 2016/04/03 00:58:13 UTC
[GitHub] spark pull request: [SPARK-14056] Appends s3 specific configuratio...
Github user sitalkedia commented on a diff in the pull request:
https://github.com/apache/spark/pull/11876#discussion_r58301462
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkHadoopUtil.scala ---
@@ -74,13 +74,12 @@ class SparkHadoopUtil extends Logging {
}
}
- /**
- * Return an appropriate (subclass) of Configuration. Creating config can initializes some Hadoop
- * subsystems.
- */
- def newConfiguration(conf: SparkConf): Configuration = {
- val hadoopConf = new Configuration()
+ /**
+ * Appends S3-specific, spark.hadoop.*, and spark.spark.buffer.size configurations to a Hadoop
--- End diff --
@marmbrus - the job run a simple hive query to create a table. From what I understand from the code is the hiveConf is being initialized which is does not include spark.hadoo.* configurations and that hiveConf is being used to initialized the HadoopRDD. So the HadoopRDD does not contain any spark.hadoop.* configurations. This fix is meant to resolve that issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org