You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Vaibhav Khanduja <va...@yahoo.com> on 2015/11/09 02:16:26 UTC

Re: Review Request 40062: MESOS-2315 Deprecate/Remove CommandInfo::ContainerInfo

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40062/
-----------------------------------------------------------

(Updated Nov. 9, 2015, 1:16 a.m.)


Review request for mesos and Adam B.


Changes
-------

Fixed defect number in summary


Summary (updated)
-----------------

MESOS-2315 Deprecate/Remove CommandInfo::ContainerInfo


Bugs: MESOS-2315
    https://issues.apache.org/jira/browse/MESOS-2315


Repository: mesos


Description
-------

MESIS-2315 Deprecate/Remove CommandInfo::ContainerInfo


Diffs (updated)
-----

  include/mesos/mesos.proto 5ad48bd376c34dd495399b62fa0bd37ddcc5518b 
  src/slave/containerizer/mesos/containerizer.cpp 08243b61c1c277da7609bc910323cc1e27ff5cd4 
  src/slave/slave.cpp 535adc3b17d5af3fe811a8e2505f126a28212dbf 
  src/tests/slave_tests.cpp ddd01104d044b54664b3b1eefdde3f73b8f6d598 

Diff: https://reviews.apache.org/r/40062/diff/


Testing
-------

sudo make check


Thanks,

Vaibhav Khanduja

Re: Review Request 40062: MESOS-2315 Deprecate/Remove CommandInfo::ContainerInfo

Posted by Vaibhav Khanduja <va...@yahoo.com>.

> On Nov. 9, 2015, 7:27 p.m., Joseph Wu wrote:
> > include/mesos/mesos.proto, line 372
> > <https://reviews.apache.org/r/40062/diff/2/?file=1119368#file1119368line372>
> >
> >     Should we also remove this from v1/mesos.proto?

Fixed


- Vaibhav


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40062/#review105723
-----------------------------------------------------------


On Nov. 9, 2015, 1:16 a.m., Vaibhav Khanduja wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40062/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2015, 1:16 a.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-2315
>     https://issues.apache.org/jira/browse/MESOS-2315
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> MESIS-2315 Deprecate/Remove CommandInfo::ContainerInfo
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 5ad48bd376c34dd495399b62fa0bd37ddcc5518b 
>   src/slave/containerizer/mesos/containerizer.cpp 08243b61c1c277da7609bc910323cc1e27ff5cd4 
>   src/slave/slave.cpp 535adc3b17d5af3fe811a8e2505f126a28212dbf 
>   src/tests/slave_tests.cpp ddd01104d044b54664b3b1eefdde3f73b8f6d598 
> 
> Diff: https://reviews.apache.org/r/40062/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Vaibhav Khanduja
> 
>

Re: Review Request 40062: MESOS-2315 Deprecate/Remove CommandInfo::ContainerInfo

Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40062/#review105723
-----------------------------------------------------------



include/mesos/mesos.proto 
<https://reviews.apache.org/r/40062/#comment164351>

    Should we also remove this from v1/mesos.proto?


- Joseph Wu


On Nov. 8, 2015, 5:16 p.m., Vaibhav Khanduja wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40062/
> -----------------------------------------------------------
> 
> (Updated Nov. 8, 2015, 5:16 p.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-2315
>     https://issues.apache.org/jira/browse/MESOS-2315
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> MESIS-2315 Deprecate/Remove CommandInfo::ContainerInfo
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 5ad48bd376c34dd495399b62fa0bd37ddcc5518b 
>   src/slave/containerizer/mesos/containerizer.cpp 08243b61c1c277da7609bc910323cc1e27ff5cd4 
>   src/slave/slave.cpp 535adc3b17d5af3fe811a8e2505f126a28212dbf 
>   src/tests/slave_tests.cpp ddd01104d044b54664b3b1eefdde3f73b8f6d598 
> 
> Diff: https://reviews.apache.org/r/40062/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Vaibhav Khanduja
> 
>

Re: Review Request 40062: MESOS-2315 Deprecate/Remove CommandInfo::ContainerInfo

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40062/#review105795
-----------------------------------------------------------


Patch looks great!

Reviews applied: [40062]

All tests passed.

- Mesos ReviewBot


On Nov. 10, 2015, 5:16 a.m., Vaibhav Khanduja wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40062/
> -----------------------------------------------------------
> 
> (Updated Nov. 10, 2015, 5:16 a.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-2315
>     https://issues.apache.org/jira/browse/MESOS-2315
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> MESIS-2315 Deprecate/Remove CommandInfo::ContainerInfo
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 5ad48bd376c34dd495399b62fa0bd37ddcc5518b 
>   include/mesos/v1/mesos.proto e71ddda7f23f2272ce8eb00f358c66fce205c13b 
>   src/slave/containerizer/mesos/containerizer.cpp 08243b61c1c277da7609bc910323cc1e27ff5cd4 
>   src/slave/slave.cpp 535adc3b17d5af3fe811a8e2505f126a28212dbf 
>   src/tests/slave_tests.cpp ddd01104d044b54664b3b1eefdde3f73b8f6d598 
> 
> Diff: https://reviews.apache.org/r/40062/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Vaibhav Khanduja
> 
>

Re: Review Request 40062: MESOS-2315 Deprecate/Remove CommandInfo::ContainerInfo

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40062/#review105790
-----------------------------------------------------------


Bad patch!

Reviews applied: [40062]

Failed command: ./support/apply-review.sh -n -r 40062

Error:
 2015-11-10 05:28:49 URL:https://reviews.apache.org/r/40062/diff/raw/ [4997/4997] -> "40062.patch" [1]
error: patch failed: src/slave/slave.cpp:3341
error: src/slave/slave.cpp: patch does not apply
error: patch failed: src/tests/slave_tests.cpp:618
error: src/tests/slave_tests.cpp: patch does not apply
Failed to apply patch

- Mesos ReviewBot


On Nov. 10, 2015, 5:16 a.m., Vaibhav Khanduja wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40062/
> -----------------------------------------------------------
> 
> (Updated Nov. 10, 2015, 5:16 a.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-2315
>     https://issues.apache.org/jira/browse/MESOS-2315
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> MESIS-2315 Deprecate/Remove CommandInfo::ContainerInfo
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 5ad48bd376c34dd495399b62fa0bd37ddcc5518b 
>   include/mesos/v1/mesos.proto e71ddda7f23f2272ce8eb00f358c66fce205c13b 
>   src/slave/containerizer/mesos/containerizer.cpp 08243b61c1c277da7609bc910323cc1e27ff5cd4 
>   src/slave/slave.cpp 535adc3b17d5af3fe811a8e2505f126a28212dbf 
>   src/tests/slave_tests.cpp ddd01104d044b54664b3b1eefdde3f73b8f6d598 
> 
> Diff: https://reviews.apache.org/r/40062/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Vaibhav Khanduja
> 
>

Re: Review Request 40062: MESOS-2315 Deprecate/Remove CommandInfo::ContainerInfo

Posted by Adam B <ad...@mesosphere.io>.

> On Dec. 14, 2015, 5:47 p.m., Adam B wrote:
> > Ship It!

Only missing piece is an API change mention in the CHANGELOG. I'll add that.


- Adam


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40062/#review110366
-----------------------------------------------------------


On Nov. 9, 2015, 9:16 p.m., Vaibhav Khanduja wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40062/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2015, 9:16 p.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-2315
>     https://issues.apache.org/jira/browse/MESOS-2315
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> MESIS-2315 Deprecate/Remove CommandInfo::ContainerInfo
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 5ad48bd376c34dd495399b62fa0bd37ddcc5518b 
>   include/mesos/v1/mesos.proto e71ddda7f23f2272ce8eb00f358c66fce205c13b 
>   src/slave/containerizer/mesos/containerizer.cpp 08243b61c1c277da7609bc910323cc1e27ff5cd4 
>   src/slave/slave.cpp 535adc3b17d5af3fe811a8e2505f126a28212dbf 
>   src/tests/slave_tests.cpp ddd01104d044b54664b3b1eefdde3f73b8f6d598 
> 
> Diff: https://reviews.apache.org/r/40062/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Vaibhav Khanduja
> 
>

Re: Review Request 40062: MESOS-2315 Deprecate/Remove CommandInfo::ContainerInfo

Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40062/#review110366
-----------------------------------------------------------

Ship it!


Ship It!

- Adam B


On Nov. 9, 2015, 9:16 p.m., Vaibhav Khanduja wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40062/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2015, 9:16 p.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-2315
>     https://issues.apache.org/jira/browse/MESOS-2315
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> MESIS-2315 Deprecate/Remove CommandInfo::ContainerInfo
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 5ad48bd376c34dd495399b62fa0bd37ddcc5518b 
>   include/mesos/v1/mesos.proto e71ddda7f23f2272ce8eb00f358c66fce205c13b 
>   src/slave/containerizer/mesos/containerizer.cpp 08243b61c1c277da7609bc910323cc1e27ff5cd4 
>   src/slave/slave.cpp 535adc3b17d5af3fe811a8e2505f126a28212dbf 
>   src/tests/slave_tests.cpp ddd01104d044b54664b3b1eefdde3f73b8f6d598 
> 
> Diff: https://reviews.apache.org/r/40062/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Vaibhav Khanduja
> 
>

Re: Review Request 40062: MESOS-2315 Deprecate/Remove CommandInfo::ContainerInfo

Posted by Vaibhav Khanduja <va...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40062/
-----------------------------------------------------------

(Updated Nov. 10, 2015, 5:16 a.m.)


Review request for mesos and Adam B.


Changes
-------

Addressed Comments


Bugs: MESOS-2315
    https://issues.apache.org/jira/browse/MESOS-2315


Repository: mesos


Description
-------

MESIS-2315 Deprecate/Remove CommandInfo::ContainerInfo


Diffs (updated)
-----

  include/mesos/mesos.proto 5ad48bd376c34dd495399b62fa0bd37ddcc5518b 
  include/mesos/v1/mesos.proto e71ddda7f23f2272ce8eb00f358c66fce205c13b 
  src/slave/containerizer/mesos/containerizer.cpp 08243b61c1c277da7609bc910323cc1e27ff5cd4 
  src/slave/slave.cpp 535adc3b17d5af3fe811a8e2505f126a28212dbf 
  src/tests/slave_tests.cpp ddd01104d044b54664b3b1eefdde3f73b8f6d598 

Diff: https://reviews.apache.org/r/40062/diff/


Testing
-------

sudo make check


Thanks,

Vaibhav Khanduja

Re: Review Request 40062: MESOS-2315 Deprecate/Remove CommandInfo::ContainerInfo

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40062/#review105636
-----------------------------------------------------------


Patch looks great!

Reviews applied: [40062]

All tests passed.

- Mesos ReviewBot


On Nov. 9, 2015, 1:16 a.m., Vaibhav Khanduja wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40062/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2015, 1:16 a.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-2315
>     https://issues.apache.org/jira/browse/MESOS-2315
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> MESIS-2315 Deprecate/Remove CommandInfo::ContainerInfo
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 5ad48bd376c34dd495399b62fa0bd37ddcc5518b 
>   src/slave/containerizer/mesos/containerizer.cpp 08243b61c1c277da7609bc910323cc1e27ff5cd4 
>   src/slave/slave.cpp 535adc3b17d5af3fe811a8e2505f126a28212dbf 
>   src/tests/slave_tests.cpp ddd01104d044b54664b3b1eefdde3f73b8f6d598 
> 
> Diff: https://reviews.apache.org/r/40062/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Vaibhav Khanduja
> 
>