You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "Baoyuantop (via GitHub)" <gi...@apache.org> on 2023/03/15 08:29:07 UTC
[GitHub] [apisix-dashboard] Baoyuantop opened a new pull request, #2770: fix: remove ssl check in redirect https
Baoyuantop opened a new pull request, #2770:
URL: https://github.com/apache/apisix-dashboard/pull/2770
Please answer these questions before submitting a pull request, **or your PR will get closed**.
**Why submit this pull request?**
- [x] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- [ ] Backport patches
**What changes will this PR take into?**
Please update this section with detailed description.
**Related issues**
fix/resolve #2445
**Checklist:**
- [ ] Did you explain what problem does this PR solve? Or what new features have been added?
- [ ] Have you added corresponding test cases?
- [ ] Have you modified the corresponding document?
- [ ] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] SkyeYoung commented on a diff in pull request #2770: fix: remove ssl check in redirect https
Posted by "SkyeYoung (via GitHub)" <gi...@apache.org>.
SkyeYoung commented on code in PR #2770:
URL: https://github.com/apache/apisix-dashboard/pull/2770#discussion_r1144514311
##########
web/src/pages/Route/Create.tsx:
##########
@@ -260,17 +260,10 @@ const Page: React.FC<Props> = (props) => {
if (nextStep === 2) {
if (step === 1) {
form1.validateFields().then((value) => {
- const { redirectOption, hosts } = value;
- const filterHosts = hosts.filter(Boolean);
- Promise.all([
- redirectOption === 'forceHttps' && filterHosts.length !== 0
- ? checkHostWithSSL(hosts)
- : Promise.resolve(),
- checkUniqueName(
- value.name,
- props.route.path.indexOf('edit') > 0 ? (props as any).match.params.rid : '',
- ),
- ]).then(() => {
+ checkUniqueName(
+ value.name,
+ props.route.path.indexOf('edit') > 0 ? (props as any).match.params.rid : '',
Review Comment:
type?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] Baoyuantop commented on pull request #2770: fix: remove ssl check in redirect https
Posted by "Baoyuantop (via GitHub)" <gi...@apache.org>.
Baoyuantop commented on PR #2770:
URL: https://github.com/apache/apisix-dashboard/pull/2770#issuecomment-1478761762
cc @LiteSun @SkyeYoung
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] Baoyuantop commented on a diff in pull request #2770: fix: remove ssl check in redirect https
Posted by "Baoyuantop (via GitHub)" <gi...@apache.org>.
Baoyuantop commented on code in PR #2770:
URL: https://github.com/apache/apisix-dashboard/pull/2770#discussion_r1144519710
##########
web/src/pages/Route/Create.tsx:
##########
@@ -260,17 +260,10 @@ const Page: React.FC<Props> = (props) => {
if (nextStep === 2) {
if (step === 1) {
form1.validateFields().then((value) => {
- const { redirectOption, hosts } = value;
- const filterHosts = hosts.filter(Boolean);
- Promise.all([
- redirectOption === 'forceHttps' && filterHosts.length !== 0
- ? checkHostWithSSL(hosts)
- : Promise.resolve(),
- checkUniqueName(
- value.name,
- props.route.path.indexOf('edit') > 0 ? (props as any).match.params.rid : '',
- ),
- ]).then(() => {
+ checkUniqueName(
+ value.name,
+ props.route.path.indexOf('edit') > 0 ? (props as any).match.params.rid : '',
Review Comment:
This PR only deletes one function, and the rest of it is not expected to be changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #2770: fix: remove ssl check in redirect https
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2770:
URL: https://github.com/apache/apisix-dashboard/pull/2770#issuecomment-1469596273
## [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2770?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2770](https://codecov.io/gh/apache/apisix-dashboard/pull/2770?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (20728a0) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/85fadb6ac29c6cc7fc292af8d6e9f2ef581642be?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (85fadb6) will **decrease** coverage by `6.99%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 20728a0 differs from pull request most recent head df49702. Consider uploading reports for the commit df49702 to get more accurate results
```diff
@@ Coverage Diff @@
## master #2770 +/- ##
==========================================
- Coverage 76.50% 69.52% -6.99%
==========================================
Files 139 136 -3
Lines 3763 3675 -88
Branches 881 874 -7
==========================================
- Hits 2879 2555 -324
- Misses 884 1120 +236
```
| Flag | Coverage Δ | |
|---|---|---|
| frontend-e2e-test | `69.52% <100.00%> (-6.99%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2770?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [web/src/pages/Route/Create.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2770?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9DcmVhdGUudHN4) | `83.60% <100.00%> (-2.23%)` | :arrow_down: |
... and [15 files with indirect coverage changes](https://codecov.io/gh/apache/apisix-dashboard/pull/2770/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] SkyeYoung merged pull request #2770: fix: remove ssl check in redirect https
Posted by "SkyeYoung (via GitHub)" <gi...@apache.org>.
SkyeYoung merged PR #2770:
URL: https://github.com/apache/apisix-dashboard/pull/2770
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org