[GitHub] [spark] cloud-fan commented on a change in pull request #24269: [SPARK-27341][CORE] fix a deadlock between TaskMemoryManager and UnsafeExternalSorter

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #24269: [SPARK-27341][CORE] fix a deadlock between TaskMemoryManager and UnsafeExternalSorter
URL: https://github.com/apache/spark/pull/24269#discussion_r271169821
 
 

 ##########
 File path: core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeExternalSorter.java
 ##########
 @@ -573,19 +573,28 @@ public boolean hasNext() {
 
     @Override
     public void loadNext() throws IOException {
-      synchronized (this) {
 
 Review comment:
   It's possible but doesn't matter. It's kind of we delay the page releasing a little bit.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org