You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hugegraph.apache.org by "imbajin (via GitHub)" <gi...@apache.org> on 2023/03/01 12:44:55 UTC
[GitHub] [incubator-hugegraph-toolchain] imbajin opened a new pull request, #434: chore: clean store file in all modules
imbajin opened a new pull request, #434:
URL: https://github.com/apache/incubator-hugegraph-toolchain/pull/434
TODO: we need use a better way to download it when building binary package
@simon824 download the file in building or let user download it manually when they need `https`? (and we add a doc/link for it)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-toolchain] javeme merged pull request #434: refact: clean extra store file in all modules
Posted by "javeme (via GitHub)" <gi...@apache.org>.
javeme merged PR #434:
URL: https://github.com/apache/incubator-hugegraph-toolchain/pull/434
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-toolchain] javeme commented on a diff in pull request #434: chore: clean store file in all modules
Posted by "javeme (via GitHub)" <gi...@apache.org>.
javeme commented on code in PR #434:
URL: https://github.com/apache/incubator-hugegraph-toolchain/pull/434#discussion_r1126355306
##########
hugegraph-client/src/main/java/org/apache/hugegraph/util/CommonUtil.java:
##########
@@ -41,4 +46,14 @@ public static void checkMapClass(Object object, Class<?> kClass,
"but got '%s'(%s)", vClass, value, value.getClass());
}
}
+
+ public static void downloadFileByUrl(String url, String destPath) {
+ int connectTimeout = 5000;
+ int readTimeout = 5000;
+ try {
+ FileUtils.copyURLToFile(new URL(url), new File(destPath), connectTimeout, readTimeout);
+ } catch (IOException e) {
+ throw new RuntimeException(e);
Review Comment:
add some message to translate the exception
##########
hugegraph-loader/src/test/java/org/apache/hugegraph/loader/test/functional/FileLoadTest.java:
##########
@@ -2426,6 +2427,10 @@ public void testParquetCompressFile() {
};
if (this.ioUtil instanceof HDFSUtil) {
HDFSUtil hdfsUtil = (HDFSUtil) this.ioUtil;
+ String url = "https://github.com/apache/incubator-hugegraph-doc/" +
Review Comment:
define a const var for the base url, may be it may be changed somehow, so that we don't need update everywhere
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-toolchain] codecov[bot] commented on pull request #434: chore: clean store file in all modules
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #434:
URL: https://github.com/apache/incubator-hugegraph-toolchain/pull/434#issuecomment-1450131419
# [Codecov](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/pull/434?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#434](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/pull/434?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (524faba) into [master](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/commit/30b582afcb0fb39444fc8ccbe1655282d43876bb?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (30b582a) will **decrease** coverage by `0.03%`.
> The diff coverage is `71.42%`.
```diff
@@ Coverage Diff @@
## master #434 +/- ##
============================================
- Coverage 62.55% 62.53% -0.03%
+ Complexity 1866 973 -893
============================================
Files 260 169 -91
Lines 9412 5029 -4383
Branches 872 357 -515
============================================
- Hits 5888 3145 -2743
+ Misses 3142 1705 -1437
+ Partials 382 179 -203
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/pull/434?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ain/java/org/apache/hugegraph/util/CommonUtil.java](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/pull/434?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVnZWdyYXBoL3V0aWwvQ29tbW9uVXRpbC5qYXZh) | `86.95% <71.42%> (-6.80%)` | :arrow_down: |
| [...rg/apache/hugegraph/loader/constant/Constants.java](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/pull/434?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWxvYWRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVnZWdyYXBoL2xvYWRlci9jb25zdGFudC9Db25zdGFudHMuamF2YQ==) | | |
| [...apache/hugegraph/loader/util/HugeClientHolder.java](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/pull/434?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWxvYWRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVnZWdyYXBoL2xvYWRlci91dGlsL0h1Z2VDbGllbnRIb2xkZXIuamF2YQ==) | | |
| [...apache/hugegraph/loader/progress/LoadProgress.java](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/pull/434?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWxvYWRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVnZWdyYXBoL2xvYWRlci9wcm9ncmVzcy9Mb2FkUHJvZ3Jlc3MuamF2YQ==) | | |
| [...ava/org/apache/hugegraph/loader/util/DateUtil.java](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/pull/434?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWxvYWRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVnZWdyYXBoL2xvYWRlci91dGlsL0RhdGVVdGlsLmphdmE=) | | |
| [...che/hugegraph/loader/mapping/BackendStoreInfo.java](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/pull/434?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWxvYWRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVnZWdyYXBoL2xvYWRlci9tYXBwaW5nL0JhY2tlbmRTdG9yZUluZm8uamF2YQ==) | | |
| [...pache/hugegraph/loader/mapping/ElementMapping.java](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/pull/434?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWxvYWRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVnZWdyYXBoL2xvYWRlci9tYXBwaW5nL0VsZW1lbnRNYXBwaW5nLmphdmE=) | | |
| [...pache/hugegraph/loader/builder/ElementBuilder.java](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/pull/434?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWxvYWRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVnZWdyYXBoL2xvYWRlci9idWlsZGVyL0VsZW1lbnRCdWlsZGVyLmphdmE=) | | |
| [.../org/apache/hugegraph/loader/reader/line/Line.java](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/pull/434?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWxvYWRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVnZWdyYXBoL2xvYWRlci9yZWFkZXIvbGluZS9MaW5lLmphdmE=) | | |
| [...ava/org/apache/hugegraph/loader/util/LoadUtil.java](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/pull/434?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWxvYWRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVnZWdyYXBoL2xvYWRlci91dGlsL0xvYWRVdGlsLmphdmE=) | | |
| ... and [82 more](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/pull/434?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-toolchain] imbajin commented on pull request #434: refact: clean extra store file in all modules
Posted by "imbajin (via GitHub)" <gi...@apache.org>.
imbajin commented on PR #434:
URL: https://github.com/apache/incubator-hugegraph-toolchain/pull/434#issuecomment-1474107339
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org