You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/04/28 13:20:45 UTC
[GitHub] [superset] prosdev0107 opened a new pull request, #19883: fix(allow-db-explore): make to check the allow virtual table explore option by default
prosdev0107 opened a new pull request, #19883:
URL: https://github.com/apache/superset/pull/19883
### SUMMARY
The "Allow this database to be explored" setting should be checked by default in the Database Connection UI.
**Description**
When creating a new database connection, users are able to control which actions should be allowed on this database:
By default, Allow this database to be explored is un-checked, however this functionality is enabled on the application.
The functionality of Exploring from SQL Lab should match the Database connection UI checkbox. Since the functionality is enabled, the checkbox should be checked by default when creating a new connection.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE:
[!ScreenShot-BEFORE]: https://user-images.githubusercontent.com/47900232/165761337-588d83db-a192-4e2d-997c-191388536a7d.mov
AFTER:
[!ScreenShot-AFTER]: https://user-images.githubusercontent.com/47900232/165761311-a7c1c606-6613-44b3-8e27-2119d06d78f4.mov
### TESTING INSTRUCTIONS
**How to reproduce the bug**
1. Create a new Database connection. (Google sheets is a quick one to create)
2. Expand the SQL Lab section under the ADVANCED tab, and make sure that Allow this database to be explored is disabled.
3. Save the connection.
4. However, the functionality is working as if the box was checked:
5. Navigate to SQL Lab > SQL Editor on the top navigation bar.
6. Execute a query on this newly connected database.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] sadpandajoe commented on pull request #19883: fix(allow-db-explore): make to check the allow virtual table explore option by default
Posted by GitBox <gi...@apache.org>.
sadpandajoe commented on PR #19883:
URL: https://github.com/apache/superset/pull/19883#issuecomment-1115140656
🏷️ preset:2022.17
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #19883: fix(allow-db-explore): make to check the allow virtual table explore option by default
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #19883:
URL: https://github.com/apache/superset/pull/19883#issuecomment-1112529759
@yousoph Ephemeral environment spinning up at http://34.220.182.132:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #19883: fix(allow-db-explore): make to check the allow virtual table explore option by default
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #19883:
URL: https://github.com/apache/superset/pull/19883#issuecomment-1112597592
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #19883: fix(allow-db-explore): make to check the allow virtual table explore option by default
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #19883:
URL: https://github.com/apache/superset/pull/19883#issuecomment-1112258275
# [Codecov](https://codecov.io/gh/apache/superset/pull/19883?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19883](https://codecov.io/gh/apache/superset/pull/19883?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (48bc47a) into [master](https://codecov.io/gh/apache/superset/commit/1d50665da06da8bc619dea16554c22d6dd0f74b7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1d50665) will **not change** coverage.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #19883 +/- ##
=======================================
Coverage 66.52% 66.52%
=======================================
Files 1714 1714
Lines 65031 65031
Branches 6714 6714
=======================================
Hits 43259 43259
Misses 20065 20065
Partials 1707 1707
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `51.24% <100.00%> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19883?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...c/views/CRUD/data/database/DatabaseModal/index.tsx](https://codecov.io/gh/apache/superset/pull/19883/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsL2luZGV4LnRzeA==) | `32.51% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19883?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19883?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [1d50665...48bc47a](https://codecov.io/gh/apache/superset/pull/19883?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] yousoph commented on pull request #19883: fix(allow-db-explore): make to check the allow virtual table explore option by default
Posted by GitBox <gi...@apache.org>.
yousoph commented on PR #19883:
URL: https://github.com/apache/superset/pull/19883#issuecomment-1112527830
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] pkdotson merged pull request #19883: fix(allow-db-explore): make to check the allow virtual table explore option by default
Posted by GitBox <gi...@apache.org>.
pkdotson merged PR #19883:
URL: https://github.com/apache/superset/pull/19883
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org