You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Siddharth Seth (JIRA)" <ji...@apache.org> on 2012/08/27 23:43:08 UTC
[jira] [Created] (MAPREDUCE-4596) Split StateMachine state from
states seen by MRClientProtocol (for Job, Task, TaskAttempt)
Siddharth Seth created MAPREDUCE-4596:
-----------------------------------------
Summary: Split StateMachine state from states seen by MRClientProtocol (for Job, Task, TaskAttempt)
Key: MAPREDUCE-4596
URL: https://issues.apache.org/jira/browse/MAPREDUCE-4596
Project: Hadoop Map/Reduce
Issue Type: Task
Components: applicationmaster, mrv2
Affects Versions: 0.23.0
Reporter: Siddharth Seth
Assignee: Siddharth Seth
State machine states are currently exposed via MRClienProtocol. This makes it tough to modify the AM state machines, or have an alternate AM with different state machines (MR-3902) without the changes being visible in MRClientProtocol (MRv2 equivalent of ClientProtocol).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4596) Split StateMachine state from
states seen by MRClientProtocol (for Job, Task, TaskAttempt)
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13479998#comment-13479998 ]
Hudson commented on MAPREDUCE-4596:
-----------------------------------
Integrated in Hadoop-Hdfs-trunk #1200 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1200/])
MAPREDUCE-4596. Split StateMachine state from states seen by MRClientProtocol for Job, Task and TaskAttempt. Contributed by Siddarth Seth. (Revision 1399976)
Result = SUCCESS
vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1399976
Files :
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/JobStateInternal.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/TaskAttemptStateInternal.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/TaskStateInternal.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/impl/JobImpl.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/impl/TaskAttemptImpl.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/impl/TaskImpl.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/rm/RMCommunicator.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/speculate/DefaultSpeculator.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/MRApp.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/TestFail.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/TestRMContainerAllocator.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/job/impl/TestJobImpl.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/job/impl/TestTaskImpl.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/launcher/TestContainerLauncher.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/TypeConverter.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/api/records/JobState.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/api/records/TaskAttemptState.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/api/records/TaskState.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/util/MRApps.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/proto/mr_protos.proto
> Split StateMachine state from states seen by MRClientProtocol (for Job, Task, TaskAttempt)
> ------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4596
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4596
> Project: Hadoop Map/Reduce
> Issue Type: Task
> Components: applicationmaster, mrv2
> Affects Versions: 0.23.0
> Reporter: Siddharth Seth
> Assignee: Siddharth Seth
> Fix For: 2.0.3-alpha, 0.23.5
>
> Attachments: MR4596_2.txt, MR4596_3.txt, MR4596_4.txt, MR4596-branch23_1.txt, MR4596-branch23_2.txt, MR4596.txt
>
>
> State machine states are currently exposed via MRClienProtocol. This makes it tough to modify the AM state machines, or have an alternate AM with different state machines (MR-3902) without the changes being visible in MRClientProtocol (MRv2 equivalent of ClientProtocol).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4596) Split StateMachine state from
states seen by MRClientProtocol (for Job, Task, TaskAttempt)
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13455338#comment-13455338 ]
Hadoop QA commented on MAPREDUCE-4596:
--------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12545055/MR4596_2.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 8 new or modified test files.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2852//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2852//console
This message is automatically generated.
> Split StateMachine state from states seen by MRClientProtocol (for Job, Task, TaskAttempt)
> ------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4596
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4596
> Project: Hadoop Map/Reduce
> Issue Type: Task
> Components: applicationmaster, mrv2
> Affects Versions: 0.23.0
> Reporter: Siddharth Seth
> Assignee: Siddharth Seth
> Attachments: MR4596_2.txt, MR4596.txt
>
>
> State machine states are currently exposed via MRClienProtocol. This makes it tough to modify the AM state machines, or have an alternate AM with different state machines (MR-3902) without the changes being visible in MRClientProtocol (MRv2 equivalent of ClientProtocol).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-4596) Split StateMachine state from
states seen by MRClientProtocol (for Job, Task, TaskAttempt)
Posted by "Siddharth Seth (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Siddharth Seth updated MAPREDUCE-4596:
--------------------------------------
Attachment: MR4596-branch23_1.txt
Patch for branch-0.23
> Split StateMachine state from states seen by MRClientProtocol (for Job, Task, TaskAttempt)
> ------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4596
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4596
> Project: Hadoop Map/Reduce
> Issue Type: Task
> Components: applicationmaster, mrv2
> Affects Versions: 0.23.0
> Reporter: Siddharth Seth
> Assignee: Siddharth Seth
> Attachments: MR4596_2.txt, MR4596-branch23_1.txt, MR4596.txt
>
>
> State machine states are currently exposed via MRClienProtocol. This makes it tough to modify the AM state machines, or have an alternate AM with different state machines (MR-3902) without the changes being visible in MRClientProtocol (MRv2 equivalent of ClientProtocol).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-4596) Split StateMachine state from
states seen by MRClientProtocol (for Job, Task, TaskAttempt)
Posted by "Vinod Kumar Vavilapalli (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vinod Kumar Vavilapalli updated MAPREDUCE-4596:
-----------------------------------------------
Status: Open (was: Patch Available)
Looking through the patch again, found a bug. We no longer have a TaskAttemptState.UNASSIGNED, so the method {{TaskAttemptState toYarn(org.apache.hadoop.mapred.TaskStatus.State state)}} will fail. To avoid these bugs in future, we may explicitly code all the states instead of using .valueOf().
> Split StateMachine state from states seen by MRClientProtocol (for Job, Task, TaskAttempt)
> ------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4596
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4596
> Project: Hadoop Map/Reduce
> Issue Type: Task
> Components: applicationmaster, mrv2
> Affects Versions: 0.23.0
> Reporter: Siddharth Seth
> Assignee: Siddharth Seth
> Attachments: MR4596_2.txt, MR4596_3.txt, MR4596-branch23_1.txt, MR4596.txt
>
>
> State machine states are currently exposed via MRClienProtocol. This makes it tough to modify the AM state machines, or have an alternate AM with different state machines (MR-3902) without the changes being visible in MRClientProtocol (MRv2 equivalent of ClientProtocol).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-4596) Split StateMachine state from
states seen by MRClientProtocol (for Job, Task, TaskAttempt)
Posted by "Siddharth Seth (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Siddharth Seth updated MAPREDUCE-4596:
--------------------------------------
Attachment: MR4596-branch23_2.txt
Thanks for looking at this, and good catch. Uploading patches with explicit state checks.
> Split StateMachine state from states seen by MRClientProtocol (for Job, Task, TaskAttempt)
> ------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4596
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4596
> Project: Hadoop Map/Reduce
> Issue Type: Task
> Components: applicationmaster, mrv2
> Affects Versions: 0.23.0
> Reporter: Siddharth Seth
> Assignee: Siddharth Seth
> Attachments: MR4596_2.txt, MR4596_3.txt, MR4596_4.txt, MR4596-branch23_1.txt, MR4596-branch23_2.txt, MR4596.txt
>
>
> State machine states are currently exposed via MRClienProtocol. This makes it tough to modify the AM state machines, or have an alternate AM with different state machines (MR-3902) without the changes being visible in MRClientProtocol (MRv2 equivalent of ClientProtocol).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-4596) Split StateMachine state from
states seen by MRClientProtocol (for Job, Task, TaskAttempt)
Posted by "Siddharth Seth (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Siddharth Seth updated MAPREDUCE-4596:
--------------------------------------
Attachment: MR4596_b3902.txt
Thanks Vinod. Uploading a patch which applies to app2 in branch MR-3902.
Before committing this, will reset TaskAttemptState, mr_protos on the MR-3902 branch so that the merge from trunk is clean.
> Split StateMachine state from states seen by MRClientProtocol (for Job, Task, TaskAttempt)
> ------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4596
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4596
> Project: Hadoop Map/Reduce
> Issue Type: Task
> Components: applicationmaster, mrv2
> Affects Versions: 0.23.0
> Reporter: Siddharth Seth
> Assignee: Siddharth Seth
> Fix For: 2.0.3-alpha, 0.23.5
>
> Attachments: MR4596_2.txt, MR4596_3.txt, MR4596_4.txt, MR4596_b3902.txt, MR4596-branch23_1.txt, MR4596-branch23_2.txt, MR4596.txt
>
>
> State machine states are currently exposed via MRClienProtocol. This makes it tough to modify the AM state machines, or have an alternate AM with different state machines (MR-3902) without the changes being visible in MRClientProtocol (MRv2 equivalent of ClientProtocol).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4596) Split StateMachine state from
states seen by MRClientProtocol (for Job, Task, TaskAttempt)
Posted by "Siddharth Seth (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13455155#comment-13455155 ]
Siddharth Seth commented on MAPREDUCE-4596:
-------------------------------------------
Thanks for the review.
bq. How about JobStateInternal, TaskStateInternal and TaskAttemptInternal?
Yep. The current names are terrible. Was trying to keep them short considering their extensive use in state machine definition.
bq. Also, Job,Task and TaskAttempt (internal) interfaces don't need to expose the (external) JobState/TaskState etc.
Unfortunately, the history server is tied to these interfaces. Not exposing the external state, would mean the history server may not be usable across minor AM changes.
Eventually, we could change the history server to rely on hadoop-mapreduce-client-api - instead of a specific app, and ensure that no other module depends on the Job,Task,TaskAttempt interfaces. For now though, I think we need to keep the external getState(). Will try getting rid of the internal getState() though - since that should not be used anywhere outside of the hadoop-mapreduce-client-app module.
bq. Interesting question is about the 0.23 releases and their compatibility
I don't see the point of retaining proto field numbers if this will change. The options I see are
1) Don't change the hadoop-mapreduce-client-api states. Would allow a .23 client to talk to a 2.0 AM.
2) Define states in hadoop-mapreduce-client-api which are useful to the client. 0.23 clients may fail when talking to 2.0 AMs. I'd prefer this option - since I don't think the APIs are finalized yet, MRv1 APIs are being touched, and there's several states like KILL_CONTAINER_CLEANUP, KILL_TASK_CLEANUP - which don't make a lot of sense for clients.
> Split StateMachine state from states seen by MRClientProtocol (for Job, Task, TaskAttempt)
> ------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4596
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4596
> Project: Hadoop Map/Reduce
> Issue Type: Task
> Components: applicationmaster, mrv2
> Affects Versions: 0.23.0
> Reporter: Siddharth Seth
> Assignee: Siddharth Seth
> Attachments: MR4596.txt
>
>
> State machine states are currently exposed via MRClienProtocol. This makes it tough to modify the AM state machines, or have an alternate AM with different state machines (MR-3902) without the changes being visible in MRClientProtocol (MRv2 equivalent of ClientProtocol).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4596) Split StateMachine state from
states seen by MRClientProtocol (for Job, Task, TaskAttempt)
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13477344#comment-13477344 ]
Hadoop QA commented on MAPREDUCE-4596:
--------------------------------------
{color:green}+1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12549380/MR4596_3.txt
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author tags.
{color:green}+1 tests included{color}. The patch appears to include 6 new or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2931//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2931//console
This message is automatically generated.
> Split StateMachine state from states seen by MRClientProtocol (for Job, Task, TaskAttempt)
> ------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4596
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4596
> Project: Hadoop Map/Reduce
> Issue Type: Task
> Components: applicationmaster, mrv2
> Affects Versions: 0.23.0
> Reporter: Siddharth Seth
> Assignee: Siddharth Seth
> Attachments: MR4596_2.txt, MR4596_3.txt, MR4596-branch23_1.txt, MR4596.txt
>
>
> State machine states are currently exposed via MRClienProtocol. This makes it tough to modify the AM state machines, or have an alternate AM with different state machines (MR-3902) without the changes being visible in MRClientProtocol (MRv2 equivalent of ClientProtocol).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-4596) Split StateMachine state from
states seen by MRClientProtocol (for Job, Task, TaskAttempt)
Posted by "Siddharth Seth (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Siddharth Seth updated MAPREDUCE-4596:
--------------------------------------
Attachment: MR4596.txt
Patch for trunk.
It does get rid of some of the states in TaskAttemptState. Have retained the proto field numbers for now. Can change the patch to re-use older ones.
> Split StateMachine state from states seen by MRClientProtocol (for Job, Task, TaskAttempt)
> ------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4596
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4596
> Project: Hadoop Map/Reduce
> Issue Type: Task
> Components: applicationmaster, mrv2
> Affects Versions: 0.23.0
> Reporter: Siddharth Seth
> Assignee: Siddharth Seth
> Attachments: MR4596.txt
>
>
> State machine states are currently exposed via MRClienProtocol. This makes it tough to modify the AM state machines, or have an alternate AM with different state machines (MR-3902) without the changes being visible in MRClientProtocol (MRv2 equivalent of ClientProtocol).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4596) Split StateMachine state from
states seen by MRClientProtocol (for Job, Task, TaskAttempt)
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13479935#comment-13479935 ]
Hudson commented on MAPREDUCE-4596:
-----------------------------------
Integrated in Hadoop-Yarn-trunk #8 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/8/])
MAPREDUCE-4596. Split StateMachine state from states seen by MRClientProtocol for Job, Task and TaskAttempt. Contributed by Siddarth Seth. (Revision 1399976)
Result = FAILURE
vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1399976
Files :
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/JobStateInternal.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/TaskAttemptStateInternal.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/TaskStateInternal.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/impl/JobImpl.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/impl/TaskAttemptImpl.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/impl/TaskImpl.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/rm/RMCommunicator.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/speculate/DefaultSpeculator.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/MRApp.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/TestFail.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/TestRMContainerAllocator.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/job/impl/TestJobImpl.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/job/impl/TestTaskImpl.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/launcher/TestContainerLauncher.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/TypeConverter.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/api/records/JobState.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/api/records/TaskAttemptState.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/api/records/TaskState.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/util/MRApps.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/proto/mr_protos.proto
> Split StateMachine state from states seen by MRClientProtocol (for Job, Task, TaskAttempt)
> ------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4596
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4596
> Project: Hadoop Map/Reduce
> Issue Type: Task
> Components: applicationmaster, mrv2
> Affects Versions: 0.23.0
> Reporter: Siddharth Seth
> Assignee: Siddharth Seth
> Fix For: 2.0.3-alpha, 0.23.5
>
> Attachments: MR4596_2.txt, MR4596_3.txt, MR4596_4.txt, MR4596-branch23_1.txt, MR4596-branch23_2.txt, MR4596.txt
>
>
> State machine states are currently exposed via MRClienProtocol. This makes it tough to modify the AM state machines, or have an alternate AM with different state machines (MR-3902) without the changes being visible in MRClientProtocol (MRv2 equivalent of ClientProtocol).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4596) Split StateMachine state from
states seen by MRClientProtocol (for Job, Task, TaskAttempt)
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13479980#comment-13479980 ]
Hudson commented on MAPREDUCE-4596:
-----------------------------------
Integrated in Hadoop-Hdfs-0.23-Build #409 (See [https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/409/])
MAPREDUCE-4596. Split StateMachine state from states seen by MRClientProtocol for Job, Task and TaskAttempt. Contributed by Siddarth Seth. (Revision 1399978)
Result = SUCCESS
vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1399978
Files :
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/JobStateInternal.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/TaskAttemptStateInternal.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/TaskStateInternal.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/impl/JobImpl.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/impl/TaskAttemptImpl.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/impl/TaskImpl.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/speculate/DefaultSpeculator.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/MRApp.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/TestFail.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/TestRMContainerAllocator.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/job/impl/TestJobImpl.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/job/impl/TestTaskImpl.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/launcher/TestContainerLauncher.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/TypeConverter.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/api/records/JobState.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/api/records/TaskAttemptState.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/api/records/TaskState.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/util/MRApps.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/proto/mr_protos.proto
> Split StateMachine state from states seen by MRClientProtocol (for Job, Task, TaskAttempt)
> ------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4596
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4596
> Project: Hadoop Map/Reduce
> Issue Type: Task
> Components: applicationmaster, mrv2
> Affects Versions: 0.23.0
> Reporter: Siddharth Seth
> Assignee: Siddharth Seth
> Fix For: 2.0.3-alpha, 0.23.5
>
> Attachments: MR4596_2.txt, MR4596_3.txt, MR4596_4.txt, MR4596-branch23_1.txt, MR4596-branch23_2.txt, MR4596.txt
>
>
> State machine states are currently exposed via MRClienProtocol. This makes it tough to modify the AM state machines, or have an alternate AM with different state machines (MR-3902) without the changes being visible in MRClientProtocol (MRv2 equivalent of ClientProtocol).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-4596) Split StateMachine state from
states seen by MRClientProtocol (for Job, Task, TaskAttempt)
Posted by "Vinod Kumar Vavilapalli (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vinod Kumar Vavilapalli updated MAPREDUCE-4596:
-----------------------------------------------
Resolution: Fixed
Fix Version/s: 0.23.5
2.0.3-alpha
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
I just committed this to trunk, branch-2 and branch-0.23. Thanks Sid!
Please merge it into branch MR-3902 as necessary.
> Split StateMachine state from states seen by MRClientProtocol (for Job, Task, TaskAttempt)
> ------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4596
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4596
> Project: Hadoop Map/Reduce
> Issue Type: Task
> Components: applicationmaster, mrv2
> Affects Versions: 0.23.0
> Reporter: Siddharth Seth
> Assignee: Siddharth Seth
> Fix For: 2.0.3-alpha, 0.23.5
>
> Attachments: MR4596_2.txt, MR4596_3.txt, MR4596_4.txt, MR4596-branch23_1.txt, MR4596-branch23_2.txt, MR4596.txt
>
>
> State machine states are currently exposed via MRClienProtocol. This makes it tough to modify the AM state machines, or have an alternate AM with different state machines (MR-3902) without the changes being visible in MRClientProtocol (MRv2 equivalent of ClientProtocol).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4596) Split StateMachine state from
states seen by MRClientProtocol (for Job, Task, TaskAttempt)
Posted by "Vinod Kumar Vavilapalli (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13442752#comment-13442752 ]
Vinod Kumar Vavilapalli commented on MAPREDUCE-4596:
----------------------------------------------------
+1 for the proposal. Will look at the patch. Makes sense to do it on trunk too at the same time as this.
> Split StateMachine state from states seen by MRClientProtocol (for Job, Task, TaskAttempt)
> ------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4596
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4596
> Project: Hadoop Map/Reduce
> Issue Type: Task
> Components: applicationmaster, mrv2
> Affects Versions: 0.23.0
> Reporter: Siddharth Seth
> Assignee: Siddharth Seth
> Attachments: MR4596.txt
>
>
> State machine states are currently exposed via MRClienProtocol. This makes it tough to modify the AM state machines, or have an alternate AM with different state machines (MR-3902) without the changes being visible in MRClientProtocol (MRv2 equivalent of ClientProtocol).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-4596) Split StateMachine state from
states seen by MRClientProtocol (for Job, Task, TaskAttempt)
Posted by "Siddharth Seth (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Siddharth Seth updated MAPREDUCE-4596:
--------------------------------------
Attachment: MR4596_2.txt
Updated patch with Names fixed, getInternalState() removed from Job, Task, TaskAttempt. Also, changed to re-use protobuf field numbers.
> Split StateMachine state from states seen by MRClientProtocol (for Job, Task, TaskAttempt)
> ------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4596
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4596
> Project: Hadoop Map/Reduce
> Issue Type: Task
> Components: applicationmaster, mrv2
> Affects Versions: 0.23.0
> Reporter: Siddharth Seth
> Assignee: Siddharth Seth
> Attachments: MR4596_2.txt, MR4596.txt
>
>
> State machine states are currently exposed via MRClienProtocol. This makes it tough to modify the AM state machines, or have an alternate AM with different state machines (MR-3902) without the changes being visible in MRClientProtocol (MRv2 equivalent of ClientProtocol).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-4596) Split StateMachine state from
states seen by MRClientProtocol (for Job, Task, TaskAttempt)
Posted by "Siddharth Seth (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Siddharth Seth updated MAPREDUCE-4596:
--------------------------------------
Status: Patch Available (was: Open)
> Split StateMachine state from states seen by MRClientProtocol (for Job, Task, TaskAttempt)
> ------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4596
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4596
> Project: Hadoop Map/Reduce
> Issue Type: Task
> Components: applicationmaster, mrv2
> Affects Versions: 0.23.0
> Reporter: Siddharth Seth
> Assignee: Siddharth Seth
> Attachments: MR4596_2.txt, MR4596_3.txt, MR4596_4.txt, MR4596-branch23_1.txt, MR4596-branch23_2.txt, MR4596.txt
>
>
> State machine states are currently exposed via MRClienProtocol. This makes it tough to modify the AM state machines, or have an alternate AM with different state machines (MR-3902) without the changes being visible in MRClientProtocol (MRv2 equivalent of ClientProtocol).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4596) Split StateMachine state from
states seen by MRClientProtocol (for Job, Task, TaskAttempt)
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13479407#comment-13479407 ]
Hadoop QA commented on MAPREDUCE-4596:
--------------------------------------
{color:green}+1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12549757/MR4596_4.txt
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author tags.
{color:green}+1 tests included{color}. The patch appears to include 6 new or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2940//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2940//console
This message is automatically generated.
> Split StateMachine state from states seen by MRClientProtocol (for Job, Task, TaskAttempt)
> ------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4596
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4596
> Project: Hadoop Map/Reduce
> Issue Type: Task
> Components: applicationmaster, mrv2
> Affects Versions: 0.23.0
> Reporter: Siddharth Seth
> Assignee: Siddharth Seth
> Attachments: MR4596_2.txt, MR4596_3.txt, MR4596_4.txt, MR4596-branch23_1.txt, MR4596-branch23_2.txt, MR4596.txt
>
>
> State machine states are currently exposed via MRClienProtocol. This makes it tough to modify the AM state machines, or have an alternate AM with different state machines (MR-3902) without the changes being visible in MRClientProtocol (MRv2 equivalent of ClientProtocol).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-4596) Split StateMachine state from
states seen by MRClientProtocol (for Job, Task, TaskAttempt)
Posted by "Vinod Kumar Vavilapalli (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vinod Kumar Vavilapalli updated MAPREDUCE-4596:
-----------------------------------------------
Status: Open (was: Patch Available)
How about JobStateInternal, TaskStateInternal and TaskAttemptInternal?
Also, Job,Task and TaskAttempt (internal) interfaces don't need to expose the (external) JobState/TaskState etc.
Interesting question is about the 0.23 releases and their compatibility :)
> Split StateMachine state from states seen by MRClientProtocol (for Job, Task, TaskAttempt)
> ------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4596
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4596
> Project: Hadoop Map/Reduce
> Issue Type: Task
> Components: applicationmaster, mrv2
> Affects Versions: 0.23.0
> Reporter: Siddharth Seth
> Assignee: Siddharth Seth
> Attachments: MR4596.txt
>
>
> State machine states are currently exposed via MRClienProtocol. This makes it tough to modify the AM state machines, or have an alternate AM with different state machines (MR-3902) without the changes being visible in MRClientProtocol (MRv2 equivalent of ClientProtocol).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-4596) Split StateMachine state from
states seen by MRClientProtocol (for Job, Task, TaskAttempt)
Posted by "Siddharth Seth (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Siddharth Seth updated MAPREDUCE-4596:
--------------------------------------
Status: Patch Available (was: Open)
> Split StateMachine state from states seen by MRClientProtocol (for Job, Task, TaskAttempt)
> ------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4596
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4596
> Project: Hadoop Map/Reduce
> Issue Type: Task
> Components: applicationmaster, mrv2
> Affects Versions: 0.23.0
> Reporter: Siddharth Seth
> Assignee: Siddharth Seth
> Attachments: MR4596_2.txt, MR4596.txt
>
>
> State machine states are currently exposed via MRClienProtocol. This makes it tough to modify the AM state machines, or have an alternate AM with different state machines (MR-3902) without the changes being visible in MRClientProtocol (MRv2 equivalent of ClientProtocol).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4596) Split StateMachine state from
states seen by MRClientProtocol (for Job, Task, TaskAttempt)
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13480031#comment-13480031 ]
Hudson commented on MAPREDUCE-4596:
-----------------------------------
Integrated in Hadoop-Mapreduce-trunk #1230 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1230/])
MAPREDUCE-4596. Split StateMachine state from states seen by MRClientProtocol for Job, Task and TaskAttempt. Contributed by Siddarth Seth. (Revision 1399976)
Result = SUCCESS
vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1399976
Files :
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/JobStateInternal.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/TaskAttemptStateInternal.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/TaskStateInternal.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/impl/JobImpl.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/impl/TaskAttemptImpl.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/impl/TaskImpl.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/rm/RMCommunicator.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/speculate/DefaultSpeculator.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/MRApp.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/TestFail.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/TestRMContainerAllocator.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/job/impl/TestJobImpl.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/job/impl/TestTaskImpl.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/launcher/TestContainerLauncher.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/TypeConverter.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/api/records/JobState.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/api/records/TaskAttemptState.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/api/records/TaskState.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/util/MRApps.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/proto/mr_protos.proto
> Split StateMachine state from states seen by MRClientProtocol (for Job, Task, TaskAttempt)
> ------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4596
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4596
> Project: Hadoop Map/Reduce
> Issue Type: Task
> Components: applicationmaster, mrv2
> Affects Versions: 0.23.0
> Reporter: Siddharth Seth
> Assignee: Siddharth Seth
> Fix For: 2.0.3-alpha, 0.23.5
>
> Attachments: MR4596_2.txt, MR4596_3.txt, MR4596_4.txt, MR4596-branch23_1.txt, MR4596-branch23_2.txt, MR4596.txt
>
>
> State machine states are currently exposed via MRClienProtocol. This makes it tough to modify the AM state machines, or have an alternate AM with different state machines (MR-3902) without the changes being visible in MRClientProtocol (MRv2 equivalent of ClientProtocol).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-4596) Split StateMachine state from
states seen by MRClientProtocol (for Job, Task, TaskAttempt)
Posted by "Siddharth Seth (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Siddharth Seth updated MAPREDUCE-4596:
--------------------------------------
Status: Patch Available (was: Open)
> Split StateMachine state from states seen by MRClientProtocol (for Job, Task, TaskAttempt)
> ------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4596
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4596
> Project: Hadoop Map/Reduce
> Issue Type: Task
> Components: applicationmaster, mrv2
> Affects Versions: 0.23.0
> Reporter: Siddharth Seth
> Assignee: Siddharth Seth
> Attachments: MR4596.txt
>
>
> State machine states are currently exposed via MRClienProtocol. This makes it tough to modify the AM state machines, or have an alternate AM with different state machines (MR-3902) without the changes being visible in MRClientProtocol (MRv2 equivalent of ClientProtocol).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4596) Split StateMachine state from
states seen by MRClientProtocol (for Job, Task, TaskAttempt)
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13442800#comment-13442800 ]
Hadoop QA commented on MAPREDUCE-4596:
--------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12542676/MR4596.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 8 new or modified test files.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2778//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2778//console
This message is automatically generated.
> Split StateMachine state from states seen by MRClientProtocol (for Job, Task, TaskAttempt)
> ------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4596
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4596
> Project: Hadoop Map/Reduce
> Issue Type: Task
> Components: applicationmaster, mrv2
> Affects Versions: 0.23.0
> Reporter: Siddharth Seth
> Assignee: Siddharth Seth
> Attachments: MR4596.txt
>
>
> State machine states are currently exposed via MRClienProtocol. This makes it tough to modify the AM state machines, or have an alternate AM with different state machines (MR-3902) without the changes being visible in MRClientProtocol (MRv2 equivalent of ClientProtocol).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-4596) Split StateMachine state from
states seen by MRClientProtocol (for Job, Task, TaskAttempt)
Posted by "Siddharth Seth (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Siddharth Seth updated MAPREDUCE-4596:
--------------------------------------
Target Version/s: 2.0.2-alpha, MR-3902, 0.23.5 (was: 2.0.2-alpha, MR-3902)
Status: Open (was: Patch Available)
> Split StateMachine state from states seen by MRClientProtocol (for Job, Task, TaskAttempt)
> ------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4596
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4596
> Project: Hadoop Map/Reduce
> Issue Type: Task
> Components: applicationmaster, mrv2
> Affects Versions: 0.23.0
> Reporter: Siddharth Seth
> Assignee: Siddharth Seth
> Attachments: MR4596_2.txt, MR4596-branch23_1.txt, MR4596.txt
>
>
> State machine states are currently exposed via MRClienProtocol. This makes it tough to modify the AM state machines, or have an alternate AM with different state machines (MR-3902) without the changes being visible in MRClientProtocol (MRv2 equivalent of ClientProtocol).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4596) Split StateMachine state from
states seen by MRClientProtocol (for Job, Task, TaskAttempt)
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13479656#comment-13479656 ]
Hudson commented on MAPREDUCE-4596:
-----------------------------------
Integrated in Hadoop-trunk-Commit #2894 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/2894/])
MAPREDUCE-4596. Split StateMachine state from states seen by MRClientProtocol for Job, Task and TaskAttempt. Contributed by Siddarth Seth. (Revision 1399976)
Result = SUCCESS
vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1399976
Files :
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/JobStateInternal.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/TaskAttemptStateInternal.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/TaskStateInternal.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/impl/JobImpl.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/impl/TaskAttemptImpl.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/impl/TaskImpl.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/rm/RMCommunicator.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/speculate/DefaultSpeculator.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/MRApp.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/TestFail.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/TestRMContainerAllocator.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/job/impl/TestJobImpl.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/job/impl/TestTaskImpl.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/launcher/TestContainerLauncher.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/TypeConverter.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/api/records/JobState.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/api/records/TaskAttemptState.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/api/records/TaskState.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/util/MRApps.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/proto/mr_protos.proto
> Split StateMachine state from states seen by MRClientProtocol (for Job, Task, TaskAttempt)
> ------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4596
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4596
> Project: Hadoop Map/Reduce
> Issue Type: Task
> Components: applicationmaster, mrv2
> Affects Versions: 0.23.0
> Reporter: Siddharth Seth
> Assignee: Siddharth Seth
> Fix For: 2.0.3-alpha, 0.23.5
>
> Attachments: MR4596_2.txt, MR4596_3.txt, MR4596_4.txt, MR4596-branch23_1.txt, MR4596-branch23_2.txt, MR4596.txt
>
>
> State machine states are currently exposed via MRClienProtocol. This makes it tough to modify the AM state machines, or have an alternate AM with different state machines (MR-3902) without the changes being visible in MRClientProtocol (MRv2 equivalent of ClientProtocol).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-4596) Split StateMachine state from
states seen by MRClientProtocol (for Job, Task, TaskAttempt)
Posted by "Siddharth Seth (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Siddharth Seth updated MAPREDUCE-4596:
--------------------------------------
Status: Patch Available (was: Open)
> Split StateMachine state from states seen by MRClientProtocol (for Job, Task, TaskAttempt)
> ------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4596
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4596
> Project: Hadoop Map/Reduce
> Issue Type: Task
> Components: applicationmaster, mrv2
> Affects Versions: 0.23.0
> Reporter: Siddharth Seth
> Assignee: Siddharth Seth
> Attachments: MR4596_2.txt, MR4596_3.txt, MR4596-branch23_1.txt, MR4596.txt
>
>
> State machine states are currently exposed via MRClienProtocol. This makes it tough to modify the AM state machines, or have an alternate AM with different state machines (MR-3902) without the changes being visible in MRClientProtocol (MRv2 equivalent of ClientProtocol).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-4596) Split StateMachine state from
states seen by MRClientProtocol (for Job, Task, TaskAttempt)
Posted by "Siddharth Seth (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Siddharth Seth updated MAPREDUCE-4596:
--------------------------------------
Attachment: MR4596_3.txt
Updated patch for trunk. This removes a couple of states from JobState / TaskState as well.
Proto field numbers are re-used.
> Split StateMachine state from states seen by MRClientProtocol (for Job, Task, TaskAttempt)
> ------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4596
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4596
> Project: Hadoop Map/Reduce
> Issue Type: Task
> Components: applicationmaster, mrv2
> Affects Versions: 0.23.0
> Reporter: Siddharth Seth
> Assignee: Siddharth Seth
> Attachments: MR4596_2.txt, MR4596_3.txt, MR4596-branch23_1.txt, MR4596.txt
>
>
> State machine states are currently exposed via MRClienProtocol. This makes it tough to modify the AM state machines, or have an alternate AM with different state machines (MR-3902) without the changes being visible in MRClientProtocol (MRv2 equivalent of ClientProtocol).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-4596) Split StateMachine state from
states seen by MRClientProtocol (for Job, Task, TaskAttempt)
Posted by "Siddharth Seth (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Siddharth Seth updated MAPREDUCE-4596:
--------------------------------------
Attachment: MR4596_4.txt
> Split StateMachine state from states seen by MRClientProtocol (for Job, Task, TaskAttempt)
> ------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4596
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4596
> Project: Hadoop Map/Reduce
> Issue Type: Task
> Components: applicationmaster, mrv2
> Affects Versions: 0.23.0
> Reporter: Siddharth Seth
> Assignee: Siddharth Seth
> Attachments: MR4596_2.txt, MR4596_3.txt, MR4596_4.txt, MR4596-branch23_1.txt, MR4596-branch23_2.txt, MR4596.txt
>
>
> State machine states are currently exposed via MRClienProtocol. This makes it tough to modify the AM state machines, or have an alternate AM with different state machines (MR-3902) without the changes being visible in MRClientProtocol (MRv2 equivalent of ClientProtocol).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-4596) Split StateMachine state from
states seen by MRClientProtocol (for Job, Task, TaskAttempt)
Posted by "Siddharth Seth (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Siddharth Seth updated MAPREDUCE-4596:
--------------------------------------
Fix Version/s: MR-3902
Fixed in branch MR-3902 as well.
> Split StateMachine state from states seen by MRClientProtocol (for Job, Task, TaskAttempt)
> ------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4596
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4596
> Project: Hadoop Map/Reduce
> Issue Type: Task
> Components: applicationmaster, mrv2
> Affects Versions: 0.23.0
> Reporter: Siddharth Seth
> Assignee: Siddharth Seth
> Fix For: MR-3902, 2.0.3-alpha, 0.23.5
>
> Attachments: MR4596_2.txt, MR4596_3.txt, MR4596_4.txt, MR4596_b3902.txt, MR4596-branch23_1.txt, MR4596-branch23_2.txt, MR4596.txt
>
>
> State machine states are currently exposed via MRClienProtocol. This makes it tough to modify the AM state machines, or have an alternate AM with different state machines (MR-3902) without the changes being visible in MRClientProtocol (MRv2 equivalent of ClientProtocol).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4596) Split StateMachine state from
states seen by MRClientProtocol (for Job, Task, TaskAttempt)
Posted by "Vinod Kumar Vavilapalli (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13477339#comment-13477339 ]
Vinod Kumar Vavilapalli commented on MAPREDUCE-4596:
----------------------------------------------------
Looks good overall.
One comment( that doesn't need a response). MRApps.TaskAttemptStateUI is almost same as external state now, but we can leave it as is because we primarily need it for the mapping.
+1. Will commit it once Jenkins blesses the patch.
> Split StateMachine state from states seen by MRClientProtocol (for Job, Task, TaskAttempt)
> ------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4596
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4596
> Project: Hadoop Map/Reduce
> Issue Type: Task
> Components: applicationmaster, mrv2
> Affects Versions: 0.23.0
> Reporter: Siddharth Seth
> Assignee: Siddharth Seth
> Attachments: MR4596_2.txt, MR4596_3.txt, MR4596-branch23_1.txt, MR4596.txt
>
>
> State machine states are currently exposed via MRClienProtocol. This makes it tough to modify the AM state machines, or have an alternate AM with different state machines (MR-3902) without the changes being visible in MRClientProtocol (MRv2 equivalent of ClientProtocol).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira