[GitHub] [incubator-iotdb] jt2594838 commented on a change in pull request #430: [IOTDB-193]Create schema automatically

[GitBox <gi...@apache.org>]

jt2594838 commented on a change in pull request #430: [IOTDB-193]Create schema automatically
URL: https://github.com/apache/incubator-iotdb/pull/430#discussion_r328959319
 
 

 ##########
 File path: server/src/main/java/org/apache/iotdb/db/qp/executor/QueryProcessExecutor.java
 ##########
 @@ -244,18 +271,47 @@ public boolean insert(InsertPlan insertPlan) throws ProcessorException {
     try {
       String[] measurementList = batchInsertPlan.getMeasurements();
       String deviceId = batchInsertPlan.getDeviceId();
-      MNode node = mManager.getNodeByDeviceIdFromCache(deviceId);
+      Object[] values = collectFirstElements(batchInsertPlan.getColumns());
 
 Review comment:
   I think you should delay the collection because not all insertions need schema creation.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services