[GitHub] [incubator-superset] villebro commented on a change in pull request #8433: [docs] Crafting a new release

[GitBox <gi...@apache.org>]

villebro commented on a change in pull request #8433: [docs] Crafting a new release
URL: https://github.com/apache/incubator-superset/pull/8433#discussion_r338209238
 
 

 ##########
 File path: RELEASING/README.md
 ##########
 @@ -74,6 +90,7 @@ Then you can generate other derived environment variables that are used
 throughout the release process:
 
 ```bash
+    export FULLNAME="Maxime Beauchemin"
 
 Review comment:
   Probably best to avoid using values that can cause misleading results if copy-pasted as such. Also always good to avoid introducing unnecessary PII where not necessary, eve if only as an example. In this case I would probably write `YOURFULLNAMEHERE` or similar to make it obvious that it needs to be replaced.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org